[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Alias|libpcapnav | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 |201449 Resolution||NOTABUG Flag|needinfo?([EMAIL PROTECTED] | |rg) | --- Comment #8 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-24 22:17:47 EDT --- Why return this to the queue? Why not just close it and save someone else the hassle of dealing with it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 Michael Schwendt [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag|fedora-review? | --- Comment #7 from Michael Schwendt [EMAIL PROTECTED] 2008-11-22 07:12:45 EDT --- No comment from the package submitter. I'm giving up for now. Also withdrawing the offer for sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 --- Comment #6 from Mamoru Tasaka [EMAIL PROTECTED] 2008-11-03 10:36:25 EDT --- What is the status of this bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 --- Comment #3 from Michael Schwendt [EMAIL PROTECTED] 2008-10-17 10:32:03 EDT --- License: BSD It looks like MIT http://www.opensource.org/licenses/mit-license.php with an advertising-clause. By comparison, this is the BSD licence: http://www.opensource.org/licenses/bsd-license.php -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 Andreas Thienemann [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #4 from Andreas Thienemann [EMAIL PROTECTED] 2008-10-17 10:50:19 EDT --- In case we want to shorten this a bit: SPEC: http://home.bawue.de/~ixs/libpcapnav/libpcapnav.spec SRPM: http://home.bawue.de/~ixs/libpcapnav/libpcapnav-0.8-1.fc9.src.rpm Libpcapnav is a libpcap wrapper library that allows navigation to arbitrary packets in a tcpdump trace file between reads, using timestamps or percentage offsets. It was originally based on Vern Paxson's tcpslice tool. [EMAIL PROTECTED] ~]$ rpmlint /var/lib/mock/fedora-rawhide-*/result/*.rpm libpcapnav-debuginfo.i386: E: non-standard-dir-perm /usr/src/debug/libpcapnav-0.8/src 02755 libpcapnav-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/libpcapnav-0.8/src 02755 8 packages and 0 specfiles checked; 2 errors, 0 warnings. [EMAIL PROTECTED] ~]$ Autogenerated packages, setgid error is ignorable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 --- Comment #5 from Michael Schwendt [EMAIL PROTECTED] 2008-10-17 11:11:44 EDT --- This is it: http://fedoraproject.org/wiki/Licensing/MIT#Old_Style_with_legal_disclaimer_3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460887
Michael Schwendt [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?,
||needinfo?([EMAIL PROTECTED]
||rg)
--- Comment #2 from Michael Schwendt [EMAIL PROTECTED] 2008-10-11 06:52:41
EDT ---
%define prefix /usr
Please give the rationale for making this package relocatable:
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines
Note that in your case it is a mistake:
pcapnav-config isn't relocatable.
$ rpmlint libpcapnav-0.8-1.src.rpm
libpcapnav.src:18: W: hardcoded-packager-tag Christian
Don't set Packager. Your name appears in the %changelog.
Setting the Packager tag should only be done in your local
build-system for binary rpms *you* have built. Publishing
src.rpms with a default Packager tag bears the risk that
other people build and publish bad binary rpms with your
name in the package header.
libpcapnav.src:20: W: hardcoded-prefix-tag %{prefix}
See top of review.
libpcapnav.src:47: W: configure-without-libdir-spec
Prefer the %configure macro where it works.
Run rpm --eval %configure to see what it does.
It also defines libdir as necessary.
libpcapnav.src:82: W: macro-in-%changelog prefix
Avoid macros in %changelog. Some cause damage when they expand.
You can escape them with a double %% as in %%prefix.
libpcapnav.src: W: no-version-in-last-changelog
It's preferred if you hardcode the package version-release
at the right of every changelog entry. Like:
* Tue Sep 02 2008 Christian Kreibich [EMAIL PROTECTED] - 0.8-1
- Fix /usr/lib/ file list.
$ rpmlint libpcapnav-devel-0.8-1.i386.rpm
libpcapnav-devel.i386: W: no-documentation
This can be ignored.
libpcapnav-devel.i386: E: library-without-ldconfig-postin
/usr/lib/libpcapnav.so.0.0.0
libpcapnav-devel.i386: E: library-without-ldconfig-postun
/usr/lib/libpcapnav.so.0.0.0
These errors are only because your %files section is wrong.
The *.so.* files belong into the main package, not the -devel pkg.
libpcapnav-devel.i386: W: no-version-dependency-on
libpcapnav/libpcapnav-libs/liblibpcapnav 0.8
Most -devel packages must
Requires: %{name} = %{version}-%{release}
so main pkg and -devel pkg are kept in sync for any changes.
libpcapnav-devel.i386: W: summary-ended-with-dot Development
and documentation files for libpcapnav.
Most times Summary is not a full sentence. It's preferred to
not end it with a dot.
$ rpmlint libpcapnav-0.8-1.i386.rpm
libpcapnav.i386: E: zero-length /usr/share/doc/libpcapnav-0.8/NEWS
libpcapnav.i386: E: explicit-lib-dependency libpcap
See comment on -devel pkg. This must be versioned.
%define version 0.8
Just do
Version: 0.8
instead of redefining %version earlier.
Release: 1
Using the %{dist} macro is not mandatory, but may be helpful if
using exactly the same src.rpm for several Fedora releases.
- Release: 1%{?dist}
# Using FTP to get around SourceForge's habit of adding something after
.tar.gz
Source: ftp://ftp.sf.net/pub/sourceforge/netdude/%{name}-%{version}.tar.gz
There are recommendations on working http links somewhere in the
Fedora Packaging Wiki.
Requires: libpcap
Delete this. There is an automatic dependency on the
libpcap SONAME added by rpmbuild. We rely on these dependencies.
Query the libpcapnav package to see.
%description devel
Static libraries, header files and documentation
for libpcapnav
We don't build and include static libs unless there is very good
reason to do that. Libtool archives (*.la) should be deleted, too.
%build
Build log contains many format string type warnings, e.g.
using %u for long int.
if [ $SMP != ]; then
There is %{?_smp_mflags} that can simply be appended to make.
make prefix=$RPM_BUILD_ROOT%{prefix} install
Use: make DESTDIR=$RPM_BUILD_ROOT install
Can the tests be run in the %check section of the spec?
Should they pass?
$ ./run-tests.sh
Running test 1 ... FAILED.
%files
%defattr(-,root,root,-)
%doc AUTHORS COPYING ChangeLog NEWS README
%{prefix}/lib/lib*.so.*
This would break on 64-bit multiarch platforms where there
is /usr/lib64 (and /usr/lib for 32-bit libs). Hence use:
%{_libdir}/*.so.*
%files devel
%defattr(-,root,root,-)
%doc %{prefix}/share/gtk-doc/html/pcapnav
This is empty and only adds empty directories to the pkg.
%{prefix}/lib/libpcapnav*
%_libdir
and include only the *.so symlink here:
%{_libdir}/*.so
%{prefix}/include/pcapnav.h
%_includedir
%{prefix}/bin/pcapnav-config
%_bindir
drwxr-xr-x
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 Michael Schwendt [EMAIL PROTECTED] changed: What|Removed |Added Blocks||460886 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||libpcapnav -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 --- Comment #1 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-12 01:50:41 EDT --- Your srpm does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=822047 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460887] Review Request: libpcapnav - a libpcap trace file navigation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460887 manuel wolfshant [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
