[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Chris Weyl <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #8 from Chris Weyl <[EMAIL PROTECTED]>  2008-10-06 22:57:38 EDT ---
Imported and built in devel.  Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Huzaifa S. Sidhpurwala <[EMAIL PROTECTED]> changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388





--- Comment #7 from Huzaifa S. Sidhpurwala <[EMAIL PROTECTED]>  2008-10-06 
05:40:41 EDT ---
cvs done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388





--- Comment #6 from Chris Weyl <[EMAIL PROTECTED]>  2008-10-04 00:12:42 EDT ---
New Package CVS Request
===
Package Name: perl-Mouse
Short Description: Moose minus the antlers
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Chris Weyl <[EMAIL PROTECTED]> changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Jason Tibbitts <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review+




--- Comment #5 from Jason Tibbitts <[EMAIL PROTECTED]>  2008-10-03 12:32:15 EDT 
---
I still don't understand how the Summary: helps to clarify much of anything,
but upstream seems to prefer humor over useful documentation so what can we do?
 Maybe consider "Lighter version of the Moose object system", but I don't think
it should hold up approval of this package.

Otherwise everything looks fine to me.

* source files match upstream:
   e075052ab45008e512d78dd340ed62b55923a0faf124887088869b1ae5aa7eaa  
   Mouse-0.09.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Mouse) = 0.09
   perl(Mouse::Meta::Attribute)
   perl(Mouse::Meta::Class)
   perl(Mouse::Meta::Role)
   perl(Mouse::Object)
   perl(Mouse::Role)
   perl(Mouse::Tiny)
   perl(Mouse::TypeRegistry)
   perl(Mouse::Util)
   perl(Squirrel)
   perl(Squirrel::Role)
   perl-Mouse = 0.09-1.fc10
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.10.0)
   perl(Carp)
   perl(Class::Method::Modifiers) >= 1.01
   perl(MRO::Compat) >= 0.09
   perl(Mouse::Meta::Attribute)
   perl(Mouse::Meta::Class)
   perl(Mouse::Meta::Role)
   perl(Mouse::Object)
   perl(Mouse::TypeRegistry)
   perl(Mouse::Util)
   perl(Scalar::Util) >= 1.19
   perl(Test::Exception) >= 0.27
   perl(base)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=46, Tests=2160, 3 wallclock secs
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-10-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388





--- Comment #4 from Chris Weyl <[EMAIL PROTECTED]>  2008-10-02 01:19:49 EDT ---
SRPM URL:
http://fedora.biggerontheinside.net/review/perl-Mouse-0.09-1.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Mouse.spec

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=856180

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388





--- Comment #3 from Chris Weyl <[EMAIL PROTECTED]>  2008-09-09 18:59:46 EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=816742

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388





--- Comment #2 from Chris Weyl <[EMAIL PROTECTED]>  2008-09-08 21:09:38 EDT ---
(In reply to comment #1)
> Can't build this yet, but I note that the %description above is almost
> completely content-free if you don't know what Moose is.

Just wait until they see Squirrel ;)  

How's this:

-
Moose, a powerful metaobject-fuelled extension of the Perl 5 object system,
is wonderful.  (For more information on Moose, please see 'perldoc Moose'
after installing the perl-Moose package.)

Unfortunately, it's a little slow. Though significant progress has been
made over the years, the compile time penalty is a non-starter for some
applications.  Mouse aims to alleviate this by providing a subset of Moose's
functionality, faster.
-

It builds on the first paragraph just a touch, and points people to the Moose
manpage at least...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Bug 461388 depends on bug 461386, which changed state.

Bug 461386 Summary: Review Request: perl-Class-Method-Modifiers - Provides 
Moose-like method modifiers
https://bugzilla.redhat.com/show_bug.cgi?id=461386

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-09-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388





--- Comment #1 from Jason Tibbitts <[EMAIL PROTECTED]>  2008-09-07 12:59:40 EDT 
---
Can't build this yet, but I note that the %description above is almost
completely content-free if you don't know what Moose is.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-09-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Chris Weyl <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Blocks|461386  |461383
 Depends on|461383  |461386




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461388] Review Request: perl-Mouse - Moose minus the antlers

2008-09-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461388


Chris Weyl <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Blocks||461386
 Depends on||461383




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review