[Bug 461976] Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget

2008-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461976


Chris Weyl [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
  Alias||perl-Gtk2-ImageView




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461976] Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget

2008-09-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461976





--- Comment #4 from Tom spot Callaway [EMAIL PROTECTED]  2008-09-12 
10:15:55 EDT ---
New Package CVS Request
===
Package Name: perl-Gtk2-ImageView
Short Description: Perl bindings to the GtkImageView image viewer widget
Owners: spot
Branches: F-8 F-9 devel
InitialCC: perl-sig

... and it's done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461976] Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget

2008-09-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461976


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #6 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-12 10:43:00 EDT 
---
*** Bug 453772 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461976] Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget

2008-09-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461976





--- Comment #2 from Tom spot Callaway [EMAIL PROTECTED]  2008-09-11 
14:22:18 EDT ---
I didn't see that one, apologies. Jesse Keating pointed out that we had broken
dependencies in rawhide, so I whipped up a package to fix it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461976] Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget

2008-09-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461976


Jesse Keating [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




--- Comment #3 from Jesse Keating [EMAIL PROTECTED]  2008-09-11 17:33:59 EDT 
---
I tried installing all the BuildRequires, including the listed koji build, but
when I tried to build the srpm I got:

+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor 'OPTIMIZE=-O2 -g'
Can't locate Gtk2.pm in @INC (@INC contains:
/usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/5.10.0
/usr/local/lib64/perl5/site_perl/5.10.0/x86_64-linux-thread-multi
/usr/local/lib/perl5/site_perl/5.10.0
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.10.0 /usr/lib/perl5/vendor_perl
/usr/local/lib/perl5/site_perl /usr/local/lib64/perl5/site_perl .) at (eval 9)
line 1.
BEGIN failed--compilation aborted at (eval 9) line 1.

Checking if your kit is complete...
Looks good
MakeMaker FATAL: prerequisites not found.
Gtk2 not installed

Please install these modules first and rerun 'perl Makefile.PL'.
error: Bad exit status from /var/tmp/rpm-tmp.cA3OLn (%build)


Looks like a missing BuildRequire on perl-Gtk2 (or the proper perl module
therein)

Other than that, it builds, passes rpmlint, and the spec looks fine regarding
both packaging guidelines and the specific perl guidelines.

Correct the missing BuildRequires and this is approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review