[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Richard W.M. Jones changed: What|Removed |Added CC||rjo...@redhat.com --- Comment #15 from Richard W.M. Jones 2009-06-09 05:23:45 EDT --- Package Change Request == Package Name: chntpw New Branches: EL-5 Owners: rjones -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Richard W.M. Jones changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #16 from Kevin Fenzi 2009-06-10 00:58:26 EDT --- Does Conrad want to maintain this in EPEL? or doesn't care? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #17 from Conrad Meyer 2009-06-10 03:34:53 EDT --- I have no interest in EPEL; Richard is totally free to take it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #18 from Jason Tibbitts 2009-06-10 16:52:58 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #19 from Richard W.M. Jones 2009-06-10 17:03:17 EDT --- Thanks Jason. Conrad - if you do need access to the EL-5 branch then just make the acl change request through pkgdb and I'll approve it straight away. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #20 from Conrad Meyer 2009-06-10 17:06:37 EDT --- Sure -- thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=465372
Patrice Dumas <[EMAIL PROTECTED]> changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Patrice Dumas <[EMAIL PROTECTED]> 2008-10-10 17:16:55 EDT
---
I can't see why you don't use the initial Makefile. Something along
make CC="%__cc" CFLAGS="$RPM_OPT_FLAGS" LIBS="-lcrpyto" chntpw cpnt reged
And use simple cp or install to install the resulting executables.
Using cmake while upstream doesn't seems too much to me.
openssl in requires is not useful, it is automatically found by rpm.
It is better to avoid using Fedora whenever possible, so please rename
README.Fedora to something more neutral like README.Dist
cp should be cp -p to keep timestamp.
Also I suggest using
%{_mandir}/man8/%{name}.8*
to catch any kind of compression.
I am afraid that, if accepted, you'll need contact legal (through spot,
he is the contact) because of the crypto and export stuff.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=465372
--- Comment #2 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-10 20:04:41 EDT
---
> I can't see why you don't use the initial Makefile.
The initial Makefile seemed horribly broken enough to warrant replacement (-m32
among other things!). If it builds using correct Fedora flags with make like
you suggest I don't see any problem using the original Makefile though.
> openssl in requires is not useful, it is automatically found by rpm.
Ok.
> It is better to avoid using Fedora whenever possible, so please rename
> README.Fedora to something more neutral like README.Dist
> cp should be cp -p to keep timestamp.
> Also I suggest using %{_mandir}/man8/%{name}.8* to catch any kind of
> compression.
Ok.
> I am afraid that, if accepted, you'll need contact legal (through spot,
> he is the contact) because of the crypto and export stuff.
I'll contact him.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #3 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-10 20:15:43 EDT --- New URLs: Spec: http://konradm.fedorapeople.org/fedora/SPECS/chntpw.spec SRPM: http://konradm.fedorapeople.org/fedora/SRPMS/chntpw-0.99.6-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Conrad Meyer <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||182235 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #4 from Patrice Dumas <[EMAIL PROTECTED]> 2008-10-11 04:52:03 EDT --- The files cannot be found? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #8 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-11 05:39:25 EDT --- New URLs: Spec: http://konradm.fedorapeople.org/fedora/SPECS/chntpw.spec SRPM: http://konradm.fedorapeople.org/fedora/SRPMS/chntpw-0.99.6-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #9 from Patrice Dumas <[EMAIL PROTECTED]> 2008-10-11 06:12:37 EDT --- rpmlint says: chntpw.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/chntpw-0.99.6/WinReg.txt I think that this should be fixed. Otherwise everything seems ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #6 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-11 05:00:33 EDT --- Try it again now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #5 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-11 04:58:01 EDT --- Interesting. skvidal moved fedorapeople to a different machine earlier today, perhaps that had something to do with it. I'll try to upload them again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #7 from Patrice Dumas <[EMAIL PROTECTED]> 2008-10-11 05:29:05 EDT --- I'd prefer if the chntpw-README.Fedora was also renamed. The main aim of not having 'Fedora' is to be reused, so it shouldn't be anywhere: https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks The -p for keeping timestamps is notfor newly created executables, since their timestamp is the one of the build anyway, but for the files that may have their timestamps kept, here the man page and README file. Just a suggestion, staticaly compiled executable should be kept, they don't do harm (and could even be used in-source), even though they are not of use in fedora. I also suggest a comment in the spec file telling where the version comes from since the source archive has another version string. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #10 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-12 00:47:12 EDT --- New URLs: Spec: http://konradm.fedorapeople.org/fedora/SPECS/chntpw.spec SRPM: http://konradm.fedorapeople.org/fedora/SRPMS/chntpw-0.99.6-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Patrice Dumas <[EMAIL PROTECTED]> changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Comment #11 from Patrice Dumas <[EMAIL PROTECTED]> 2008-10-12 05:32:51 EDT --- * rpmlint is silent * follow guidelines * free software, license included * match upstream: 09addfe7ae469677da39ed66d83858d3 chntpw-source-080526.zip * %files section right Just one suggestion, I think it is better to use sed for the end of line, and to keep timestamp, like: sed -e 's/\r$//' WinReg.txt > WinReg.txt.eol touch -c -r WinReg.txt WinReg.txt.eol mv WinReg.txt.eol WinReg.txt This is only asuggestion, so APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Conrad Meyer <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-12 05:49:04 EDT --- Your suggestions are greatly appreciated. Thanks much for the review! New Package CVS Request === Package Name: chntpw Short Description: Change passwords in Windows SAM files Owners: konradm Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Kevin Fenzi <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Kevin Fenzi <[EMAIL PROTECTED]> 2008-10-12 21:53:11 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 Conrad Meyer <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #14 from Conrad Meyer <[EMAIL PROTECTED]> 2008-10-13 01:09:24 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=876482 <-- In rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
