[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #3 from Jussi Lehtola 2009-05-15 07:09:13 EDT --- Some cleanups. http://theory.physics.helsinki.fi/~jzlehtol/rpms/firehol.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/firehol-1.273-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #4 from Jussi Lehtola 2009-05-15 07:22:33 EDT --- rpmlint output: firehol.noarch: E: non-readable /etc/firehol/firehol.conf 0640 firehol.noarch: E: subsys-not-used /etc/rc.d/init.d/firehol 2 packages and 0 specfiles checked; 2 errors, 0 warnings. These can both be ignored, since 1. the firewall config is not supposed to be read by other than root and 2. there service that sticks around is iptables; FireHOL doesn't have anything of itself to monitor with a subsys. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Stefan Schulze Frielinghaus changed: What|Removed |Added CC||ste...@seekline.net --- Comment #5 from Stefan Schulze Frielinghaus 2009-09-19 16:29:18 EDT --- I had a look over the package and everything seems to be OK. All must-items of the ReviewGuidelines checked. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #6 from Jussi Lehtola 2009-09-19 16:53:49 EDT --- (In reply to comment #5) > I had a look over the package and everything seems to be OK. All must-items of > the ReviewGuidelines checked. Then maybe you'd be willing to perform the review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Stefan Schulze Frielinghaus changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #7 from Stefan Schulze Frielinghaus 2009-09-20 05:33:03 EDT --- (In reply to comment #6) > Then maybe you'd be willing to perform the review? Done. Since I'm not a sponsor you still need to seek one. Maybe you should review other packages too. Did you create other packages? You could even send a mail to fedora-devel describing your package and what you have done etc. The more you tell about you and your package the earlier you will find a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #8 from Jussi Lehtola 2009-09-20 05:45:22 EDT --- (In reply to comment #7) > (In reply to comment #6) > > Then maybe you'd be willing to perform the review? > > Done. Since I'm not a sponsor you still need to seek one. Maybe you should > review other packages too. Did you create other packages? You could even send > a > mail to fedora-devel describing your package and what you have done etc. > > The more you tell about you and your package the earlier you will find a > sponsor. Is this a joke? :D I'm a sponsor myself, with 136 reviews. Most of the review bugs are by people who have been sponsored long ago and have packaging rights. Only the ones marked with FE-NEEDSPONSOR need sponsors to (formally) review them. I see you have acquired sponsoree status just five days ago, and you clearly have not understood yet completely how the package review process works. ** You really should go through the review checklist in the review bug (here). It's not just for me or you, it's also for other people who look at the reviews. A simple "Looks OK" is sloppy reviewing, since it's very likely you have forgot to check something. And it doesn't tell other people that you have really went through everything. Learn to walk before you run, OK? :) PS. Setting fedora-review to + is not enough, since anyone can remove or write over the flag. When you a package passes the review, write APPROVED in the comment field. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #9 from Stefan Schulze Frielinghaus 2009-09-20 07:11:28 EDT --- (In reply to comment #8) > I see you have acquired sponsoree status just five days ago, and you clearly > have not understood yet completely how the package review process works. Quite right. The Fedora bureaucracy is still new to me. But hey weren't we all once small? Calm down big boy. > You really should go through the review checklist in the review bug (here). > It's not just for me or you, it's also for other people who look at the > reviews. A simple "Looks OK" is sloppy reviewing, since it's very likely you > have forgot to check something. And it doesn't tell other people that you have > really went through everything. Like I already said in comment #5. I went through _all_ must (and should) items of https://fedoraproject.org/wiki/Packaging/ReviewGuidelines. And I did all steps of https://fedoraproject.org/wiki/Package_Review_Process which does not state that a comment like "APPROVED" should be written. > Learn to walk before you run, OK? :) Learning by doing. A wise man said this once before :) > PS. Setting fedora-review to + is not enough, since anyone can remove or write > over the flag. When you a package passes the review, write APPROVED in the > comment field. At least this one is a constructive comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #10 from Michael Schwendt 2009-09-20 09:57:18 EDT --- > Calm down big boy. I second that. > > A simple "Looks OK" is sloppy reviewing, Not at all. This point is entirely moot. Whether it's a very brief "Looks OK" or "APPROVED" or a huge list of MUST/SHOULD/OK/NOTOK/FAIL/BLAH items that copies the entire ReviewGuidelines Wiki page, it doesn't matter. All that matters is whether a reviewer has checked the package actually. The reviewer takes responsibility for serious mistakes. But don't forget that there are two people. The packager is the second one, who ought to review the package, too. ;) > # Don't start the firewall automatically > sed -i -e 's,# chkconfig: 2345 99 92,# chkconfig: - 20 80,' firehol.sh That's sloppy. sed -i is worse than a clean patch file. If the source file changes, your sed transformation no longer applies. Silently. On the contrary, a patch would fail and terminate the build. Adding a guard after the sed transformation is highly recommended. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Till Maas changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|ste...@seekline.net --- Comment #11 from Till Maas 2009-09-20 10:21:39 EDT --- (In reply to comment #9) > of https://fedoraproject.org/wiki/Packaging/ReviewGuidelines. And I did all > steps of https://fedoraproject.org/wiki/Package_Review_Process which does not > state that a comment like "APPROVED" should be written. It might be not emphasized enough, but you also need to assign the bug to you (the Assigned To field). I just did this for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Jussi Lehtola changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #12 from Jussi Lehtola 2009-09-20 11:05:13 EDT --- (In reply to comment #10) > > # Don't start the firewall automatically > > sed -i -e 's,# chkconfig: 2345 99 92,# chkconfig: - 20 80,' firehol.sh > > That's sloppy. sed -i is worse than a clean patch file. If the source file > changes, your sed transformation no longer applies. Silently. On the contrary, > a patch would fail and terminate the build. Adding a guard after the sed > transformation is highly recommended. True, didn't come to think of that when I packaged this a year ago when I was a newcomer in Fedora. (In reply to comment #11) > (In reply to comment #9) > > > of https://fedoraproject.org/wiki/Packaging/ReviewGuidelines. And I did all > > steps of https://fedoraproject.org/wiki/Package_Review_Process which does > > not > > state that a comment like "APPROVED" should be written. > > It might be not emphasized enough, but you also need to assign the bug to you > (the Assigned To field). I just did this for you. ... and change the status to ASSIGNED, which I just did. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Jussi Lehtola changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Jussi Lehtola 2009-09-22 09:46:13 EDT --- Well, thanks for the review, it had been waiting for a long time! Sorry if I sounded harsh, I did not mean to discourage you; I was just a bit surprised about your comments about sponsorship. I've fixed the sed issue. http://theory.physics.helsinki.fi/~jzlehtol/rpms/firehol.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/firehol-1.273-5.fc11.src.rpm New Package CVS Request === Package Name: firehol Short Description: A powerful yet easy to use iptables frontend Owners: jussilehtola Branches: F-10 F-11 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=465636
--- Comment #14 from Stefan Schulze Frielinghaus
2009-09-22 12:26:55 EDT ---
(In reply to comment #13)
> Well, thanks for the review, it had been waiting for a long time!
That was one of my reasons to choose this request.
> Sorry if I sounded harsh, I did not mean to discourage you; I was just a bit
> surprised about your comments about sponsorship.
No problem. Actually this is my first review and a funny story together ;-) I
started "5 days" ago and everybody told me to tell as much as possible about
myself and my package to find and convince a sponsor/reviewer. I just wanted to
give this tip/hind on because this request was waiting quite long.
Now to the real interesting stuff: review of firehol-1.273-5.fc11.src.rpm
(sha256sum 4ee2dd849a38948fc9c2ed8463089628429b9e81423633892b2b88e77ffdd61e)
[ OK ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint SPECS/firehol.spec SRPMS/firehol-1.273-5.fc11.src.rpm
RPMS/noarch/firehol-1.273-5.fc11.noarch.rpm
firehol.noarch: E: non-readable /etc/firehol/firehol.conf 0640
firehol.noarch: E: subsys-not-used /etc/rc.d/init.d/firehol
2 packages and 1 specfiles checked; 2 errors, 0 warnings.
Actually firehol uses /var/lock/subsys where it touches "firehol" and
"iptables" when it starts. I guess rpmlint does not recognize that because it
is hidden in the bash script. A grep after "FIREHOL_LOCK_DIR" in
/etc/init.d/firehol explains this.
[ OK ] MUST: The package must be named according to the Package Naming
Guidelines .
[ OK ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ OK ] MUST: The package must meet the Packaging Guidelines .
[ OK ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[ OK ] MUST: The License field in the package spec file must match the actual
license.
[ OK ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ OK ] MUST: The spec file must be written in American English.
[ OK ] MUST: The spec file for the package MUST be legible.
[ OK ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
sha256sum:
e8d3b4ac3e54097c0e0f14bfab773a75d43b522fa123a42088b7f23f13495ea2
Download/firehol-1.273.tar.bz2
e8d3b4ac3e54097c0e0f14bfab773a75d43b522fa123a42088b7f23f13495ea2
SOURCES/firehol-1.273.tar.bz2
[ OK ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ OK ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Not relevant, since noarch.
[ OK ] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
No "BuildRequires" available. Only "Requires" which are OK.
[ OK ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK because no locales available.
[ OK ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK because only shell scripts get installed.
[ OK ] MUST: Packages must NOT bundle copies of system libraries.
[ OK ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
OK because only shell scripts are used.
[ OK ] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
$ rpmls RPMS/noarch/firehol-1.273-5.fc11.noarch.rpm | grep ^d
drwxr-xr-x /etc/firehol
drwxr-xr-x /etc/firehol/services
drwxr-xr-x /usr/libexec/firehol
drwxr-xr-x /usr/share/doc/firehol-1.273
drwxr-xr-x /usr/share/doc/firehol-1.273/doc
drwxr-xr-x /usr/share/doc/firehol
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #15 from Kevin Fenzi 2009-09-22 12:38:41 EDT --- Stefan: Whats your Fedora Account system name? I can't seem to find you by your email address used here. You must be in the packager group to approve package reviews. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #16 from Jussi Lehtola 2009-09-22 12:45:45 EDT --- https://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions "condrestart (and try-restart): restart the service if the service is already running, if not, do nothing" So everything should be OK. (I must confess, I haven't checked those myself.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #17 from Michael Schwendt 2009-09-22 12:55:24 EDT --- @Stefan : when checking for unowned directories, don't use "grep ^d". It's insufficient @Kevin : account name is "stefansf" @Jussi : then a "service firehol stop ; service firehol condrestart" should not start the service, but according to comment 14 it does -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #18 from Jussi Lehtola 2009-09-22 13:18:08 EDT --- (In reply to comment #17) > @Jussi : then a "service firehol stop ; service firehol condrestart" should > not > start the service, but according to comment 14 it does Ugh. I really should not work this tired. I sent an email to the author, I don't have time now to debug the issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #19 from Stefan Schulze Frielinghaus 2009-09-22 13:41:45 EDT --- (In reply to comment #17) > @Stefan : when checking for unowned directories, don't use "grep ^d". It's > insufficient Jep you're right. I just posted the grep output to minimize it and to assure that I really did it. Maybe it would be more appropriate to paste the full output of rpmls: $ rpmls RPMS/noarch/firehol-1.273-5.fc11.noarch.rpm drwxr-xr-x /etc/firehol -rw-r- /etc/firehol/firehol.conf drwxr-xr-x /etc/firehol/services -rwxr-xr-x /etc/rc.d/init.d/firehol drwxr-xr-x /usr/libexec/firehol -rwxr-xr-x /usr/libexec/firehol/adblock.sh -rwxr-xr-x /usr/libexec/firehol/buildrpm.sh -rwxr-xr-x /usr/libexec/firehol/firehol.sh -rwxr-xr-x /usr/libexec/firehol/get-iana.sh drwxr-xr-x /usr/share/doc/firehol-1.273 -rw-r--r-- /usr/share/doc/firehol-1.273/COPYING -rw-r--r-- /usr/share/doc/firehol-1.273/ChangeLog -rw-r--r-- /usr/share/doc/firehol-1.273/README -rw-r--r-- /usr/share/doc/firehol-1.273/TODO -rw-r--r-- /usr/share/doc/firehol-1.273/WhatIsNew drwxr-xr-x /usr/share/doc/firehol-1.273/doc -rw-r--r-- /usr/share/doc/firehol-1.273/doc/adding.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/commands.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/css.css -rw-r--r-- /usr/share/doc/firehol-1.273/doc/faq.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/fwtest.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/header.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/index.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/invoking.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/language.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/overview.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/search.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/services.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/support.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/trouble.html -rw-r--r-- /usr/share/doc/firehol-1.273/doc/tutorial.html drwxr-xr-x /usr/share/doc/firehol-1.273/examples -rw-r--r-- /usr/share/doc/firehol-1.273/examples/client-all.conf -rw-r--r-- /usr/share/doc/firehol-1.273/examples/home-adsl.conf -rw-r--r-- /usr/share/doc/firehol-1.273/examples/home-dialup.conf -rw-r--r-- /usr/share/doc/firehol-1.273/examples/lan-gateway.conf -rw-r--r-- /usr/share/doc/firehol-1.273/examples/office.conf -rw-r--r-- /usr/share/doc/firehol-1.273/examples/server-dmz.conf -rw-r--r-- /usr/share/man/man1/firehol.1.gz -rw-r--r-- /usr/share/man/man5/firehol.conf.5.gz drwxr-xr-x /var/spool/firehol I checked every file + directory and its permissions. Looks good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #20 from Kevin Fenzi 2009-09-24 00:33:19 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #22 from Fedora Update System 2009-09-24 03:37:20 EDT --- firehol-1.273-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/firehol-1.273-5.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #21 from Fedora Update System 2009-09-24 03:36:42 EDT --- firehol-1.273-5.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/firehol-1.273-5.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #23 from Fedora Update System 2009-09-24 03:37:54 EDT --- firehol-1.273-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/firehol-1.273-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #24 from Fedora Update System 2009-09-24 03:38:28 EDT --- firehol-1.273-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/firehol-1.273-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #25 from Fedora Update System 2009-09-25 16:08:11 EDT --- firehol-1.273-5.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.273-5.fc10 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Fedora Update System changed: What|Removed |Added Fixed In Version|1.273-5.fc10|1.273-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #26 from Fedora Update System 2009-09-25 16:15:25 EDT --- firehol-1.273-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #27 from Fedora Update System 2009-10-16 15:31:07 EDT --- firehol-1.273-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Fedora Update System changed: What|Removed |Added Fixed In Version|1.273-5.fc11|1.273-5.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #28 from Fedora Update System 2009-10-16 15:36:05 EDT --- firehol-1.273-5.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 Fedora Update System changed: What|Removed |Added Fixed In Version|1.273-5.el5 |1.273-5.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #2 from Jussi Lehtola <[EMAIL PROTECTED]> 2008-10-15 01:45:21 EDT --- Fixes: - Use _initrddir. - pre and post fixes. - Disable automatical startup. http://theory.physics.helsinki.fi/~jzlehtol/rpms/firehol.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/firehol-1.273-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #1 from Jussi Lehtola <[EMAIL PROTECTED]> 2008-10-04 19:04:16 EDT --- rpmlint output: firehol.noarch: W: service-default-enabled /etc/init.d/firehol firehol.noarch: E: subsys-not-used /etc/init.d/firehol 1 packages and 1 specfiles checked; 1 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
