[Bug 465646] Review Request: hachoir-core - Hachoir core parser

2008-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465646


Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #1 from Orcan 'oget' Ogetbil <[EMAIL PROTECTED]>  2008-11-22 
14:21:15 EDT ---
I reviewed this package. Here are my notes :

* The package must obey python modules naming guidelines: Please see:
  
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29
And the spec file will need to be renamed accordingly.

* Latest version is not packaged. Please update to the latest version.

* You should probably make a %check section and run the tests given in the
test_doc.py

* There is a doc directory in the tarball. Should (at least, some of) the
contents of that directory be packaged?

* You must have BuildRequires: python-setuptools-devel
Please see:
   http://fedoraproject.org/wiki/Packaging/Python/Eggs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 465646] Review Request: hachoir-core - Hachoir core parser

2008-12-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465646


Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
  Alias||hachoir-core
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 465646] Review Request: hachoir-core - Hachoir core parser

2008-12-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465646





--- Comment #2 from Jean-François Martin <[EMAIL PROTECTED]>  2008-12-02 
22:57:39 EDT ---
Spec URL: http://lokthare.fedorapeople.org/temp/python-hachoir-core.spec
SRPM URL:
http://lokthare.fedorapeople.org/temp/python-hachoir-core-1.2-1.fc9.src.rpm

- Update to new release
- Rename the package to match naming guidelines for python modules
- Add some files to the doc
- Run test

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 465646] Review Request: hachoir-core - Hachoir core parser

2008-10-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465646


Jean-François Martin <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Blocks||465649




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review