[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465710 Terje Røsten [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #6 from Terje Røsten [EMAIL PROTECTED] 2008-10-18 07:03:48 EDT --- Things is in shape again, imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465710 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi [EMAIL PROTECTED] 2008-10-07 13:46:43 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465710 --- Comment #5 from Terje Røsten [EMAIL PROTECTED] 2008-10-07 14:13:39 EDT --- I can't build, make build ends with: 867022 build (dist-f10, devel:perl-qooxdoo-compat-0_7_3-2_fc10): open (x86-3.fedora.phx.redhat.com) - FAILED: BuildError: package perl-qooxdoo-compat not in list for tag dist-f10 If I try: (setting f11 by hand) /usr/bin/koji build dist-f11 'cvs://cvs.fedoraproject.org/cvs/pkgs?rpms/perl-qooxdoo-compat/devel#perl-qooxdoo-compat-0_7_3-2_fc10 I get: 867037 build (dist-f11, devel:perl-qooxdoo-compat-0_7_3-2_fc10): open (x86-7.fedora.phx.redhat.com) - FAILED: GenericError: Unable to complete build: release mismatch (build: 2.fc10, rpm: 2.fc11) Can't pacakges be imported when we are in some kind of freeze or is this a bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=465710
Ralf Corsepius [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Ralf Corsepius [EMAIL PROTECTED] 2008-10-06 03:57:15 EDT
---
This is wrong:
%files
...
%{perl_vendorlib}/Qooxdoo/JSONRPC.pm
The package must own %{perl_vendorlib}/Qooxdoo.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=465710
manuel wolfshant [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review+
--- Comment #2 from manuel wolfshant [EMAIL PROTECTED] 2008-10-06 06:34:15
EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM:
perl-qooxdoo-compat.src: E: unknown-key GPG#7666df64
- ignorable
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Pac
kaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: LGPLv2 or EPL
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] Spec file is legible and written in American English.
[!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
2ab0cc8b437e09fbba1b9ccef064c826eaf06b8d qooxdoo-0.7.3-backend.zip
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines
.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[!] Package must own all directories that it creates.
See issue 1
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64
[?] Package should compile and build into binary rpms on all supported
architectures.
Not tested on anything but devel.x86_64, but it is a standard noarch perl
module, should build everywhere
[?] Package functions as described.
Not yet tested, I have to rebuild smokeping. but since it's basically the same
module as before, there should be no surprises
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
ISSUES
1. The module is stored as /usr/lib/perl5/vendor_perl/5.10.0/Qooxdoo/JSONRPC.pm
but the folder itself is not owned. Thanks Ralf for the second set of eyes.
Please fix the above before commiting to CVS.
Package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465710 Terje Røsten [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Terje Røsten [EMAIL PROTECTED] 2008-10-06 11:12:10 EDT --- Thanks wolfy and Ralf! Updated package - Fix ownership of dir spec: n/a, seems like sshd @ fedorapeople.org is down srpm: http://koji.fedoraproject.org/koji/getfile?taskID=863922name=perl-qooxdoo-compat-0.7.3-2.fc10.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=863921 New Package CVS Request === Package Name: perl-qooxdoo-compat Short Description: Perl backend for Qooxdoo Owners: terjeros Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465710] Review Request: perl-qooxdoo-compat - Perl backend for Qooxdoo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465710 Terje Røsten [EMAIL PROTECTED] changed: What|Removed |Added Blocks||441378 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
