[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 --- Comment #10 from Fedora Update System 2009-01-16 18:43:38 EDT --- mingw32-libpng-1.2.34-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 --- Comment #9 from Fedora Update System 2009-01-15 04:33:34 EDT --- mingw32-libpng-1.2.34-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-libpng-1.2.34-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 --- Comment #8 from Richard W.M. Jones 2009-01-14 05:11:29 EDT --- Thanks everyone. I've built this for EL-5 and Rawhide, but cannot yet build it for F-10 because I'm waiting for the mingw32-zlib dependency to work its way into dist-f10-updates. I'll leave the bug open until then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi 2009-01-13 15:32:21 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Richard W.M. Jones changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Richard W.M. Jones 2009-01-13 09:49:11 EDT --- New Package CVS Request === Package Name: mingw32-libpng Short Description: MinGW Windows Libpng library Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Adam Tkac changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Adam Tkac 2009-01-13 09:33:32 EDT --- (In reply to comment #4) > I should add about the 'spurious-executable-perm' warning: > libtool / gcc add executable permissions when they generate > these files. In other words, this is not something that we > are adding, but something that the tools are doing. > > It has to be said that we don't really understand why the > tools do this, but at the same time we are loathed to change > any details of the linking process since at the moment it works, > but in the past it has proven quite fragile in that seemingly > insignificant changes have broken things. Well, I don't see any reason to have *dll.a files with executable perms but if it is created automatically leave it as is. Review: source files match upstream: YES package meets naming and versioning guidelines: YES specfile is properly named, is cleanly written and uses macros consistently: YES dist tag is present: YES build root is correct: YES license field matches the actual license: YES license is open source-compatible: YES latest version is being packaged: YES BuildRequires are proper: YES compiler flags are appropriate: YES %clean is present: YES package builds in mock (Rawhide/x86_64): YES rpmlint is silent: no, but warnings/errors are ok for mingw* package final provides and requires look sane: YES owns the directories it creates: YES doesn't own any directories it shouldn't: YES no duplicates in %files: YES file permissions are appropriate: well, as written in comment #4 it's ok code, not content: YES => reviewed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 --- Comment #4 from Richard W.M. Jones 2009-01-13 05:40:47 EDT --- I should add about the 'spurious-executable-perm' warning: libtool / gcc add executable permissions when they generate these files. In other words, this is not something that we are adding, but something that the tools are doing. It has to be said that we don't really understand why the tools do this, but at the same time we are loathed to change any details of the linking process since at the moment it works, but in the past it has proven quite fragile in that seemingly insignificant changes have broken things. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 --- Comment #3 from Richard W.M. Jones 2009-01-13 05:37:44 EDT --- We do install *.la files for mingw32 packages because they are needed for libtool to link. This is mentioned in the packaging guidelines: http://fedoraproject.org/wiki/Packaging/MinGW#Libraries_.28DLLs.29 Here's an updated package: Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libpng/mingw32-libpng.spec SRPM URL: http://koji.fedoraproject.org/koji/getfile?taskID=1049093&name=mingw32-libpng-1.2.34-1.fc11.src.rpm * Tue Jan 13 2009 Richard W.M. Jones - 1.2.34-1 - Rebase to 1.2.34 and patches from Fedora. - Requires pkgconfig. - Add documentation. Here is a Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1049092 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Adam Tkac changed: What|Removed |Added Status|NEW |ASSIGNED CC||at...@redhat.com AssignedTo|nob...@fedoraproject.org|at...@redhat.com Flag||fedora-review? --- Comment #2 from Adam Tkac 2009-01-12 08:05:49 EDT --- I will review this package. current problems: - the latest version is not packaged (there is 1.2.34 in rawhide) rpmlint errors: mingw32-libpng.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libpng12.dll.a mingw32-libpng.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libpng.dll.a mingw32-libpng.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/lib/libpng12.la ^^^ I don't think we need libtool *la files installed, do we? Otherwise I don't see any other problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Bug 467397 depends on bug 454416, which changed state. Bug 454416 Summary: Review Request: mingw32-zlib - MinGW Windows zlib compression library https://bugzilla.redhat.com/show_bug.cgi?id=454416 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 --- Comment #1 from Richard W.M. Jones <[EMAIL PROTECTED]> 2008-12-10 11:31:35 EDT --- Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libpng/mingw32-libpng.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-libpng-1.2.31-5.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Bug 467397 depends on bug 454410, which changed state. Bug 454410 Summary: Review Request: mingw32-gcc - MinGW Windows cross-compiler (GCC) for C and C++ https://bugzilla.redhat.com/show_bug.cgi?id=454410 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||467420 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||467416 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||467401 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467397] Review Request: mingw32-libpng - MinGW Windows Libpng library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467397 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Depends on||454410, 454416 Alias||mingw32-libpng -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
