[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Bug 467407 depends on bug 467388, which changed state. Bug 467388 Summary: Review Request: mingw32-pdcurses - Curses library for MinGW https://bugzilla.redhat.com/show_bug.cgi?id=467388 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Bug 467407 depends on bug 467399, which changed state. Bug 467399 Summary: Review Request: mingw32-readline - MinGW port of readline for editing typed command lines https://bugzilla.redhat.com/show_bug.cgi?id=467399 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED --- Comment #10 from Fedora Update System 2009-01-21 16:36:29 EDT --- mingw32-sqlite-3.6.6.2-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 --- Comment #9 from Fedora Update System 2009-01-21 05:53:29 EDT --- mingw32-sqlite-3.6.6.2-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-sqlite-3.6.6.2-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 --- Comment #8 from Richard W.M. Jones 2008-12-21 06:28:42 EDT --- Thanks Erik and Kevin for this. I've done the import, but I won't be able to build it until the two dependencies get imported. So I'll leave this bug open for the time being. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi 2008-12-20 23:06:39 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Richard W.M. Jones changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Richard W.M. Jones 2008-12-18 05:34:43 EDT --- New Package CVS Request === Package Name: mingw32-sqlite Short Description: MinGW Windows port of sqlite embeddable SQL database engine Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 --- Comment #5 from Richard W.M. Jones 2008-12-18 05:33:05 EDT --- Thanks for looking at this. These are the bugs related to the rpmlint issue: https://bugzilla.redhat.com/buglist.cgi?query_format=advanced&product=Fedora&component=rpmlint&long_desc_type=substring&long_desc=mingw&bug_status=NEW&bug_status=ASSIGNED&bug_status=MODIFIED&bug_status=ON_DEV&bug_status=ON_QA&bug_status=VERIFIED&bug_status=FAILS_QA&bug_status=RELEASE_PENDING&bug_status=POST&bug_status=CLOSED We're waiting for rpmlint upstream to add a feature which will allow us to mask off certain bugs for certain groups of packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Erik van Pienbroek changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Erik van Pienbroek 2008-12-17 17:50:21 EDT --- Too bad upstream rpmlint refuses to accept patches for MinGW support. Maybe it is an idea to create a list of rpmlint failures which can be ignored for MinGW and put it on the MinGW guidelines page? Anyway, this package looks good enough for inclusion in Fedora: The package mingw32-sqlite is APPROVED by epienbro -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Richard W.M. Jones changed: What|Removed |Added Flag|needinfo?(rjo...@redhat.com | |) | --- Comment #3 from Richard W.M. Jones 2008-12-16 11:03:54 EDT --- rpmlint isn't hugely useful for mingw packages at the moment. Upstream rpmlint refused to make changes to accomodate the packaging guidelines, but hopefully we can add some custom rules at some point in the future. The updated package here now has the following rpmlint warnings: mingw32-sqlite.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/sqlite3.pc mingw32-sqlite.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sqlite3.h mingw32-sqlite.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sqlite3ext.h mingw32-sqlite.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a These are fine. All mingw packages are development packages, so there is no -devel subpackage. mingw32-sqlite.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.la Note that we currently include *.la files in mingw packages, because libtool (probably) requires them for linking. mingw32-sqlite.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a This is OK because the file in question contains Windows binary stubs - ie. arch-independent from the p.o.v. of Fedora. mingw32-sqlite.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 And again, this is OK, mandated by GCC and the packaging guidelines. I've fixed the spurious executable permission, and added 'Requires: pkgconfig' which is needed. Spec URL: http://www.annexia.org/tmp/mingw32-sqlite.spec SRPM URL: http://www.annexia.org/tmp/mingw32-sqlite-3.6.6.2-1.fc10.src.rpm * Tue Dec 16 2008 Richard Jones - 3.6.6.2-1 - New upstream release (to match Fedora native), 3.6.6.2. - Replace patches with ones from native. - Rebase -no-undefined patch. - Remove spurious +x permissions on libsqlite3.dll.a. - Requires pkgconfig. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||needinfo?([EMAIL PROTECTED] ||) --- Comment #2 from Richard W.M. Jones <[EMAIL PROTECTED]> 2008-12-09 17:29:42 EDT --- Thanks for taking a look at this. I'm going to come back to this when I've finished getting the base packages bootstrapped in F-10 and F-11 (https://fedorahosted.org/rel-eng/ticket/1103). In the meantime, setting NEEDINFO of me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Bug 467407 depends on bug 454410, which changed state. Bug 454410 Summary: Review Request: mingw32-gcc - MinGW Windows cross-compiler (GCC) for C and C++ https://bugzilla.redhat.com/show_bug.cgi?id=454410 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467407
Erik van Pienbroek <[EMAIL PROTECTED]> changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||[EMAIL PROTECTED]
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?
--- Comment #1 from Erik van Pienbroek <[EMAIL PROTECTED]> 2008-12-03 07:09:49
EDT ---
Okay, here goes
$ rpmlint mingw32-sqlite.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw32-sqlite-3.5.9-3.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw32-sqlite-3.5.9-3.fc10.noarch.rpm
mingw32-sqlite.noarch: W: no-documentation
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/sqlite3.pc
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/sqlite3.h
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/sqlite3ext.h
mingw32-sqlite.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a
mingw32-sqlite.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a
mingw32-sqlite.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.la
mingw32-sqlite.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsqlite3.dll.a
mingw32-sqlite.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
1 packages and 0 specfiles checked; 2 errors, 7 warnings.
$ rpmquery --requires mingw32-sqlite
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-filesystem >= 39
mingw32-runtime
mingw32(kernel32.dll)
mingw32(libsqlite3-0.dll)
mingw32(msvcrt.dll)
$ md5sum sqlite-3.5.9.tar.gz
b58412904b42fe49e5a281e99da0fd72 sqlite-3.5.9.tar.gz
$ curl http://sqlite.org/sqlite-3.5.9.tar.gz | md5sum
% Total% Received % Xferd Average Speed TimeTime Time Current
Dload Upload Total SpentLeft Speed
100 2149k 100 2149k0 0 692k 0 0:00:03 0:00:03 --:--:-- 776k
b58412904b42fe49e5a281e99da0fd72 -
+ OK
- Needs to be looked into
/ Not applicable
? Unsure
* Overridden by MinGW guidelines
[+] Files are installed in /usr/i686-pc-mingw32/sys-root/mingw
[+] BuildRequires: mingw32-filesystem >= xx is in the .spec file
[+] Requires are OK
[+] BuildArch: noarch
[+] No man pages or info files
[+] No static libs
[+] default strip and objdump commands are overridden with mingw32 specific
ones
[-] rpmlint must be run on every package. The output should be posted in the
review.
[+] MUST: The package must be named according to the Package Naming Guidelines
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming
Guidelines
[+] MUST: The package must meet the Packaging Guidelines
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+] MUST: The License field in the package spec file must match the actual
license.
[?] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[/] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional.
[/] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[/] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[/] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
[/] MUST: A package must own all directories t
[Bug 467407] Review Request: mingw32-sqlite - MinGW Windows port of sqlite embeddable SQL database engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467407 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Depends on||454410, 467388, 467399 Alias||mingw32-sqlite -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
