[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE --- Comment #7 from Michel Alexandre Salim 2009-03-01 18:55:46 EDT --- Looks like this is already in Rawhide and F-10 stable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-02-08 16:50:48 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Richard W.M. Jones changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Richard W.M. Jones 2009-02-06 09:04:03 EDT --- New Package CVS Request === Package Name: mingw32-libgcrypt Short Description: MinGW Windows gcrypt encryption library Owners: rjones berrange Branches: F-10 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 --- Comment #4 from Richard W.M. Jones 2009-02-06 09:01:31 EDT --- Thanks for approving this. I have done an updated package which should fix everything you mentioned. I will proceed with the CVS request anyway. * Fri Feb 6 2009 Richard W.M. Jones - 1.4.4-1 - Update to Fedora native version 1.4.4: . Remove potentially patented ECC support. . Do not abort when the fips mode kernel flag is inaccessible due to permissions (#470219). - For review (Michel Alexandre Salim): . Remove *.def file. . Make description clearer. . Distribute the license files. - The license for binaries is GPLv2+, so update the license field. - Add check section (disabled by default). - Why did we set PATH before configure? Removed. - Added BR mingw32-dlfcn suggested by auto-buildrequires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467410
Michel Alexandre Salim changed:
What|Removed |Added
CC||michel.syl...@gmail.com
AssignedTo|nob...@fedoraproject.org|michel.syl...@gmail.com
Flag||fedora-review+
Bug 467410 depends on bug 467403, which changed state.
Bug 467403 Summary: Review Request: mingw32-libgpg-error - MinGW Windows GnuPGP
error library
https://bugzilla.redhat.com/show_bug.cgi?id=467403
What|Old Value |New Value
Status|ASSIGNED|CLOSED
Resolution||NEXTRELEASE
--- Comment #3 from Michel Alexandre Salim
2009-02-03 19:40:56 EDT ---
Notes:
- Fedora version has been updated to 1.4.4, with substantial patches. Should
the
mingw32 package be rebased first?
- Package description is a bit sparse. Should it be copied from Fedora's?
MUST
? rpmlint: source clean, binary has no-doc and script-without-shebang
This is not in the guideline -- do all *.def need to have +x
permissions?
+ package name
+ spec file name
+ package guideline-compliant
+ license complies with guidelines
+ license field accurate
- license file not deleted
+ spec in US English
+ spec legible
+ source matches upstream
+ builds under >= 1 archs, others excluded
+ build dependencies complete
N/A locales handled using %find_lang, no %{_datadir}/locale
? library -> ldconfig
N/A relocatable: give reason
+ own all directories
+ no dupes in %files
? permission -- see question above
+ %clean RPM_BUILD_ROOT
+ macros used consistently
+ Package contains code
N/A large docs => -doc
N/A doc not runtime dependent
N/A static in -static
N/A if contains *.pc, req pkgconfig
N/A desktop file uses desktop-file-install
+ clean buildroot before install
+ filenames UTF-8
SHOULD
+ package functioned as described
+ scriplets are sane
+ if main pkg is development-wise, pkgconfig can go in main package
+ require package not files
Approved
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 --- Comment #2 from Richard W.M. Jones 2009-01-25 08:21:46 EDT --- Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/libgcrypt/mingw32-libgcrypt.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-libgcrypt-1.4.3-3.fc11.src.rpm * Fri Jan 23 2009 Richard W.M. Jones - 1.4.3-3 - Use _smp_mflags. - Disable static libraries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 --- Comment #1 from Richard W.M. Jones <[EMAIL PROTECTED]> 2008-12-10 11:38:20 EDT --- Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libgcrypt/mingw32-libgcrypt.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-libgcrypt-1.4.3-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Bug 467410 depends on bug 454410, which changed state. Bug 454410 Summary: Review Request: mingw32-gcc - MinGW Windows cross-compiler (GCC) for C and C++ https://bugzilla.redhat.com/show_bug.cgi?id=454410 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||467418 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||467414 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467410] Review Request: mingw32-libgcrypt - MinGW Windows gcrypt encryption library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467410 Richard W.M. Jones <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Depends on||454410, 467403 Alias||mingw32-libgcrypt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
