[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #11 from Fedora Update System [EMAIL PROTECTED] 2008-11-26 21:08:48 EDT --- xlcrack-1.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #10 from Fedora Update System [EMAIL PROTECTED] 2008-11-22 11:59:11 EDT --- xlcrack-1.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #9 from Fedora Update System [EMAIL PROTECTED] 2008-11-22 11:59:09 EDT --- xlcrack-1.2-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xlcrack'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #8 from Fedora Update System [EMAIL PROTECTED] 2008-11-14 07:53:15 EDT --- xlcrack-1.2-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xlcrack'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9673 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi [EMAIL PROTECTED] 2008-11-12 13:49:10 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #6 from Fedora Update System [EMAIL PROTECTED] 2008-11-12 18:21:23 EDT --- xlcrack-1.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xlcrack-1.2-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #7 from Fedora Update System [EMAIL PROTECTED] 2008-11-12 18:21:26 EDT --- xlcrack-1.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/xlcrack-1.2-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-11 08:57:19 EDT --- It looks like a line was lost from my comment above, but unfortunately I can't remember what I might have written there. Oh, well. Anyway, this looks good to me. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #4 from Fabian Affolter [EMAIL PROTECTED] 2008-11-11 17:29:48 EDT --- New Package CVS Request === Package Name: xlcrack Short Description: Recover lost and forgotten passwords from XLS files Owners: fab Branches: F-9 F-10 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 --- Comment #2 from Fabian Affolter [EMAIL PROTECTED] 2008-11-10 14:44:35 EDT --- Thanks Jason for your review and your tip about the solving of the compiler flags issue. With your compiler flags the tool works fine as far as I can evaluate this. [EMAIL PROTECTED] test_excel]$ xlcrack test_excel_95_01.xls test_excel_95_01.xls: uses strong cryptography This tool only works on XOR cryptography (e.g. Excel 95) [EMAIL PROTECTED] test_excel]$ xlcrack test_excel_95_02.xls test_excel_95_02.xls: is not encrypted [EMAIL PROTECTED] test_excel]$ xlcrack test_excel_95_03.xls test_excel_95_03.xls: has no password, see documentation Update: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/xlcrack.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/xlcrack-1.2-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469494
Jason Tibbitts [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?
--- Comment #1 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-07 16:43:03 EDT
---
It doesn't get much simpler than this package. Unfortunately, there's one
issue: the package doesn't compile with the proper set of compiler flags.
Adding
sed -i -e 's/-g -Wall/%{optflags}/' Makefile
after the %setup call gets things building properly, but without a test
document I can't verify that it doesn't break anything. (I guess
* source files match upstream:
ad01be3262726d94774f519ffb920a925abe95c483d05105b596c372cc13dcf5
xlcrack-1.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
xlcrack = 1.2-1.fc10
xlcrack(x86-64) = 1.2-1.fc10
=
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgsf-1.so.114()(64bit)
libxml2.so.2()(64bit)
* %check is not present; no test suite upstream. I don't have an old excel
around to create a document I could use to test this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
