[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #18 from Fedora Update System [EMAIL PROTECTED] 2008-11-26 21:09:47 EDT --- cpuid-20060917-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #16 from Fedora Update System [EMAIL PROTECTED] 2008-11-22 11:47:00 EDT --- cpuid-20060917-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cpuid'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-9937 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #17 from Fedora Update System [EMAIL PROTECTED] 2008-11-22 11:51:44 EDT --- cpuid-20060917-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #14 from Dan Horák [EMAIL PROTECTED] 2008-11-21 12:57:31 EDT --- ping Didn't you forget to push the update to stable? New packages can go directly into stable and there is special type for such update (newpackage). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #15 from Fabian Affolter [EMAIL PROTECTED] 2008-11-21 16:13:51 EDT --- Yes, I did. Thanks for the hint. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #13 from Fedora Update System [EMAIL PROTECTED] 2008-11-11 21:52:49 EDT --- cpuid-20060917-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cpuid'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9534 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi [EMAIL PROTECTED] 2008-11-10 11:43:48 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #12 from Fedora Update System [EMAIL PROTECTED] 2008-11-10 14:19:37 EDT --- cpuid-20060917-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/cpuid-20060917-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #11 from Fedora Update System [EMAIL PROTECTED] 2008-11-10 14:19:34 EDT --- cpuid-20060917-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/cpuid-20060917-4.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469590
--- Comment #6 from Fabian Affolter [EMAIL PROTECTED] 2008-11-09 06:28:31
EDT ---
Thanks again
(In reply to comment #5)
(In reply to comment #4)
- $RPM_OPT_FLAGS are not used to compile, could be solved with
make %{?_smp_mflags} CFLAGS=$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64
-DVERSION=$(VERSION)
Hm, the VERSION is now undefined during the compile. But after reading the
Makefile, the proper solution would be to use -DVERSION=%{version} in the
CFLAGS. So, please, one more iteration is required, all other issues have
already been resolved.
New make:
make %{?_smp_mflags} CFLAGS=%{optflags} -D_FILE_OFFSET_BITS=64
-DVERSION=%{version}
Update:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/cpuid.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/cpuid-20060917-4.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469590
--- Comment #5 from Dan Horák [EMAIL PROTECTED] 2008-11-09 05:03:32 EDT ---
(In reply to comment #4)
- $RPM_OPT_FLAGS are not used to compile, could be solved with
make %{?_smp_mflags} CFLAGS=$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64
-DVERSION=$(VERSION)
Hm, the VERSION is now undefined during the compile. But after reading the
Makefile, the proper solution would be to use -DVERSION=%{version} in the
CFLAGS. So, please, one more iteration is required, all other issues have
already been resolved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Dan Horák [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Dan Horák [EMAIL PROTECTED] 2008-11-09 10:55:15 EDT --- All issues are fixed, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #8 from Fabian Affolter [EMAIL PROTECTED] 2008-11-09 11:04:22 EDT --- Thank you for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs+ --- Comment #9 from Fabian Affolter [EMAIL PROTECTED] 2008-11-09 11:05:02 EDT --- New Package CVS Request === Package Name: cpuid Short Description: Dumps information about the CPU(s) Owners: fab Branches: F-9 F-10 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469590
--- Comment #4 from Fabian Affolter [EMAIL PROTECTED] 2008-11-08 16:09:22
EDT ---
Thanks Dan for helping me to bring this package into Fedora.
(In reply to comment #3)
- license should be MIT instead of BSD
(http://fedoraproject.org/wiki/Licensing/MIT)
fixed
- $RPM_OPT_FLAGS are not used to compile, could be solved with
make %{?_smp_mflags} CFLAGS=$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64
-DVERSION=$(VERSION)
fixed
- rpmlint complains
cpuid.src:48: W: macro-in-%changelog doc = make it ... %%doc ...
fixed
Update:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/cpuid.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/cpuid-20060917-3.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469590
Dan Horák [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|[EMAIL PROTECTED]|
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?
--- Comment #3 from Dan Horák [EMAIL PROTECTED] 2008-11-06 11:12:01 EDT ---
formal review is here, see the notes below:
OK source files match upstream:
0aac0d5104e45421ce3c48f0fe2d924d0d13caf1 cpuid-20060917.src.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
BAD license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- license should be MIT instead of BSD
(http://fedoraproject.org/wiki/Licensing/MIT)
- $RPM_OPT_FLAGS are not used to compile, could be solved with
make %{?_smp_mflags} CFLAGS=$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64
-DVERSION=$(VERSION)
- rpmlint complains
cpuid.src:48: W: macro-in-%changelog doc = make it ... %%doc ...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Jon Stanley [EMAIL PROTECTED] changed: What|Removed |Added Keywords||FutureFeature -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #2 from Fabian Affolter [EMAIL PROTECTED] 2008-11-04 18:25:00 EDT --- (In reply to comment #1) few notes: - better will be to use ExclusiveArch i386 x86_64 instead of ExcludeArch, because it will not work on Sparc/S390/ARM/... fixed - the summary should reflect that it is useful only in x86 CPUs fixed - I see that last release was in 2006, how it works with recent CPUs? I can't test the tool with recent CPUs because I only own older hardware. - we already have x86info and 'cat /proc/cpuinfo' - no need to mark the man page as %doc, it is done automagically (http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-files-list-directives.html) fixed - install the non-gzipped man page (as cpuid.1), it is compressed automagically during rpm build fixed New Spec: http://fab.fedorapeople.org/packages/SRPMS/cpuid.spec New SRPM: http://fab.fedorapeople.org/packages/SRPMS/cpuid-20060917-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Dan Horák [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Dan Horák [EMAIL PROTECTED] 2008-11-03 04:42:57 EDT --- few notes: - better will be to use ExclusiveArch i386 x86_64 instead of ExcludeArch, because it will not work on Sparc/S390/ARM/... - the summary should reflect that it is useful only in x86 CPUs - I see that last release was in 2006, how it works with recent CPUs? - we already have x86info - no need to mark the man page as %doc, it is done automagically (http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-files-list-directives.html) - install the non-gzipped man page (as cpuid.1), it is compressed automagically during rpm build -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added Blocks||179260 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469590] Review Request: cpuid - Dumps information about the CPU(s)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added Blocks||238953 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
