[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi [EMAIL PROTECTED] 2008-11-22 23:30:42 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Marcela Maslanova [EMAIL PROTECTED] 2008-11-19 03:02:40 EDT --- New Package CVS Request === Package Name: perl-File-ShareDir-PAR Short Description: same functionality as File::ShareDir (compatible with PAR) Owners: mmaslano Branches: devel, F-10 InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 --- Comment #6 from Marcela Maslanova [EMAIL PROTECTED] 2008-11-18 10:08:41 EDT --- Please see new version http://mmaslano.fedorapeople.org/perl-File-ShareDir-PAR/perl-File-ShareDir-PAR-0.02-2.fc10.src.rpm http://mmaslano.fedorapeople.org/perl-File-ShareDir-PAR/perl-File-ShareDir-PAR.spec I apologize for wrong format. I was using what firefox offers in history :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Stepan Kasal [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Stepan Kasal [EMAIL PROTECTED] 2008-11-18 10:17:12 EDT --- The above changes has been incorporated, except the sed command patching File/ShareDir/PAR.pm, which really belongs upstream, not to the patch. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469673
--- Comment #4 from Stepan Kasal [EMAIL PROTECTED] 2008-11-07 10:36:28 EDT
---
OK source files match upstream:
sha256sum: 1f528cd3fe2086b14f2992c4525a5cd697fb53c7cc8505bf5adeb78793e40b18
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock.
OK package installs properly.
OK no debuginfo package
OK rpmlint is silent.
BAD final provides and requires are sane -- see below
OK %check is present and all tests pass:
t/01_compileok
t/02_without_parok
t/03_with_par...ok
All tests successful.
Files=3, Tests=60, 2 wallclock secs
Result: PASS
OK no shared libraries
OK owns the directories it creates.
BAD owns directories created by perl-File-ShareDir; please replace
%{perl_vendorlib}/*
with
%{perl_vendorlib}/File/ShareDir
%{perl_vendorlib}/auto/share/*/File-ShareDir-PAR
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers. no pkgconfig files. no libtool .la droppings.
OK no desktop files
There are three redundant manual requires:
Requires: perl(Class::Inspector) = 1.12
Requires: perl(File::ShareDir)
Requires: perl(Params::Util) = 0.07
But all there requires are also detected automatically.
To add the version requirements, I suggest to patch PAR.rpm this way:
sed -i
s/^use Params::Util *'/use Params::Util 0.07 '/
s/^use Class::Inspector *()/use Class::Inspector 1.12 ()/
lib/File/ShareDir/PAR.pm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Comment #5 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-07 10:58:10 EDT --- Please remember to set the fedora-review flag when you're reviewing a package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 --- Comment #2 from Stepan Kasal [EMAIL PROTECTED] 2008-11-06 09:22:08 EDT --- Jason, I suppose you mean https://bugzilla.redhat.com/enter_bug.cgi?product=Fedoraformat=extras-review right? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Stepan Kasal [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 --- Comment #3 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-06 09:37:14 EDT --- Yes, or simply use the same format. Isn't the goal to have the packages reviewed quickly? I can't imagine why someone would want to differ needlessly, since it only complicates things for any automated processes we might have and thus slows things down. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469673] Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469673 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added Summary|Package review: |Review request: |File::ShareDir::PAR - same |perl-File-ShareDir-PAR - |functionality as|same functionality as |File::ShareDir with PAR |File::ShareDir with PAR |support |support --- Comment #1 from Jason Tibbitts [EMAIL PROTECTED] 2008-11-03 11:18:29 EDT --- We have scripts that parse these review requests. I ask again: please use the template or at least use the same format as other review tickets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
