[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 Ruben Kerkhof [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #12 from Ruben Kerkhof [EMAIL PROTECTED] 2008-11-22 08:18:58 EDT --- Thanks for the review Jussi. Package build and imported into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 Ruben Kerkhof [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Ruben Kerkhof [EMAIL PROTECTED] 2008-11-18 17:02:36 EDT --- Thanks, I'll fix the above mentioned points before importing. New Package CVS Request === Package Name: Ajaxterm Short Description: A web-based terminal Owners: ruben Branches: F-8 F-9 EL-4 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi [EMAIL PROTECTED] 2008-11-18 20:45:56 EDT --- I assume you wanted a F-10 branch here as well? cvs done with F-10 added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470508
Jussi Lehtola [EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Jussi Lehtola [EMAIL PROTECTED] 2008-11-17 07:30:26 EDT
---
(In reply to comment #8)
Thanks, fixed both points.
New version:
Spec URL: http://ruben.fedorapeople.org/Ajaxterm.spec
SRPM URL: http://ruben.fedorapeople.org/Ajaxterm-0.10-4.fc9.src.rpm
Where do you set LANG=C (or unset LANG)? Ajaxterm only supports latin1.
Spec cleanup: Change
%dir %{_datadir}/ajaxterm
%{_datadir}/ajaxterm/*
to simply
%{_datadir}/ajaxterm
Source and license matches upstream.
The package is APPROVED.
Do the fixes mentioned above before importing to CVS.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 --- Comment #2 from Ruben Kerkhof [EMAIL PROTECTED] 2008-11-09 08:49:57 EDT --- Thanks, corrected. New version here: Spec URL: http://ruben.fedorapeople.org/Ajaxterm.spec SRPM URL: http://ruben.fedorapeople.org/Ajaxterm-0.10-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 --- Comment #3 from Jussi Lehtola [EMAIL PROTECTED] 2008-11-09 10:07:44 EDT --- And still, require the packages chkconfig and initscripts instead of /sbin/chkconfig and /sbin/service. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 --- Comment #4 from Ruben Kerkhof [EMAIL PROTECTED] 2008-11-09 14:20:47 EDT --- Why, I don't remember reading that in the packaging guidelines? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 --- Comment #6 from Ruben Kerkhof [EMAIL PROTECTED] 2008-11-09 14:46:37 EDT --- Ah, you're right. New version build: Spec URL: http://ruben.fedorapeople.org/Ajaxterm.spec SRPM URL: http://ruben.fedorapeople.org/Ajaxterm-0.10-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 Jussi Lehtola [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 --- Comment #8 from Ruben Kerkhof [EMAIL PROTECTED] 2008-11-09 16:20:06 EDT --- Thanks, fixed both points. New version: Spec URL: http://ruben.fedorapeople.org/Ajaxterm.spec SRPM URL: http://ruben.fedorapeople.org/Ajaxterm-0.10-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 --- Comment #5 from Jussi Lehtola [EMAIL PROTECTED] 2008-11-09 14:27:27 EDT --- At least that's the way it's in http://fedoraproject.org/wiki/Packaging/SysVInitScript Besides, requiring a package is AFAIK faster than going through the file lists, although the /sbin list is downloaded automatically anyways. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470508
Jussi Lehtola [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Comment #7 from Jussi Lehtola [EMAIL PROTECTED] 2008-11-09 15:07:44 EDT
---
Well, I might as well review the package.
- MUST: The package must own all the directories it creates.
%{_datadir}/ajaxterm/*
should be
%{_datadir}/ajaxterm
- MUST: License is incorrect - sarissa* files are licensed under LGPLv2+
License: Public Domain and LGPLv2+
Other than that I cannot do now, since the AjaxTerm site is down and I cannot
check the sources.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470508] Review Request: Ajaxterm - A web-based terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470508 Jussi Lehtola [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Jussi Lehtola [EMAIL PROTECTED] 2008-11-08 08:36:10 EDT --- Read http://fedoraproject.org/wiki/Packaging/UsersAndGroups and make necessary corrections to spec file (Requires and adding users). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
