[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165


Chris Weyl [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs- |fedora-cvs?




--- Comment #8 from Chris Weyl [EMAIL PROTECTED]  2008-11-25 11:47:46 EDT ---
New Package CVS Request
===
Package Name: perl-Test-Strict
Short Description: Check syntax, presence of use strict/warnings, and test
coverage
Owners: cweyl
Branches: F-8 F-9 F-10 devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165


Dennis Gilmore [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs-




--- Comment #7 from Dennis Gilmore [EMAIL PROTECTED]  2008-11-25 11:40:52 EDT 
---
please make a new CVS request with the correct summary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165


Dennis Gilmore [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #9 from Dennis Gilmore [EMAIL PROTECTED]  2008-11-25 11:59:07 EDT 
---
CVS Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165


Chris Weyl [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165





--- Comment #5 from Kevin Fenzi [EMAIL PROTECTED]  2008-11-22 23:22:26 EDT ---
no summary found ?

The spec seems to have 'Check syntax, presence of use strict/warnings, and test
coverage' is that not ok?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165





--- Comment #6 from Chris Weyl [EMAIL PROTECTED]  2008-11-23 02:53:32 EDT ---
(In reply to comment #5)
 no summary found ?
 
 The spec seems to have 'Check syntax, presence of use strict/warnings, and 
 test
 coverage' is that not ok?

That's a-ok, and what it should have been.  No summary was apparently a bug
in my script there...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165


Parag AN(पराग) [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review+




--- Comment #2 from Parag AN(पराग) [EMAIL PROTECTED]  2008-11-19 04:24:34 EDT 
---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=939617
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
34837b2bfabf73f7169bbfa4d00a403c  Test-Strict-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=26,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.19 cusr  0.02
csys =  0.24 CPU)

+ Package perl-Test-Block-0.11-1.fc11
  Provides: perl(Test::Block) = 0.11 perl(Test::Block::Plan)
  Requires: perl(Carp) perl(Scalar::Util) perl(Test::Builder) perl(Tie::Scalar)
perl(base) perl(overload) perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165





--- Comment #3 from Parag AN(पराग) [EMAIL PROTECTED]  2008-11-19 04:28:24 EDT 
---
sorry I mixed other perl package review with this.

Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=939617
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
34837b2bfabf73f7169bbfa4d00a403c  Test-Strict-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=40,  7 wallclock secs ( 0.03 usr  0.00 sys +  7.09 cusr  0.36
csys =  7.48 CPU)

+ Package perl-Test-Strict-0.09-1.fc11
  Provides: perl(Test::Strict) = 0.09
  Requires: perl = 0:5.004 perl(File::Find) perl(File::Spec) perl(FindBin)
perl(Test::Builder) perl(strict) perl(vars)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165





--- Comment #4 from Chris Weyl [EMAIL PROTECTED]  2008-11-19 11:30:03 EDT ---
New Package CVS Request
===
Package Name: perl-Test-Strict
Short Description: no summary found
Owners: cweyl
Branches: F-8 F-9 F-10 devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165


Chris Weyl [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage

2008-11-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472165





--- Comment #1 from Chris Weyl [EMAIL PROTECTED]  2008-11-19 00:08:05 EDT ---
This package is a dep of App::Asciio.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review