[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 Jason Tibbitts changed: What|Removed |Added Flag||needinfo?(ncjeff...@zimage. ||com) --- Comment #6 from Jason Tibbitts 2009-07-14 14:01:07 EDT --- It's been many months since the last comment with no response from the submitter; I'll close this ticket soon if there's no progress. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 Jeff Gustafson changed: What|Removed |Added Flag|needinfo?(ncjeff...@zimage. | |com)| --- Comment #7 from Jeff Gustafson 2009-07-14 21:07:22 EDT --- Somehow I must have missed your message. I made the requested changes. If there is issues with gettext, I will just compile with the English only version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 --- Comment #8 from Jason Tibbitts 2009-07-14 22:46:59 EDT --- Sorry, where did you make the requested changes? Could you post links to the updated spec and src.rpm? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 Juha Tuomala changed: What|Removed |Added URL||http://qodem.sourceforge.ne ||t/ Alias||qodem -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 --- Comment #5 from manuel wolfshant 2009-01-31 21:43:54 EDT --- Jeff, is there an updated package available for review ? At http://marlene.zimage.com/packages/ I can only see the first src.rpm Please do not forget to increment the release tag and add a proper entry in the changelog each time you make modifications to the spec. Are you already sponsored? I have not found you in FAS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 Thomas Spura changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #9 from Thomas Spura 2009-10-23 16:43:18 EDT --- (In reply to comment #5) > Are you already sponsored? I have not found you in FAS. I didn't found you, too and can't find an answer to the question in a comment above. Asking again: Are you already sponsored? (In reply to comment #6) > It's been many months since the last comment with no response from the > submitter; I'll close this ticket soon if there's no progress. There seems to be progress, but no release incremention... Your changelog from above is: %changelog * Sun Nov 30 2008 Jeff Gustafson - 0.1.2-1 - Initial package creation After applying the patch you could write: %changelog * Sun Oct 4 2009 Jeff Gustafson - 0.1.2-2 - patch for gettext * Sun Nov 30 2008 Jeff Gustafson - 0.1.2-1 - Initial package creation Notice the version incremention from 0.1.2-1 to 0.1.2-2. And post *new* links to the uploaded spec and src.rpm... (In reply to comment #6) > It's been many months since the last comment with no response from the > submitter; I'll close this ticket soon if there's no progress. Some month later, "soon" starts again from now on :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 Jason Tibbitts changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449(FE-DEADREVIEW) Resolution||NOTABUG --- Comment #10 from Jason Tibbitts 2009-11-07 22:08:52 EDT --- There's been no response in many months; I'm just going to go ahead and close this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 --- Comment #1 from Jeff Gustafson <[EMAIL PROTECTED]> 2008-12-08 19:39:02 EDT --- Is there anything else I need to do to this package/spec to spur further consideration on this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 --- Comment #2 from manuel wolfshant 2008-12-12 22:25:02 EDT --- At the first glance, I'd say that the license should be GPLv2+ because all the source files include either This program is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. or (note the "later" in the last line ) * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. The combination LGPLv2+ + GPLv2+ = GPLv2+ You should also drop the Requires line, rpmbuild will add the dependency automatically. The INSTALL file is useless for the users of the packaged qodem so I suggest to not include it at all. OTOH, you should include the manpage available as docs/qodem.1.The content of the NEWS file makes reference to a [much] older version, I would not include it (no problem however if you keep it, but the elegant procedure would be to remove it now and reinclude it if/when real news are provided). For language files there is a special procedure, please read and follow https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files. Please make sure you do not build your package against the bundled gettext (it is included below the intl/ directory). You should BuildRequire gettext instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 --- Comment #3 from Jeff Gustafson 2008-12-15 16:53:53 EDT --- Created an attachment (id=327029) --> (https://bugzilla.redhat.com/attachment.cgi?id=327029) Patch Makefile so that it ignores the included gettext directory -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474012] Review Request: qodem - terminal emulator and communications package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474012 --- Comment #4 from Jeff Gustafson 2008-12-15 16:57:40 EDT --- Thank you for checking out the package. I made the suggested changes. I make some quick changes to force the build to use the system-wide gettext. Let me know if this is either too heavy-handed or not going far enough. I included the patch as an attachment to this bug entry. I updated the .spec file and copied it up to the location initially reported in this entry. One other option would be to use the English-only .tar.gz file for qodem and avoid the gettext issue entirely. That way no .patch file would be needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
