[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag||fedora-cvs+ --- Comment #10 from Tom spot Callaway tcall...@redhat.com 2009-01-12 11:18:31 EDT --- New Package CVS Request === Package Name: irrlicht Short Description: A high performance real-time 3D engine Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE --- Comment #11 from Tom spot Callaway tcall...@redhat.com 2009-01-12 13:00:06 EDT --- Built for F-9, F-10, devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 --- Comment #8 from Tom spot Callaway tcall...@redhat.com 2009-01-10 14:29:45 EDT --- 1) Ehh, debuginfo looked like it was pulling in files from those dirs, I did this to be safe. 2) I've fixed it so that we have constant timestamps. 3) Good point, done. 4) Done, Tom Lane helped me find the proper fix. 5) You're right. It's zlib. My bad. :) New SPEC: http://www.auroralinux.org/people/spot/review/new/irrlicht.spec New SRPM: http://www.auroralinux.org/people/spot/review/new/irrlicht-1.5-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Lubomir Rintel lkund...@v3.sk 2009-01-10 15:05:08 EDT --- Thanks! Looks well now; good to go APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474603
--- Comment #7 from Lubomir Rintel lkund...@v3.sk 2009-01-08 12:15:24 EDT ---
Just a few notes, most of them not serious:
1.) Is this needed?
# We don't use any of this. Deleting it so the debuginfo doesn't pick it up.
rm -rf source/Irrlicht/jpeglib source/Irrlicht/zlib
I think the debuginfo is generated only from files that have an actual
reference in dwarf debugging information in binaries
2.) Preserve timestamps
for i in include/*.h doc/upgrade-guide.txt source/Irrlicht/*.cpp
source/Irrlicht/*.h source/Irrlicht/libpng/*.c source/Irrlicht/libpng/*.h; do
sed -i 's/\r//' $i
chmod -x $i
done
I think sed -i modifies a timestamp. I think you should care about keeping the
timestamp at least in doc file, to prevent a multilib conflict between the file
in packages of different architectures, but, well, I am not quite sure...
3.) You could improve the legibility of your SPEC file
cd source/Irrlicht
...
make INSTALL_DIR=%{buildroot}%{_libdir} install
cd ../..
This could be just
make -C source/Irrlicht INSTALL_DIR=%{buildroot}%{_libdir} install
4.) Please use system libpng.
While image handling libraries are frequently prone to security vulnerabilities
[1], it's probably not a problem for our irrlicht's embedded one since it only
reads trusted images. Still, code duplication is bad, please get libpng fixed
at least in rawhide.
[1] http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=libpng
5.) The license does not seem to be GPLv2+
Short look at the top of ./include/irrlicht.h gives me an impression this is
not exactly GPLv2+. Seems like zlib license.
The last paragraph (after 3.) seems to suggest something like an advertising
clause for IJG code, but I think it is not applicable for this package since we
link against external libjpeg, right? You'll definitely know better.
* builds fine in mock
* optflags used correctly
- license (see above)
* rpmlint silent
* spec file clean and legible
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? --- Comment #6 from Lubomir Rintel lkund...@v3.sk 2009-01-07 19:48:04 EDT --- For some reason I thought a complete review was already being done on this. Taking it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Tom spot Callaway [EMAIL PROTECTED] changed: What|Removed |Added Blocks||474606 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Marek Mahut [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Marek Mahut [EMAIL PROTECTED] 2008-12-04 12:36:39 EDT --- Hey Tom, its trying to run ldconfig during build. + unset DISPLAY + rm -rf /var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut + cd source/Irrlicht + mkdir -p /var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut/usr/lib + mkdir -p /var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut/usr/include/irrlicht + make INSTALL_DIR=/var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut/usr/lib install cp ../../lib/Linux/libIrrlicht.so.1.5.beta /var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut/usr/lib cd /var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut/usr/lib ln -s libIrrlicht.so.1.5.beta libIrrlicht.so ldconfig -n /var/tmp/irrlicht-1.5-0.1.beta.fc8-root-mmahut/usr/lib make: ldconfig: Command not found make: *** [install] Error 127 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 --- Comment #2 from Tom spot Callaway [EMAIL PROTECTED] 2008-12-04 12:44:39 EDT --- Weird, dunno how I missed that, I ran it through koji to completion. Let me fix that. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 --- Comment #3 from Tom spot Callaway [EMAIL PROTECTED] 2008-12-04 12:56:06 EDT --- New SRPM: http://www.auroralinux.org/people/spot/review/new/irrlicht-1.5-0.2.beta.fc11.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/irrlicht.spec I'm not sure how you got a build going without glibc, but I digress. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 Lubomir Rintel [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #4 from Lubomir Rintel [EMAIL PROTECTED] 2008-12-04 14:47:31 EDT --- (In reply to comment #3) I'm not sure how you got a build going without glibc, but I digress. :) I guess he uses Fedora 8, and therefore does not have sbin in his path. I'm wondering how could that ldconfig succeed for you -- you don't build packages as root, do you? :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474603 --- Comment #5 from Tom spot Callaway [EMAIL PROTECTED] 2008-12-04 15:04:32 EDT --- Nope, not as root. ldconfig seems to succeed with -n as a normal user. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
