[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Lubomir Rintel lkund...@v3.sk 2009-04-14 14:57:57 EDT --- I think this was imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2008-12-28 14:05:27 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2008-12-27 09:04:35 EDT --- (In reply to comment #0) Note: this package is part of the upcoming Xfce 4.6. You will need: Apart from the packages you enumerated that were found in xfce4-settings [1] directory, I've also grabbed xfconf [2], since a couple of packages demanded it. [1] http://www.scrye.com/~kevin/fedora/xfce4-settings/ [2] http://www.scrye.com/~kevin/fedora/xfconf/ * RPMlint is silent and happy * Spec file is mostly sane and legible * Compiler flags are used appropriately * Builds find in mock, with additional repository of xfce packages * Requires, provides and filelists are sane * License is correct A few notes: 1.) Please don't do --vendor ; in case upstream specifies vendor field, do not reset it, otherwise set it to fedora https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation 2.) Please ensure the following is correct: Build Configuration: * Installation prefix: /usr * Debug Support: minimum * Libnotify support: no * Xcursor support: yes * Sounds settings supportno * Libxklavier support: no Did you really mean to build w/o support for the above? 3.) The following line seems useless: find $RPM_BUILD_ROOT -name '*.desktop' -ls I guest it was forgotten there. Please remove it. I don't think any of the above would warrant a review blocker: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Kevin Fenzi ke...@tummy.com 2008-12-27 20:47:37 EDT --- 1.) Please don't do --vendor ; in case upstream specifies vendor field, do not reset it, otherwise set it to fedora https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation Good catch. Fixed to use fedora as vendor (upstream doesn't have one by default) 2.) Please ensure the following is correct: Build Configuration: * Installation prefix: /usr * Debug Support: minimum * Libnotify support: no * Xcursor support: yes * Sounds settings supportno * Libxklavier support: no Did you really mean to build w/o support for the above? Nope. Thanks for spotting those. Added some buildrequires to pick them up. 3.) The following line seems useless: find $RPM_BUILD_ROOT -name '*.desktop' -ls I guest it was forgotten there. Please remove it. Well, it's needed because the make install installs the desktop files, and I then install them again with desktop-file-install. I can just use --delete-original instead. I will switch to that. I don't think any of the above would warrant a review blocker: APPROVED Thanks! FYI, new package: Spec URL: http://www.scrye.com/~kevin/fedora/xfce4-settings/xfce4-settings.spec SRPM URL: http://www.scrye.com/~kevin/fedora/xfce4-settings/xfce4-settings-4.5.92-2.fc11.src.rpm CVS request: New Package CVS Request === Package Name: xfce4-settings Short Description: Settings Manager for Xfce Owners: kevin Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477990] Review Request: xfce4-settings - Settings Manager for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
