[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-07-19 06:18:24 EDT --- wmfire-1.2.3-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||1.2.3-2.fc10 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-07-19 06:36:12 EDT --- wmfire-1.2.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.2.3-2.fc10|1.2.3-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-07-11 13:04:12 EDT --- wmfire-1.2.3-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update wmfire'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7419 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-07-11 13:17:01 EDT --- wmfire-1.2.3-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update wmfire'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7472 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-07-07 03:14:02 EDT --- wmfire-1.2.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/wmfire-1.2.3-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-07-07 03:14:59 EDT --- wmfire-1.2.3-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/wmfire-1.2.3-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Tom spot Callaway tcall...@redhat.com 2009-07-06 17:24:04 EDT --- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (a0e296c454571dd650abd7d830a311c2c84e9339) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 steve st...@lonetwin.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from steve st...@lonetwin.net 2009-07-06 18:01:06 EDT --- Thanks for your time, Spot ! New Package CVS Request === Package Name: wmfire Short Description: WindowMaker dock app that displays cpu, memory or network load as flames Owners: lonetwin Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-07-07 00:26:12 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478744
--- Comment #3 from steve st...@lonetwin.net 2009-05-30 08:23:05 EDT ---
(In reply to comment #2)
A few points here:
1. Go through the spec and use macros consistently. Specifically, %{name},
%{version}.
Done.
2. Look at the license tag. Re-read:
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL
(hint: look at the source code)
Done. Added the correct license tag (GPLv2+) to the spec file.
3. Look at the Requires that rpm finds automatically. If it finds
libgtop-2.0.so.7() as a Requires, you don't need to explicitly list it as a
Requires.
Done.
4. Instead of wildcarding so aggressively for a single binary and manpage, why
not be more specific?
Done.
I've also checked both the spec file and rpm with rpmlint and received no
errors.
I'll do a more complete review when I see a new SRPM/SPEC.
Thanks for your time.
The latest spec and rpm are at:
http://lonetwin.net/wmfire.spec
http://lonetwin.net/wmfire-1.2.3-2.fc10.src.rpm
cheers,
- steve
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478744
Tom spot Callaway tcall...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||tcall...@redhat.com
AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
Flag||fedora-review?
--- Comment #2 from Tom spot Callaway tcall...@redhat.com 2009-02-18
14:29:30 EDT ---
A few points here:
1. Go through the spec and use macros consistently. Specifically, %{name},
%{version}.
2. Look at the license tag. Re-read:
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL
(hint: look at the source code)
3. Look at the Requires that rpm finds automatically. If it finds
libgtop-2.0.so.7() as a Requires, you don't need to explicitly list it as a
Requires.
4. Instead of wildcarding so aggressively for a single binary and manpage, why
not be more specific?
I'll do a more complete review when I see a new SRPM/SPEC.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 steve st...@lonetwin.net changed: What|Removed |Added Blocks||177841 --- Comment #1 from steve st...@lonetwin.net 2009-01-04 10:17:54 EDT --- I need a sponsor although this is not the first package I have submitted (bug 473583 is the first, which is still has NEW status and has yet to be reviewed). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
