[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #1 from Mattias Ellert 2009-03-15 20:03:20 EDT --- New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-rls-server-4.7-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-rls-server.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Bug 478931 depends on bug 453847, which changed state. Bug 453847 Summary: Review Request: grid-packaging-tools - The Grid Packaging Tools (GPT) https://bugzilla.redhat.com/show_bug.cgi?id=453847 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Bug 478931 depends on bug 453848, which changed state. Bug 453848 Summary: Review Request: globus-core - Globus Toolkit - Globus Core https://bugzilla.redhat.com/show_bug.cgi?id=453848 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED Bug 478931 depends on bug 453851, which changed state. Bug 453851 Summary: Review Request: globus-common - Globus Toolkit - Common Library https://bugzilla.redhat.com/show_bug.cgi?id=453851 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED --- Comment #2 from Mattias Ellert 2009-04-17 09:45:40 EDT --- Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-server-4.7-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-server.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478931
Orcan 'oget' Ogetbil changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review?
Bug 478931 depends on bug 478929, which changed state.
Bug 478929 Summary: Review Request: globus-usage - Globus Toolkit - Usage
Library
https://bugzilla.redhat.com/show_bug.cgi?id=478929
What|Old Value |New Value
Status|NEW |ASSIGNED
Resolution||NEXTRELEASE
Status|ASSIGNED|CLOSED
Bug 478931 depends on bug 467237, which changed state.
Bug 467237 Summary: Review Request: globus-gssapi-gsi - Globus Toolkit - GSSAPI
library
https://bugzilla.redhat.com/show_bug.cgi?id=467237
What|Old Value |New Value
Status|NEW |ASSIGNED
Resolution||NEXTRELEASE
Status|ASSIGNED|CLOSED
Bug 478931 depends on bug 478921, which changed state.
Bug 478921 Summary: Review Request: globus-io - Globus Toolkit - uniform I/O
interface
https://bugzilla.redhat.com/show_bug.cgi?id=478921
What|Old Value |New Value
Resolution||NEXTRELEASE
Status|ASSIGNED|CLOSED
Bug 478931 depends on bug 478930, which changed state.
Bug 478930 Summary: Review Request: globus-rls-client - Globus Toolkit -
Replica Location Service Client
https://bugzilla.redhat.com/show_bug.cgi?id=478930
What|Old Value |New Value
Resolution||NEXTRELEASE
Status|ASSIGNED|CLOSED
--- Comment #3 from Orcan 'oget' Ogetbil 2009-06-05
01:54:57 EDT ---
This one was quite different from the other globus packages. Here is my review:
- package builds in koji rawhide
http://koji.fedoraproject.org/koji/taskinfo?taskID=1394353
? I don't know if this
BuildRequires: globus-gssapi-gsi-devel >= 4
is really required, since
$ grep -rl gssapi *
pkgdata/pkg_data_src.gpt.in
Is it an upstream error or am I missing something?
* Afaik %setup is supposed to be used only once in a specfile. So
%setup -q -n %{_name}-%{version}
%setup -D -T -q -n %{_name}-%{version} -a 1
should be replaced by
%setup -q -n %{_name}-%{version} -a 1
? Actually, why are you not making globus_rls_server_setup a package on its
own?
! It would be good to briefly explain what Source{1,2,3} are for where you
declare them.
* rpmlint complains
globus-rls-server.x86_64: E: wrong-script-interpreter
/usr/share/globus/setup/SXXrls.in "@SHELL@"
globus-rls-server.x86_64: E: non-executable-script
/usr/share/globus/setup/SXXrls.in 0644
globus-rls-server.x86_64: E: non-readable /etc/globus-rls-server.conf 0600
globus-rls-server.x86_64: W: no-reload-entry
/etc/rc.d/init.d/globus-rls-server
Any words for these?
! Please preserve the timestamp of %{SOURCE3} in %install
! There is some html documentation under ./Doc that can be packaged. Also there
is an INSTALL.html
! I don't know how serious they are but
Doc/man/man8/globus-rls-server.8
Doc/html/globus-rls-server.html
server.c
contain references to /usr/local. You might want to fix them.
? /usr/share/globus/setup/setup-globus-common.pl defines perl location as
/usr/lib/perl/
Will this be a problem?
? Are the tests under ./test worth running in %check ?
! The package owns the directory
/usr/share/globus/packages/setup/
I wasn't sure if this is intentional (or if its contents should actually go to
/usr/share/globus/packages/globus_rls_server_setup/) and just wanted to bring
it into your attention.
* The scriplets are different than the ones in the guidelines:
http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
(See the Requires(*) stuff)
* %{_initrddir}/%{name} does not contain all the required actions
http://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions
? The "status" action in %{_initrddir}/%{name} has the port number hard-coded.
Shouldn't the port number be taken from %{_sysconfdir
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478931
--- Comment #4 from Mattias Ellert 2009-06-05
08:27:07 EDT ---
(In reply to comment #3)
> This one was quite different from the other globus packages. Here is my
> review:
>
> - package builds in koji rawhide
>http://koji.fedoraproject.org/koji/taskinfo?taskID=1394353
>
> ? I don't know if this
>BuildRequires: globus-gssapi-gsi-devel >= 4
> is really required, since
>$ grep -rl gssapi *
>pkgdata/pkg_data_src.gpt.in
> Is it an upstream error or am I missing something?
Yes, this is a bogus requirement stated in the upstream package description
file - fixed (patch updated too)
> * Afaik %setup is supposed to be used only once in a specfile. So
>%setup -q -n %{_name}-%{version}
>%setup -D -T -q -n %{_name}-%{version} -a 1
> should be replaced by
>%setup -q -n %{_name}-%{version} -a 1
You can have as many %setup lines you want as long as all except the first one
has a -D flag in order not the trigger the deletion of already unpacked sources
Quoting http://www.rpm.org/max-rpm/s1-rpm-specref-macros.html
"The -D option is used to direct %setup to not delete the build directory prior
to unpacking the sources. This option is used when more than one source archive
is to be unpacked into the build directory, normally with the -b or -a
options."
> ? Actually, why are you not making globus_rls_server_setup a package on its
> own?
See:
https://fedoraproject.org/wiki/PackagingDrafts/Globus#Setup_packages
and
https://fedoraproject.org/wiki/PackagingDrafts/Globus#Globus_package_that_provides_both_a_library_and_programs_and_that_has_a_corresponding_setup_package
The example above is from globus-common which already does the same (packaging
globus-common and globus-common-setup in the same SRPM).
> ! It would be good to briefly explain what Source{1,2,3} are for where you
> declare them.
Comments added.
> * rpmlint complains
>globus-rls-server.x86_64: E: wrong-script-interpreter
> /usr/share/globus/setup/SXXrls.in "@SHELL@"
>globus-rls-server.x86_64: E: non-executable-script
> /usr/share/globus/setup/SXXrls.in 0644
>globus-rls-server.x86_64: E: non-readable /etc/globus-rls-server.conf 0600
>globus-rls-server.x86_64: W: no-reload-entry
> /etc/rc.d/init.d/globus-rls-server
> Any words for these?
I removed the SXXrls.in file from the package - it is not useful for the RPM
package anyway since the RPM uses a %{SOURCE2} as the init.d script instead.
The configuration file is intentionally non-readable by non-root users since it
contains information about database username and password.
reload entry added to init.d script. It is empty since reloading is not
supported - as mandated by the guidelines.
> ! Please preserve the timestamp of %{SOURCE3} in %install
OK - Done for %{SOURCE2} as well.
> ! There is some html documentation under ./Doc that can be packaged. Also
> there
> is an INSTALL.html
The INSTALL.html file would be confusing to users since it contains information
about GPT and how to build from source which is not relevant when installing
from the RPM. The relevant part of the post-installation instructions are
available in %{SOURCE3} which is installed.
> ! I don't know how serious they are but
>Doc/man/man8/globus-rls-server.8
>Doc/html/globus-rls-server.html
>server.c
> contain references to /usr/local. You might want to fix them.
This is fixed by these lines already present in the spec file:
# Fix hardcoded default locations
sed 's!/usr/local/etc!/etc!g' -i server.c
sed 's!/usr/local/etc!/etc!g' -i Doc/man/man8/globus-rls-server.8
> ? /usr/share/globus/setup/setup-globus-common.pl defines perl location as
>/usr/lib/perl/
> Will this be a problem?
When using GPT as installed from the Fedora RPM the GPT perl module is already
in the default module path - so it will be found. The additions to the perl
include path of the $GPT_LOCATION/lib/perl directory (where they would be by
default in a configure, make, make install type installation) does not break
anything when using the RPM version.
> ? Are the tests under ./test worth running in %check ?
The test requires a postgres server where you are allowed to create and modify
tables - not something you want to do during an RPM build.
> ! The package owns the directory
>/usr/share/globus/packages/setup/
> I wasn't sure if this is intentional (or if its contents should actually go to
> /usr/share/globus/packages/globus_rls_server_setup/) and just wanted to bring
> it into your attention.
This is intentional.
> * The scriplets are different than the ones in the guidelines:
>
> http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
> (See the Requires(*) stuff)
The scriptlet requires are added.
> * %{_initrddir}/%{name} does not contain all the required actions
>
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Orcan 'oget' Ogetbil changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Orcan 'oget' Ogetbil 2009-06-05 12:24:15 EDT --- Thanks for the fixes! This package (globus-rls-server) is APPROVED by oget So this was the last one. Are there going to be more? You can add me to the CC if you submit more globus review requests. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Mattias Ellert changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Mattias Ellert 2009-06-05 12:50:01 EDT --- Thank you for all the reviews. There were a few bumps along the way, but we got there in the end. I think writing the Globus specific packaging guidelines helped pave the way. There are more Globus packages, but just right now I have not immediate plans for more - though I am open for requests from Globus users - the Globus gridftp server might be on the horizon eventually. My next set of packages will be some other pieces of Grid computing software which is not part of the Globus toolkit, but that are built against its libraries. New Package CVS Request === Package Name: globus-rls-server Short Description: Globus Toolkit - Replica Location Service Server Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Jason Tibbitts 2009-06-05 17:33:55 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #10 from Fedora Update System 2009-06-06 00:31:06 EDT --- globus-rls-server-4.7-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-rls-server-4.7-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #9 from Fedora Update System 2009-06-06 00:31:02 EDT --- globus-rls-server-4.7-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-rls-server-4.7-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #8 from Fedora Update System 2009-06-06 00:30:57 EDT --- globus-rls-server-4.7-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-rls-server-4.7-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #11 from Fedora Update System 2009-06-15 21:41:10 EDT --- globus-rls-server-4.7-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||4.7-2.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #12 from Fedora Update System 2009-06-15 22:13:50 EDT --- globus-rls-server-4.7-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Fedora Update System changed: What|Removed |Added Fixed In Version|4.7-2.fc10 |4.7-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 --- Comment #13 from Fedora Update System 2009-06-15 22:21:29 EDT --- globus-rls-server-4.7-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Fedora Update System changed: What|Removed |Added Fixed In Version|4.7-2.fc9 |4.7-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478931] Review Request: globus-rls-server - Globus Toolkit - Replica Location Service Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Mattias Ellert changed: What|Removed |Added Depends on||453847, 453848, 453851, ||467237, 478921, 478929, ||478930 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
