[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #14 from Fabian Affolter fab...@bernewireless.net 2009-02-20 06:41:14 EDT --- Was pushed to stable https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1535 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1510 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2009-02-05 09:08:00 EDT --- Source RPM for Fedora 10 SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gipfel-0.2.5-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #7 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-05 09:41:29 EDT --- Is there a specific reason to not use the latest version ( http://www.ecademix.com/JohannesHofmann/gipfel-0.2.6.tar.gz ) ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Flag||fedora-review? --- Comment #6 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-05 09:38:16 EDT --- I'd say that GenericName=Genomic sequences viewer Comment=Visualizer for multiple alignments of genomic sequences Icon=redhat-starther is a bit odd for gipsel :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #8 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-05 10:09:52 EDT --- Everything seems OK, please update to 0.2.6 and I'll come back with a full review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #9 from Fabian Affolter fab...@bernewireless.net 2009-02-05 12:45:58 EDT --- (In reply to comment #6) I'd say that GenericName=Genomic sequences viewer Comment=Visualizer for multiple alignments of genomic sequences Icon=redhat-starther is a bit odd for gipsel :) Yes, it is. (In reply to comment #7) Is there a specific reason to not use the latest version ( http://www.ecademix.com/JohannesHofmann/gipfel-0.2.6.tar.gz ) ? No Updated files Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gipfel.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gipfel-0.2.6-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479535
manuel wolfshant wo...@nobugconsulting.ro changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #10 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-05
13:55:39 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM: empty
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[!] License field in the package spec file matches the actual license.
License type as specified by the license tag: GPLv2+
License type: as specified by the sources: GPLv3+
== see note 1
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package match the upstream source, as provided
in the spec URL.
SHA1SUM of package: b12892834340323f38f60d2ce14df8f38aae9dfa
gipfel-0.2.6.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[!] Package consistently uses macros.
== see note 2
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Final provides and requires are sane.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: koji scratch build
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: koji scratch build
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the test passes.
=== Final Notes ===
1. All source files reference the bundled COPYING file which is the stock
GPLv3+
2. please replace desktop-file-install --dir=${RPM_BUILD_ROOT} with the
equivalent %{buildroot} command
I am going to trust you to correct the above two issues before commit.
I also suggest to use [...] POI finder instead of [...] POI namer in the
desktop file. I am not a native speaker so I might be wrong, but namer sounds
odd.
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #11 from Fabian Affolter fab...@bernewireless.net 2009-02-05 15:16:22 EDT --- Thanks for the review. I will fix all issues before I import the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Fabian Affolter fab...@bernewireless.net 2009-02-05 15:17:04 EDT --- New Package CVS Request === Package Name: gipfel Short Description: A tool to find the names of mountains or POI on a picture Owners: fab Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Kevin Fenzi ke...@tummy.com 2009-02-05 22:02:52 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #3 from Fabian Affolter fab...@bernewireless.net 2009-01-26 10:09:42 EDT --- Unfortunately I deleted the spec file and the Source RPM at the mentioned location in Comment #2. Please be patient till the two files are back. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #4 from Fabian Affolter fab...@bernewireless.net 2009-01-26 16:56:56 EDT --- The files are back... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479535 --- Comment #2 from Fabian Affolter fab...@bernewireless.net 2009-01-15 19:14:06 EDT --- Thanks Michael for your comment. Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gipfel.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gipfel-0.2.5-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479535] Review Request: gipfel - A tool to find the names of mountains or POI on a picture
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479535
--- Comment #1 from Michael Schwendt bugs.mich...@gmx.net 2009-01-13
14:19:47 EDT ---
Directory %{_datadir}/%{name}/ is not included.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
