[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #9 from Fedora Update System 2009-02-07 17:19:38 EDT --- cgit-0.8.2-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update cgit'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1447 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #10 from Fedora Update System 2009-02-07 17:22:34 EDT --- cgit-0.8.2-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cgit'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1473 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #11 from Fedora Update System 2009-02-24 15:41:10 EDT --- cgit-0.8.2-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||0.8.2-1.fc9 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 Fedora Update System changed: What|Removed |Added Fixed In Version|0.8.2-1.fc9 |0.8.2-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #12 from Fedora Update System 2009-02-24 15:42:19 EDT --- cgit-0.8.2-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #2 from Todd Zullinger 2009-01-12 14:16:18 EDT --- httpd is required for ownership of /etc/httpd/conf.d. If that can be made more generic, I'd be all for it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 seth vidal changed: What|Removed |Added CC||svi...@redhat.com --- Comment #1 from seth vidal 2009-01-12 14:11:42 EDT --- rpmlint checks out package passes all MUST requirements from review checks Does it REALLY require httpd - or does it only require 'webserver'? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 seth vidal changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|svi...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #3 from Jeremy Katz 2009-01-12 14:50:54 EDT --- The other comment I have from a quick look is that the %define at the top for the make really probably should just be explicitly in the %build section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479723
--- Comment #4 from seth vidal 2009-01-12 14:56:25 EDT ---
>From Tibbs:
The package shouldn't own this dir:
%define scriptdir %{_localstatedir}/www/cgi-bin
End from Tibbs.
>From Me:
that is provided by httpd which the pkg already deps on, so it's okay to remove
that dir ownership.
If you remove the ownership of that dir then this pkg is approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #5 from Todd Zullinger 2009-01-12 15:01:13 EDT --- (In reply to comment #3) > The other comment I have from a quick look is that the %define at the top for > the make really probably should just be explicitly in the %build section. True, it could be. I had it there to start, but it causes a spurious warning from rpmlint, which I figured could be easily avoided by defining it outside of %build and %prep. Does that cause any harm? And is it uglier there than the rpmlint warning might be? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479723
Todd Zullinger changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #6 from Todd Zullinger 2009-01-12 15:07:33 EDT ---
Thanks for the quick review Seth (and the helpful eyes from Tibbs). I'll fix
that ownership up thusly:
-%{scriptdir}
+%{scriptdir}/*
Any concerns about getting the SELinux contexts setup properly before importing
the package? I could add some policy to the package, but I couldn't find any
guidelines on whether that was preferable to getting the changes into
selinux-policy directly. All I found was a draft, which might be old and
outdated:
http://fedoraproject.org/wiki/PackagingDrafts/SELinux
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 seth vidal changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #7 from Todd Zullinger 2009-01-12 22:02:52 EDT --- New Package CVS Request === Package Name: cgit Short Description: A fast webinterface for git Owners: tmz Branches: F-10 F-9 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 Todd Zullinger changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479723] Review Request: cgit - A fast webinterface for git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi 2009-01-13 15:30:47 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
