[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-02-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE




--- Comment #11 from Fabian Affolter fab...@bernewireless.net  2009-02-20 
06:56:37 EDT ---
Was pushed to stable

https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1371
https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1355

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #9 from Fedora Update System upda...@fedoraproject.org  
2009-02-04 21:21:41 EDT ---
nullmodem-0.0.5-2.fc10 has been pushed to the Fedora 10 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nullmodem'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1355

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #10 from Fedora Update System upda...@fedoraproject.org  
2009-02-04 21:23:07 EDT ---
nullmodem-0.0.5-2.fc9 has been pushed to the Fedora 9 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update nullmodem'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1371

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Kevin Fenzi ke...@tummy.com  2009-01-30 01:16:17 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-01-28 
18:37:31 EDT ---
License tag changed.

Updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/nullmodem.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/nullmodem-0.0.5-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Lucian Langa co...@gnome.eu.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #5 from Lucian Langa co...@gnome.eu.org  2009-01-29 00:39:06 EDT 
---
Looking good.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #7 from Fabian Affolter fab...@bernewireless.net  2009-01-29 
01:56:23 EDT ---
New Package CVS Request
===
Package Name: nullmodem
Short Description: A utility to loopback pseudo-terminals
Owners: fab
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Fabian Affolter fab...@bernewireless.net  2009-01-29 
01:55:46 EDT ---
Lucian, thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222


Lucian Langa co...@gnome.eu.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||co...@gnome.eu.org
 AssignedTo|nob...@fedoraproject.org|co...@gnome.eu.org
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #1 from Lucian Langa co...@gnome.eu.org  2009-01-26 13:57:34 EDT 
---
Review:

OK  source files match upstream:
7ccb4c831f9a33c14f6c6e599e1ac102  nullmodem-0.0.5.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
NOT OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
  final provides and requires are sane:
nullmodem = 0.0.5-1.fc11
nullmodem(x86-64) = 0.0.5-1.fc11
  =
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libutil.so.1()(64bit)
OK  %check is not present; no test suite upstream.
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.


License tag should be GPL+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-26 
17:47:44 EDT ---
COPYING says GPLv2, source header not specified, index.html says GPL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480222] Review Request: nullmodem - A utility to loopback pseudo-terminals

2009-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480222





--- Comment #3 from Lucian Langa co...@gnome.eu.org  2009-01-27 00:44:19 EDT 
---
Paragraph 9 of COPYING:

If the Program does not specify a version number of
this License, you may choose any version ever published by the Free Software
Foundation.

http://fedoraproject.org/wiki/Licensing says:

A GPL or LGPL licensed package that lacks any statement of what version that
it's licensed under in the source code/program output/accompanying docs is
technically licensed under *any* version of the GPL or LGPL, not just the
version in whatever COPYING file they include.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review