[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-04-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||3.1-2.fc10
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-04-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #19 from Fedora Update System upda...@fedoraproject.org  
2009-04-15 13:58:19 EDT ---
fluid-soundfont-3.1-2.fc10 has been pushed to the Fedora 10 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-04-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #18 from Fedora Update System upda...@fedoraproject.org  
2009-04-14 16:32:51 EDT ---
fluid-soundfont-3.1-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/fluid-soundfont-3.1-2.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Blocks||492203




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
   Flag||fedora-review+




--- Comment #14 from Tom spot Callaway tcall...@redhat.com  2009-03-17 
16:08:27 EDT ---
Good:

- rpmlint checks return: nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #15 from Tom spot Callaway tcall...@redhat.com  2009-03-17 
16:08:51 EDT ---
Whoops, forgot to mention that I reviewed/approved the one with gus.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #16 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-17 
17:02:33 EDT ---
Thanks spot!

New Package CVS Request
===
Package Name: fluid-soundfont
Short Description: Pro-quality GM/GS soundfont
Owners: oget
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #17 from Kevin Fenzi ke...@tummy.com  2009-03-17 23:35:50 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #13 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-10 
15:05:55 EDT ---
Should I reupload the SRPM with the above SPEC (it's a huge file, and thus
pain) ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Kevin Kofler ke...@tigcc.ticalc.org changed:

   What|Removed |Added

 CC||ke...@tigcc.ticalc.org




--- Comment #6 from Kevin Kofler ke...@tigcc.ticalc.org  2009-03-06 10:33:54 
EDT ---
 Given that all those which need gus patches explictly require
 PersonalCopy-Lite's gus patches, and that those do a decent job (sf2 to gus
 format conversion is not perfect, as the feature sets of the 2 formats are not
 a 100% match), I see no use in having a gus version of the fluid font, esp.
 given the huge package size this will cause.

Well, the use would be to make them use a truly Free soundfont by default
instead of a just freely distributable one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com




--- Comment #7 from Tom spot Callaway tcall...@redhat.com  2009-03-06 
11:19:38 EDT ---
Which one should I be reviewing, with gus or without?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #8 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-06 
11:32:15 EDT ---
What do you think? Is 250MB too large for an RPM?
(it is really not hard for users to create these gus patches themselves)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #9 from Tom spot Callaway tcall...@redhat.com  2009-03-06 
11:39:57 EDT ---
Unless you think there is a serious advantage to the larger package, I'd prefer
the smaller one. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #10 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-06 
11:49:06 EDT ---
No, the gus patches are going to a different subpackage, which will be ~250MB.
The main package size won't change (~131MB)

Oh, by the way, I can trim a few more banks to get the gus subpackage down to
as low as ~100MB or so. But then it won't have as many banks as
PersonalCopy-Lite-patches has.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #11 from Tom spot Callaway tcall...@redhat.com  2009-03-06 
11:55:09 EDT ---
You'd know better than I would as to what decisions to make here. Make one and
let me know what to review. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #12 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-06 
12:05:30 EDT ---
Well, it is a matter of choice between freedom and quality (fluid-soundfont)
versus convenience in terms of package size (pclite-soundfont).

I would personally vote for freedom and quality. Also, I believe that many
people who are into music/audio production prefer quality. 

If it is up to me I would choose
http://6mata.com:8014/review/fluid-soundfont.spec.with.gus

Note that, you will need to download the SRPM in the original message and
overwrite its SPEC file with this one to review the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Blocks||486760




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-02-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-02-01 
16:57:45 EDT ---
I managed to cut the size of the patches subpackage down to ~250MB by removing
some banks (that are also not in the PersonalCopy-Lite) and by extracting only
a single layer from each instrument. But 250MB is still too much.

I'll work on it more. Here's my working copy if someone wants to help:

http://6mata.com:8014/review/fluid-soundfont.spec.with.gus

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #2 from Hans de Goede hdego...@redhat.com  2009-01-31 08:28:42 
EDT ---
Woa, fluid relicensed under an MIT license, that is great news! You know I
spend *days* mailing with soundfont authors to even find one that is freely
re-distributable (albeit not free), so that we could atleast have midi playback
functionality in Fedora.

Anyways about the gus patches, *a* set of gus patches is needed for (older)
timidity derived midi playing code, as found in libtimidity, allegro and
SDL_mixer to be able to play midi. timidity itself now can also handle sf2
files. 

Given that all those which need gus patches explictly require
PersonalCopy-Lite's gus patches, and that those do a decent job (sf2 to gus
format conversion is not perfect, as the feature sets of the 2 formats are not
a 100% match), I see no use in having a gus version of the fluid font, esp.
given the huge package size this will cause.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-01-31 
13:09:55 EDT ---
I made an attempt to modify the SPEC file so that one can build the GUS
subpackages by passing --with GUS to rpmbuild:

http://6mata.com:8014/review/fluid-soundfont.spec.optional.gus

Should I leave it like this, or should I revert?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376





--- Comment #4 from Hans de Goede hdego...@redhat.com  2009-01-31 17:51:01 
EDT ---
Having --with GUS is fine with me, but seems of little value, so dropping it
might be a good idea too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483376] Review Request: fluid-soundfont - Pro-quality GM/GS soundfont

2009-01-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483376


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 CC||hdego...@redhat.com




--- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-01-31 
02:29:20 EDT ---
Forgot the link. Here it is:
  
http://www.nabble.com/RFS:-fluid-soundfontFluid-(R3)-General-MIDI-SoundFont-td15579882.html


Adding Hans to the CC.

Hans, originally I made GUS patches subpackages for this one, the same way
you did for the PersonalCopy soundfont. But then I ended up with a ~1.5GB RPM.
Shall we look for a method to cut that size? Do we need GUS patches for this?
Users can build them easily themselves if they want.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review