[Bug 483403] Review Request: gdesklet-citation - A collection of quotes in French for gdesklets

2009-03-10 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483403





--- Comment #19 from MERCIER   2009-03-10 15:17:52 
EDT ---
link:

http://bioinformatiques.free.fr/gdesklets-citation-1.5.8.fc10.noarch.rpm

http://bioinformatiques.free.fr/gdesklets-citation-1.5-8.fc10.src.rpm

http://bioinformatiques.free.fr/gdesklets-citation.spec  

rpmlint issue:
$ rpmlint rpmbuild/RPMS/noarch/gdesklets-citation-1.5-8.fc10.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint rpmbuild/SRPMS/gdesklets-citation-1.5-8.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint rpmbuild/SPECS/gdesklets-citation.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483403] Review Request: gdesklet-citation - A collection of quotes in French for gdesklets

2009-03-08 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483403





--- Comment #18 from MERCIER   2009-03-08 11:58:14 
EDT ---
%changelog
* Sun Mar 8 2009  Jonathan MERCIER  - 1.3-7
- change license GPLv2 to GPL+
- change name "gdesklet-citation" to "gdesklets-citation"
- remove requires python
- use %%global instead of %%define
- directory %%{_datadir}/gdesklets/Displays/%%{_appname}/ is owned by this
package.

i wait my new version of this desklets (tomorrow) for put here .spec src.rpm
files

thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483403] Review Request: gdesklet-citation - A collection of quotes in French for gdesklets

2009-03-07 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483403


Mamoru Tasaka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?




--- Comment #17 from Mamoru Tasaka   2009-03-07 
13:44:11 EDT ---
Well, the trouble is that currently gdesklets itself won't
work on my rawhide machine :( However I will review this

Some notes:

* License
  - The license tag should be "GPL+", because no version
is specified (putting GPLv2 license text is not enough
to limit version)

* Name
  - should be gdesklet"s"-citation

* Requires
  - gdesklets already requires python 
(gdesklets requires gnome-python2-gconf, and gnome-python2-gconf
 requires python)

! %define -> %global
  - For some reason (mainly because of unexpected behavior of
%define on nested macros), now Fedora packaging guideline
recommends to use %global instead of %define.

* %setup
--
%setup -q -c %{name}-%{version} -a0
--
  - "%setup -q -c" is enough.

* Directory ownership issue
  - The directory %{_datadir}/gdesklets/Displays/%{_appname}/
must be owned by this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483403] Review Request: gdesklet-citation - A collection of quotes in French for gdesklets

2009-03-07 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483403


Mamoru Tasaka  changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |




--- Comment #16 from Mamoru Tasaka   2009-03-07 
13:05:13 EDT ---
(In reply to comment #15)
> I do not see that you are in the packager group, so I have indicated that you
> need a sponsor.  

I am sponsoring the submitter.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483403] Review Request: gdesklet-citation - A collection of quotes in French for gdesklets

2009-03-07 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483403


Jason Tibbitts  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)
Summary|Review Request: A   |Review Request:
   |collection of quotes in |gdesklet-citation - A
   |French for gdesklets|collection of quotes in
   ||French for gdesklets




--- Comment #15 from Jason Tibbitts   2009-03-07 12:39:31 
EDT ---
I do not see that you are in the packager group, so I have indicated that you
need a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review