[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #41 from Caius 'kaio' Chance ccha...@redhat.com 2009-05-19 20:43:20 EDT --- Package Change Request == Package Name: ibus-table-cangjie New Branches: F-10 Owners: cchance -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Caius 'kaio' Chance ccha...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #42 from Kevin Fenzi ke...@tummy.com 2009-05-20 01:37:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #39 from Jens Petersen peter...@redhat.com 2009-03-15 20:46:30 EDT --- cvs admin done; for reference: [[ Package Name: ibus-table-cangjie Short Description: Cangjie input method tables for ibus-table Owners: cchance Branches: devel InitialCC: i18n-team ]] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Caius kaio Chance ccha...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #40 from Caius kaio Chance ccha...@redhat.com 2009-03-15 22:21:42 EDT --- Built to rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=94216 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #28 from Jens Petersen peter...@redhat.com 2009-03-12 03:23:00 EDT --- Created an attachment (id=334902) -- (https://bugzilla.redhat.com/attachment.cgi?id=334902) ibus-table-cangjie.spec-3.patch With this it builds again in mock and some macro use fixes. (Just change %bcond_without to %bcond_with to turn off bootstrapping.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #29 from Caius kaio Chance ccha...@redhat.com 2009-03-12 03:39:30 EDT --- http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090309-3.fc11.src.rpm Patched from comment #28. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #30 from Jens Petersen peter...@redhat.com 2009-03-12 04:26:39 EDT --- Created an attachment (id=334904) -- (https://bugzilla.redhat.com/attachment.cgi?id=334904) ibus-table-cangjie.spec-4.patch This patch should do the --no-create-index properly: with my inspection NO_INDEX is (now?) a no-op. Better would be to change this upstream to be a configure option (--without-index). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #31 from Jens Petersen peter...@redhat.com 2009-03-12 04:28:12 EDT --- I guess now %post may change the checksum of the db files at install - so probably they should be labelled such in %files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #32 from Jens Petersen peter...@redhat.com 2009-03-12 04:32:49 EDT --- Also if COPYING only applies to icons I think it would be better to move it to the icons directory upstream otherwise it is a bit misleading or labelled as such at least. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488010
--- Comment #33 from Jens Petersen peter...@redhat.com 2009-03-12 04:35:21
EDT ---
Here is the review:
+:ok, =:needs attention, -:needs fixing, NA: not applicable
MUST Items:
[+] MUST: rpmlint output
[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release
21b4c23cd7c700330d7006d8c38f3b2e ibus-table-cangjie-1.1.0.20090309.tar.gz
[+] MUST: must successfully compile and build into binary rpms on one main arch
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[?] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
Any Chinese translation available?
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
However words/minute feature should be disabled.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
Apart from comment 31, I think the package looks ok now.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #34 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-03-12 05:02:07 EDT --- I think Requires(post) should be used on this srpm to ensure the correct rpm order. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #35 from Caius kaio Chance ccha...@redhat.com 2009-03-12 21:35:46 EDT --- http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090309-5.fc11.src.rpm - check md5 for .db files - move COPYING to icons/ - requires ibus-table for post-install -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #36 from Jens Petersen peter...@redhat.com 2009-03-12 22:25:27 EDT --- Looks good to me now, thanks Package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Caius kaio Chance ccha...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #37 from Caius kaio Chance ccha...@redhat.com 2009-03-13 00:12:19 EDT --- Package Change Request === Package Name: ibus-table-cangjie Short Description: Cangjie and Quick input method for ibus-table. Owners: cchance Branches: N/A (devel) InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #38 from Caius kaio Chance ccha...@redhat.com 2009-03-13 01:16:50 EDT --- http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090309-6.fc11.src.rpm refined license for tables/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #26 from Caius kaio Chance ccha...@redhat.com 2009-03-11 07:34:38 EDT --- (In reply to comment #25) Yep, adding ibus-table-quick later is fine: well whatever upstream decides - but sounds like it makes sense to separate the quicks into a separate package. :) Upstream has granted this decision make to me. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488010
--- Comment #27 from Caius kaio Chance ccha...@redhat.com 2009-03-11
23:46:47 EDT ---
http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec
http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090309-2.fc11.src.rpm
Added index creation in %post for cangjie{3,5} and quick {3,5}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #25 from Jens Petersen peter...@redhat.com 2009-03-10 06:53:45 EDT --- (In reply to comment #24) Files generated in %post (.db files) are actually created during running of autogen.sh. Ok I will check but what about comment 4: shouldn't the indices be added at installed time? Personally I prefer to do it after package review of all other 5 ibus-table-* done. Yep, adding ibus-table-quick later is fine: well whatever upstream decides - but sounds like it makes sense to separate the quicks into a separate package. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #20 from Jens Petersen peter...@redhat.com 2009-03-09 02:50:12 EDT --- It is possible to request a new upstream release or do a snapshot to fix the license issue: I don't patching the license file is a good idea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #21 from Caius kaio Chance ccha...@redhat.com 2009-03-09 03:28:45 EDT --- Sure. Will do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #22 from Caius kaio Chance ccha...@redhat.com 2009-03-09 20:32:24 EDT --- http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090309-1.fc11.src.rpm Updated to latest upstream sources. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #23 from Jens Petersen peter...@redhat.com 2009-03-09 23:15:39 EDT --- %post no longer needed? Is it better to separate Quick and Cangjie or to keep them together? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #24 from Caius kaio Chance ccha...@redhat.com 2009-03-10 00:08:07 EDT --- Files generated in %post (.db files) are actually created during running of autogen.sh. I have modified the upstream configure.ac to even get quick 3 and 5 generated at once, too. If you think that is a better solution for separating quick and cangjie into different packages, I would not mind. However, this involves creation of quick tarball on upstream sources system, modification of current cangjie tarball, package creation of quick and its review, etc. Personally I prefer to do it after package review of all other 5 ibus-table-* done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Jens Petersen peter...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|peter...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #18 from Jens Petersen peter...@redhat.com 2009-03-08 21:55:30 EDT --- If the cangjie tables are from the public domain, then the license should reflect that. I think we need a new upstream package with the correct license. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #19 from Caius kaio Chance ccha...@redhat.com 2009-03-09 00:39:36 EDT --- http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090220-4.fc11.src.rpm Updated rpm proposal. Cloning to upstream now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #7 from Caius kaio Chance ccha...@redhat.com 2009-03-05 18:59:46 EDT --- Added BuildRequires automake. Updated license # to GPLv3. Rebuilt. Spec URL: http://fedorapeople.org/~cchance/packaging/ibus-table-cangjie-1.1.0.20090220-2.fc11.src.rpm SRPM URL: http://fedorapeople.org/~cchance/packaging/ibus-table-cangjie.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #9 from Jens Petersen peter...@redhat.com 2009-03-05 20:18:28 EDT --- Created an attachment (id=334251) -- (https://bugzilla.redhat.com/attachment.cgi?id=334251) ibus-table-cangjie.spec-1.patch - no need to rebootstrap - silence setup Still does not build on i386 since ibus-table.noarch contains /usr/lib64/pkgconfig/ibus-table.pc! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #11 from Jens Petersen peter...@redhat.com 2009-03-05 21:45:50 EDT --- rpmlint says: ibus-table-cangjie.noarch: E: zero-length /usr/share/doc/ibus-table-cangjie-1.1.0.20090220/AUTHORS ibus-table-cangjie.noarch: W: summary-ended-with-dot Cang Jie input methods for ibus-table. Please fix those. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #14 from Caius kaio Chance ccha...@redhat.com 2009-03-05 23:08:47 EDT --- Tested on latest rawhide w/ koji ibus-table-1.1.0.20090220-5.fc11.noarch, cangjie 3 and 5 are in ibus-setup to be enabled. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #13 from Caius kaio Chance ccha...@redhat.com 2009-03-05 23:07:00 EDT --- Applied patch in comment #10. Updated AUTHORS. Fixed summary-ended-with-dot. Spec URL: http://fedorapeople.org/~cchance/packaging/ibus-table-cangjie-1.1.0.20090220-3.fc11.src.rpm SRPM URL: http://fedorapeople.org/~cchance/packaging/ibus-table-cangjie.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #16 from Jens Petersen peter...@redhat.com 2009-03-06 00:26:16 EDT --- spec and srpm links are reversed above again srpm is missing: you still need a patch? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #17 from Caius kaio Chance ccha...@redhat.com 2009-03-06 00:49:33 EDT --- patch is updated http://cchance.fedorapeople.org/packaging/ibus-table-cangjie.spec http://cchance.fedorapeople.org/packaging/ibus-table-cangjie-1.1.0.20090220-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #6 from Parag AN(पराग) panem...@gmail.com 2009-03-04 04:30:58 EDT --- build failed- http://koji.fedoraproject.org/koji/taskinfo?taskID=1219412 also I see you included COPYING with text of GPLv3 and license tag in spec is GPLv2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Caius kaio Chance ccha...@redhat.com changed: What|Removed |Added AssignedTo|peter...@redhat.com |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Caius kaio Chance ccha...@redhat.com changed: What|Removed |Added Flag|fedora-review?, | |needinfo?(peter...@redhat.c | |om) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488010] Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 Caius kaio Chance ccha...@redhat.com changed: What|Removed |Added Summary|Package Review: |Review Request: |ibus-table-cangjie |ibus-table-cangjie - Cang ||Jie input method for ||ibus-table. --- Comment #5 from Caius kaio Chance ccha...@redhat.com 2009-03-02 23:47:21 EDT --- Spec URL: http://fedorapeople.org/~cchance/packaging/ibus-table-cangjie-1.1.0.20090220-1.fc11.src.rpm SRPM URL: http://fedorapeople.org/~cchance/packaging/ibus-table-cangjie.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
