[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 Fedora Update System changed: What|Removed |Added Fixed In Version||0.5-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #13 from Fedora Update System 2009-05-02 12:42:27 EDT --- geanyvc-0.5-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #12 from Fedora Update System 2009-04-16 05:07:52 EDT --- geanyvc-0.5-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/geanyvc-0.5-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 Pierre-YvesChibon changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #11 from Pierre-YvesChibon 2009-04-02 05:02:16 EDT --- Thanks for the review it is being built :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Dennis Gilmore 2009-04-01 12:39:27 EDT --- CVS done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 Pierre-YvesChibon changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Pierre-YvesChibon 2009-04-01 10:33:40 EDT --- New Package CVS Request === Package Name: geanyvc Short Description: Version controler plugin for geany Owners: pingou Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490725
Parag AN(पराग) changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #8 from Parag AN(पराग) 2009-04-01 06:07:35
EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1269712
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
643b4b8ac313754e05c2e60db9c2713c geanyvc-0.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package geanyvc-0.5-2.fc11.i586 =>
Provides: geanyvc.so
Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1.3) libcairo.so.2 libfontconfig.so.1 libfreetype.so.6
libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0
libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0
libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 rtld(GNU_HASH)
+ Not a GUI App
Suggestions:
1) package should not own /usr/lib/geany as its owned by geany
Change
%{_libdir}/geany/
to
%{_libdir}/geany/*
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 Parag AN(पराग) changed: What|Removed |Added CC||fed...@krishnan.cc --- Comment #7 from Parag AN(पराग) 2009-04-01 05:54:50 EDT --- *** Bug 458773 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #6 from Pierre-YvesChibon 2009-04-01 05:22:00 EDT --- What should we do ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #5 from Pierre-YvesChibon 2009-03-20 04:15:07 EDT --- SRPM: http://pingou.fedorapeople.org/RPMs/geanyvc-0.5-2.fc10.src.rpm SPEC: http://pingou.fedorapeople.org/RPMs/geanyvc.spec KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=1250871 Thanks :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #4 from Pierre-YvesChibon 2009-03-20 04:02:09 EDT --- (In reply to comment #2) > 1)koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1250821 > missing intltool > 2) License looks to be GPLv2+ I'll correct these and upload a new spec/srpm > just found this review already submitted > https://bugzilla.redhat.com/show_bug.cgi?id=458773 Since there has been no change in the bug since October 2008 I left a comment there asking if the reporter was still interested. Let's see if the reporter is still present :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #3 from Parag AN(पराग) 2009-03-20 03:47:15 EDT --- just found this review already submitted https://bugzilla.redhat.com/show_bug.cgi?id=458773 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 --- Comment #2 from Parag AN(पराग) 2009-03-20 03:44:45 EDT --- 1)koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1250821 missing intltool 2) License looks to be GPLv2+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490725] Review Request: geanyvc - Version Controler plugin for geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490725 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? --- Comment #1 from Parag AN(पराग) 2009-03-18 10:47:36 EDT --- I will review this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
