[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #18 from Fedora Update System upda...@fedoraproject.org  
2009-06-18 07:41:52 EDT ---
mingw32-libtiff-3.8.2-16.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #19 from Fedora Update System upda...@fedoraproject.org  
2009-06-18 07:44:40 EDT ---
mingw32-libtiff-3.8.2-16.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|3.8.2-16.fc11   |3.8.2-16.fc10




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||3.8.2-16.fc11
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #16 from Fedora Update System upda...@fedoraproject.org  
2009-06-15 21:47:31 EDT ---
mingw32-libtiff-3.8.2-16.fc11 has been pushed to the Fedora 11 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mingw32-libtiff'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6162

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #17 from Fedora Update System upda...@fedoraproject.org  
2009-06-15 22:05:38 EDT ---
mingw32-libtiff-3.8.2-16.fc10 has been pushed to the Fedora 10 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mingw32-libtiff'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-6289

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Jason Tibbitts ti...@math.uh.edu  2009-06-08 12:20:49 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-06-08 22:47:42 EDT ---
mingw32-libtiff-3.8.2-16.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-libtiff-3.8.2-16.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #14 from Fedora Update System upda...@fedoraproject.org  
2009-06-08 22:49:27 EDT ---
mingw32-libtiff-3.8.2-16.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/mingw32-libtiff-3.8.2-16.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #15 from Kevin Fenzi ke...@tummy.com  2009-06-08 23:36:12 EDT ---
Note that this package didn't build as reviewed... please do make sure to do
scratch builds or mock builds of packages under review to make sure they build.
:)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

   Flag||fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #10 from Erik van Pienbroek erik-fed...@vanpienbroek.nl  
2009-06-06 11:01:58 EDT ---
rpmlint gives a new warning as of the last release:
 mingw32-libtiff.src:80: W: macro-in-%changelog define

To fix this, you need to escape the macro in the changelog. This can be done by
changing the changelog entry from:
 * Fri Jun 5 2009 Michael Ploujnikov plo...@gmail.com - 3.8.2-15
 - replace %define with %global as per Fedora packaging guidelines
to:
 * Fri Jun 5 2009 Michael Ploujnikov plo...@gmail.com - 3.8.2-15
 - replace %%define with %%global as per Fedora packaging guidelines

Please fix this before importing the package in CVS

=

 The package mingw32-libtiff is APPROVED by epienbro

=

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Michael Ploujnikov plo...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #11 from Michael Ploujnikov plo...@gmail.com  2009-06-06 11:31:37 
EDT ---
New Package CVS Request
===
Package Name: mingw32-libtiff
Short Description: MinGW Windows port of the LibTIFF library
Owners: plouj
Branches: F-10 F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #8 from Erik van Pienbroek erik-fed...@vanpienbroek.nl  
2009-06-05 13:07:43 EDT ---
Just one small thing needs to be changed. The %define needs to be changed to
%global (see
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
for details)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #9 from Michael Ploujnikov plo...@gmail.com  2009-06-05 17:55:25 
EDT ---
Fixed in:

http://plouj.com/rpmbuild/SPECS/mingw32-libtiff.spec
http://plouj.com/rpmbuild/SRPMS/mingw32-libtiff-3.8.2-15.fc10.src.rpm

$ rpmlint /home/plouj/rpmbuild/SRPMS/mingw32-libtiff-3.8.2-15.fc10.src.rpm
/home/plouj/rpmbuild/RPMS/noarch/mingw32-libtiff-3.8.2-15.fc10.noarch.rpm
mingw32-libtiff.src:80: W: macro-in-%changelog define
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffconf.h
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiff.h
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffio.h
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffvers.h
mingw32-libtiff.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.la
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a
mingw32-libtiff.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a
mingw32-libtiff.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.la
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a
mingw32-libtiff.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffio.hxx
mingw32-libtiff.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a
mingw32-libtiff.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a
mingw32-libtiff.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
2 packages and 0 specfiles checked; 4 errors, 11 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #5 from Adam Goode a...@spicenitz.org  2009-06-03 10:34:02 EDT ---
Ping? I really would like to see this package in.

Michael, if you are too busy, I'd be happy to be the maintainer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #6 from Michael Ploujnikov plo...@gmail.com  2009-06-03 11:25:58 
EDT ---
I'm sorry. I was so busy that I forgot I submitted this package. I was still
reading the e-mails, but thinking that they were directed to someone else. I
have time now, and I'll submit an update tonight.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #7 from Michael Ploujnikov plo...@gmail.com  2009-06-03 21:31:16 
EDT ---
Updated spec and srpm:

http://plouj.com/rpmbuild/SPECS/mingw32-libtiff.spec
http://plouj.com/rpmbuild/SRPMS/mingw32-libtiff-3.8.2-14.fc10.src.rpm

rpmlint output:
$ rpmlint /home/plouj/rpmbuild/SRPMS/mingw32-libtiff-3.8.2-14.fc10.src.rpm
/home/plouj/rpmbuild/RPMS/noarch/mingw32-libtiff-3.8.2-14.fc10.noarch.rpm
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffconf.h
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiff.h
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffio.h
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffvers.h
mingw32-libtiff.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.la
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a
mingw32-libtiff.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a
mingw32-libtiff.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.la
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a
mingw32-libtiff.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a
mingw32-libtiff.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/tiffio.hxx
mingw32-libtiff.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a
mingw32-libtiff.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a
mingw32-libtiff.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
2 packages and 0 specfiles checked; 4 errors, 10 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Adam Goode a...@spicenitz.org changed:

   What|Removed |Added

 CC||a...@spicenitz.org




--- Comment #2 from Adam Goode a...@spicenitz.org  2009-06-02 16:54:40 EDT ---
The original libtiff specfile has a lot of unnecessary stuff for mingw32. I
just did one, it is attached. There is no need for executables, multilib, or
documentation in the mingw32 version of libtiff.

Please feel free to take this specfile and alter the changelog with your name,
if you like. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #3 from Adam Goode a...@spicenitz.org  2009-06-02 16:55:11 EDT ---
Created an attachment (id=346315)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=346315)
new specfile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501





--- Comment #4 from Adam Goode a...@spicenitz.org  2009-06-02 16:57:10 EDT ---
Also, in your version, the strict aliasing flag isn't working. The correct way
to do it is in my specfile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-05-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||erik-fed...@vanpienbroek.nl
 AssignedTo|nob...@fedoraproject.org|erik-fed...@vanpienbroek.nl




--- Comment #1 from Erik van Pienbroek erik-fed...@vanpienbroek.nl  
2009-05-09 08:29:13 EDT ---
Let's take this package for review.

- The %define LIBVER can be dropped as it isn't being used elsewhere in the
.spec file
- The 'make check' part doesn't belong in the %build phase, but in a seperate
%check phase.
- Does 'LD_LIBRARY_PATH=$PWD:$LD_LIBRARY_PATH make check' even work? The
LD_LIBRARY_PATH variable is only necessary for native libraries, so it doesn't
have any effect on MinGW packages. (I haven't build and tested the package
myself yet)
- The libtool .la files are required for proper operation on MinGW, so these
don't need to be removed
- The multilib stuff isn't required as we only support 32bit environments. It
can all be dropped
- Why does the defattr line contain the value '0755' ? Normally it should be
%defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library

2009-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492501


Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 CC||rjo...@redhat.com
 Depends on||454410(mingw32-gcc)
  Alias||mingw32-libtiff




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review