[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-04-09 12:15:07 EDT --- libmkv-0.6.3.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.6.3.1-2.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-04-07 22:39:44 EDT --- libmkv-0.6.3.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libmkv-0.6.3.1-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-04-06 23:25:17 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Xavier Bachelot xav...@bachelot.org 2009-04-03 09:22:52 EDT --- You can go ahead with the cvs request, I've already approved the package. One last comment, you may want to delete the .la file in the %install section rather than excluding it in the %files section, but it doesn't really matter. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 Bernard Johnson bjohn...@symetrix.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Bernard Johnson bjohn...@symetrix.com 2009-04-03 23:17:09 EDT --- Here lately I've been liking using %exclude rather than a rm in the spec. Thanks again for the review. New Package CVS Request === Package Name: libmkv Short Description: An alternative to the official libmatroska library Owners: bjohnson Branches: F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492831 --- Comment #2 from Bernard Johnson bjohn...@symetrix.com 2009-04-03 00:11:21 EDT --- Thanks Xavier * Thu Apr 02 2009 Bernard Johnson bjohn...@symetrix.com - 0.6.3.1-2 - remove slashes in %%files list - configure with --disable-static Spec URL: http://fedorapeople.org/~bjohnson/libmkv.spec SRPM URL: http://fedorapeople.org/~bjohnson/libmkv-0.6.3.1-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492831
Xavier Bachelot xav...@bachelot.org changed:
What|Removed |Added
CC||xav...@bachelot.org
AssignedTo|nob...@fedoraproject.org|xav...@bachelot.org
Flag||fedora-review+
--- Comment #1 from Xavier Bachelot xav...@bachelot.org 2009-04-01 18:08:12
EDT ---
+ MUST: rpmlint output is ok. The only warning can be ignored :
libmkv-devel.i386: W: no-documentation
+ MUST: package name follows guidelines.
+ MUST: Spec file name is ok.
+ MUST: The package must meet the Packaging Guidelines.
+ MUST: License is ok for Fedora.
+ MUST: License field mactch actual license.
+ MUST: License file is included in %doc
+ MUST: Spec file in legible American English.
+ MUST: Source file match upstream. MD5 : 984575069cbfb47dece609e78768ca97
+ MUST: builds fine on F10 i386 in mock.
+ MUST: BuildRequires are ok.
+ MUST: ldconfig is used in %post and %postun.
+ MUST: owns all dirs it creates.
+ MUST: No file listed more than once in %files.
+ MUST: Permissions on files are appropriate. %defattr is properly used.
+ MUST: %clean section contains rm -rf $RPM_BUILD_ROOT).
+ MUST: Macros are used consistently.
+ MUST: code, not content.
+ MUST: %doc not needed at runtime.
+ MUST: Header files are in a -devel package.
+ MUST: .so libfile in -devel.
+ MUST: -devel package requires base package.
+ MUST: .la libtool archives are not included.
+ MUST: doesn't own files or directories already owned by other packages.
+ MUST: %install begins with rm -rf $RPM_BUILD_ROOT.
+ MUST: All filenames are valid UTF-8.
Notes :
- Theses backslashes are un-needed : %{_libdir}/libmkv\.so\.*. This should be
fixed.
- You can prevent libmkv.a to be built by adding --disable-static to
%configure.
- URL: and Source0: urls are strange, but I don't think you can do any better
unfortunately.
Please fix the backslashes, then this package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
