[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #22 from Fedora Update System upda...@fedoraproject.org  
2009-05-26 03:52:23 EDT ---
xcowsay-1.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|1.1-1.fc10  |1.1-1.fc11




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version||1.1-1.fc10




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #21 from Fedora Update System upda...@fedoraproject.org  
2009-05-25 17:21:12 EDT ---
xcowsay-1.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE




--- Comment #20 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-05-09 
12:43:51 EDT ---
Now closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #19 from Fedora Update System upda...@fedoraproject.org  
2009-05-09 00:09:34 EDT ---
xcowsay-1.1-1.fc11 has been pushed to the Fedora 11 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xcowsay'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4473

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #18 from Fedora Update System upda...@fedoraproject.org  
2009-05-06 19:26:35 EDT ---
xcowsay-1.1-1.fc10 has been pushed to the Fedora 10 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xcowsay'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4255

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #16 from Fedora Update System upda...@fedoraproject.org  
2009-05-04 14:03:38 EDT ---
xcowsay-1.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/xcowsay-1.1-1.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #17 from Fedora Update System upda...@fedoraproject.org  
2009-05-04 14:41:01 EDT ---
xcowsay-1.1-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/xcowsay-1.1-1.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #15 from Kevin Fenzi ke...@tummy.com  2009-05-03 23:39:45 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Fabien Georget fabien.geor...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #14 from Fabien Georget fabien.geor...@gmail.com  2009-05-02 
02:01:14 EDT ---
New Package CVS Request
===
Package Name: xcowsay
Short Description: xcowsay displays a cute cow and message on your desktop 
Owners: manawy
Branches: F-10 F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #10 from Fabien Georget fabien.geor...@gmail.com  2009-05-01 
08:27:42 EDT ---
(In reply to comment #9)

  Please follow the procedure written on:
  http://fedoraproject.org/wiki/PackageMaintainers/Join
  from Get a Fedora Account.
  After you request for sponsorship a mail will be sent to sponsor 
  members automatically (which is invisible for you) which notifies 
  that you need a sponsor. After that, please also write on
  this bug for confirmation that you requested for sponsorship and
  your FAS (Fedora Account System) name. Then I will sponsor you.
 
 I apply to the packager group.
 

Sorry, I forgot to give my login : It is manawy.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-05-01 
09:33:28 EDT ---
(In reply to comment #10)
 Sorry, I forgot to give my login : It is manawy.  

Well, the email used in your account on FAS differs from
what is used on this bugzilla, which must coincide.
Please change either of them, then I will sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #12 from Fabien Georget fabien.geor...@gmail.com  2009-05-01 
14:28:26 EDT ---
(In reply to comment #11)
 (In reply to comment #10)
  Sorry, I forgot to give my login : It is manawy.  
 
 Well, the email used in your account on FAS differs from
 what is used on this bugzilla, which must coincide.
 Please change either of them, then I will sponsor you.  

Sorry, I didn't pay attention to that point. (too many e-mails !)

So :
Account name : manawy
Email : fabien.georget*at*gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |




--- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-05-01 
14:43:27 EDT ---
Okay, now I am sponsoring you. Please follow
Join wiki again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #7 from Fabien Georget fabien.geor...@gmail.com  2009-04-30 
10:56:19 EDT ---
(In reply to comment #6)
 By the way from next time please change the release number
 every time you modify your spec file to aviod confusion.  

Of course :/ sorry !

I discover an interesting package in review request, so I start a pre-review :
https://bugzilla.redhat.com/show_bug.cgi?id=498246

I think I need more time to read review done by others people to understand
some points.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-04-30 
11:49:15 EDT ---
Okay.
- Your pre-review seems good for initial comments
- This package itself is okay.
 _ 
 This package is approved by mtasaka 
 - 
\   ^__^
 \  (oo)\___
(__)\   )\/\
||w |
|| ||

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from Get a Fedora Account.
After you request for sponsorship a mail will be sent to sponsor 
members automatically (which is invisible for you) which notifies 
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 9/10/11, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #9 from Fabien Georget fabien.geor...@gmail.com  2009-04-30 
12:50:16 EDT ---
(In reply to comment #8)
 Okay.
 - Your pre-review seems good for initial comments
 - This package itself is okay.
  _ 
  This package is approved by mtasaka 
  - 
 \   ^__^
  \  (oo)\___
 (__)\   )\/\
 ||w |
 || ||


Thanks :) 

 Please follow the procedure written on:
 http://fedoraproject.org/wiki/PackageMaintainers/Join
 from Get a Fedora Account.
 After you request for sponsorship a mail will be sent to sponsor 
 members automatically (which is invisible for you) which notifies 
 that you need a sponsor. After that, please also write on
 this bug for confirmation that you requested for sponsorship and
 your FAS (Fedora Account System) name. Then I will sponsor you.

I apply to the packager group.

 If you want to import this package into Fedora 9/10/11, you also have
 to look at
 http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
 (after once you rebuilt this package on koji Fedora rebuilding system).

I will take a look at this tomorrow.

 If you have questions, please ask me.

Thanks again for helping and sponsoring me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-04-29 
13:13:01 EDT ---
Now this package itself is okay. So as I wrote in comment 3,
I will wait for your another review request or your pre-review
of other person's review request.

(In reply to comment #4)
 But I have a question about the files section : Are we allowed (encouraged ?)
 to not include all files that we don't think it is necessary ? 

Yes. Removing unneeded files is always recommended (here it doesn't mean
that unneeded files should be removed from the source tarball
itself)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-04-29 
13:39:53 EDT ---
By the way from next time please change the release number
every time you modify your spec file to aviod confusion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #4 from Fabien Georget fabien.geor...@gmail.com  2009-04-28 
14:57:18 EDT ---
I have updated the package :

Spec URL: http://www.bde.espci.fr/~george27/xcowsay.spec
SRPM URL: http://www.bde.espci.fr/~george27/xcowsay-1.1-1.fc11.src.rpm

But I have a question about the files section : Are we allowed (encouraged ?)
to not include all files that we don't think it is necessary ? 

I will take a look on review Guidelines. Thank you for this advice.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?




--- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-04-27 
14:02:55 EDT ---
Some notes:

* SourceURL
  - Please consider to use %{version} macro on %SOURCE0.
In this way you probably won't have to rewrite Source0
when version is upgraded:
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* BuildRequires
  - BR: dbus-devel is redundant because dbus-glib-devel has
Requires: dbus-devel.

* Documents
  - INSTALL file is usually for people who want to build/compile
packages by themselves and not needed for rpm users
  - And ABOUT-NLS is almost no related to this package (this
shows general information for translating).

Then:
-
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to show that you have an understanding 
of the process and of the packaging guidelines as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a pre-review of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on my wiki page:
http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets
(Check No one is reviewing)

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927





--- Comment #2 from Fabien Georget fabien.geor...@gmail.com  2009-04-19 
05:07:26 EDT ---
Thanks a lot

I modified the spec according to your advice :
Spec URL: http://www.bde.espci.fr/~george27/xcowsay.spec
SRPM URL: http://www.bde.espci.fr/~george27/xcowsay-1.1-1.fc11.src.rpm

For point 6, I only create a .desktop file for xcowfortune since the others
need an argument (the message, or the image, to display)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-04-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Ivan Efremov iefre...@unipro.ru changed:

   What|Removed |Added

 CC||iefre...@unipro.ru




--- Comment #1 from Ivan Efremov iefre...@unipro.ru  2009-04-14 04:27:00 EDT 
---
It's only 'pre-review' since I can't be a sponsor.

1) license should be 'GPLv3+' (according to headers in source files)

2) why do you use 'pre-release' Release tag? consider changing 0.1 - 1
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release

3) consider writing more detailed description

4) preserving timestamps: your Makefile must preserve timestamps using 'install
-p'
http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 

5) your package doesn't own the directory '%{_datadir}/xcowsay/', see
http://fedoraproject.org/wiki/Packaging/UnownedDirectories

6) note about desktop file:
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.

7) consider adding man pages describing other binaries than xcowsay: xcowdream,
xcowthink etc.

Good luck!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 492927] Review Request: xcowsay - xcowsay displays a cute cow and message

2009-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492927


Fabien Georget fabien.geor...@gmail.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review