[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-05-09 00:13:05 EDT --- perl-JSON-RPC-Common-0.03-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.03-3.fc10 |0.03-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-05-09 00:24:18 EDT --- perl-JSON-RPC-Common-0.03-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.03-3.fc9 |0.03-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Christian Krause c...@plauener.de changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #10 from Christian Krause c...@plauener.de 2009-05-06 04:11:41 EDT --- Package Change Request == Package Name: perl-JSON-RPC-Common New Branches: F-9 Owners: chkr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-05-06 17:04:25 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-05-06 18:09:34 EDT --- perl-JSON-RPC-Common-0.03-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-JSON-RPC-Common-0.03-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-05-06 19:29:30 EDT --- perl-JSON-RPC-Common-0.03-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.03-3.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-05-04 04:17:15 EDT --- perl-JSON-RPC-Common-0.03-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-JSON-RPC-Common-0.03-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-05-04 04:18:47 EDT --- perl-JSON-RPC-Common-0.03-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-JSON-RPC-Common-0.03-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498324
--- Comment #2 from Christian Krause c...@plauener.de 2009-05-01 05:56:34
EDT ---
(In reply to comment #1)
Alright, here is the review. Nothing serious:
Thank you very much for the review!
! Please make the description span 80 columns evenly (as much as possible)
Done.
! The file Changes can be packaged as %doc
Done.
! There is no information about the license except at the end of the
lib/JSON/RPC/Common.pm file. Could you advise upstream for putting a COPYING
file into the tarball and adding headers that contain license information to
the source files?
Yes, I've mailed upstream. The author replied that he'll have a look at this.
! It looks like these BR's can be removed:
BuildRequires: perl(Moose)
BuildRequires: perl(namespace::clean)
The package builds fine without them. The other packages pull them in so they
don't cause any harm. I'll leave this up to you.
Done, I've removed them.
* Packages must not own files or directories already owned by other packages.
I
don't think this package should own %{perl_vendorlib}/JSON/ . It should own
%{perl_vendorlib}/JSON/RPC instead. Ownership of %{perl_vendorlib}/JSON/ will
be satisfied by rpm's automatic dependency generation.
Done.
new package:
Spec URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common.spec
SRPM URL:
http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common-0.03-2.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-05-01 11:25:49 EDT --- Thanks. But now we have the rpmlints: perl-JSON-RPC-Common.src: E: description-line-too-long objects to convert the model objects into JSON text and HTTP requests/responses. perl-JSON-RPC-Common.src:54: W: macro-in-%changelog doc perl-JSON-RPC-Common.src:56: W: macro-in-%changelog perl_vendorlib Please fix these. Also, running rpmlint on the SPEC and SRPM files after you're done editing is a good idea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 --- Comment #4 from Christian Krause c...@plauener.de 2009-05-01 15:37:41 EDT --- (In reply to comment #3) Please fix these. Also, running rpmlint on the SPEC and SRPM files after you're done editing is a good idea. Sure, your're right. Here are the new packages: Spec URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common.spec SRPM URL: http://chkr.fedorapeople.org/review/perl-JSON-RPC-Common-0.03-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-05-01 15:50:08 EDT --- Great. Thanks! --- This package (perl-JSON-RPC-Common) is APPROVED by oget --- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Christian Krause c...@plauener.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Christian Krause c...@plauener.de 2009-05-01 15:58:40 EDT --- New Package CVS Request === Package Name: perl-JSON-RPC-Common Short Description: Perl module for handling JSON-RPC objects Owners: chkr Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498324 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Dennis Gilmore den...@ausil.us 2009-05-01 16:55:13 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498324] Review Request: perl-JSON-RPC-Common - Perl module for handling JSON-RPC objects
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498324
Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review?
--- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-29
21:53:49 EDT ---
Alright, here is the review. Nothing serious:
! Please make the description span 80 columns evenly (as much as possible)
! The file Changes can be packaged as %doc
! There is no information about the license except at the end of the
lib/JSON/RPC/Common.pm file. Could you advise upstream for putting a COPYING
file into the tarball and adding headers that contain license information to
the source files?
! It looks like these BR's can be removed:
BuildRequires: perl(Moose)
BuildRequires: perl(namespace::clean)
The package builds fine without them. The other packages pull them in so they
don't cause any harm. I'll leave this up to you.
* Packages must not own files or directories already owned by other packages. I
don't think this package should own %{perl_vendorlib}/JSON/ . It should own
%{perl_vendorlib}/JSON/RPC instead. Ownership of %{perl_vendorlib}/JSON/ will
be satisfied by rpm's automatic dependency generation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
