[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-05-26 03:52:03 EDT --- wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc11, wordpress-plugin-add-to-any-0.9.9.2.3-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.9.6.4.1-1.fc11 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.9.6.4.1-1.fc11|0.9.6.4.1-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-05-26 03:56:36 EDT --- wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc10, wordpress-plugin-add-to-any-0.9.9.2.3-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2009-05-24 22:31:54 EDT --- wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc11,wordpress-plugin-add-to-any-0.9.9.2.3-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc11,wordpress-plugin-add-to-any-0.9.9.2.3-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2009-05-24 22:31:44 EDT --- wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc10,wordpress-plugin-add-to-any-0.9.9.2.3-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc10,wordpress-plugin-add-to-any-0.9.9.2.3-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 Ian Weller i...@ianweller.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Ian Weller i...@ianweller.org 2009-05-09 12:34:20 EDT --- Thanks David. New Package CVS Request === Package Name: wordpress-plugin-add-to-any-subscribe Short Description: Add to Any Subscribe Button plugin for WordPress Owners: ianweller Branches: F-11 F-10 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-05-09 16:58:06 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498363
David Nalley da...@gnsa.us changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from David Nalley da...@gnsa.us 2009-05-06 07:47:30 EDT ---
OK: rpmlint must be run on every package. The output should be posted in the
review.
[ke4...@nalleyt61 rpmbuild]$ rpmlint
SPECS/wordpress-plugin-add-to-any-subscribe.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4...@nalleyt61 rpmbuild]$ rpmlint
SRPMS/wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4...@nalleyt61 rpmbuild]$ rpmlint
RPMS/noarch/wordpress-plugin-add-to-any-subscribe-
wordpress-plugin-add-to-any-subscribe-0.9.6.4.1-1.fc10.noarch.rpm
wordpress-plugin-add-to-any-subscribe-i18n-0.9.6.4.1-1.fc10.noarch.rpm
[ke4...@nalleyt61 rpmbuild]$ rpmlint
RPMS/noarch/wordpress-plugin-add-to-any-subscribe*
wordpress-plugin-add-to-any-subscribe.noarch: W: dangling-symlink
/usr/share/wordpress/wp-content/plugins/add-to-any-subscribe/i18n/add-to-any-subscribe.mo
/usr/share/locale/en/LC_MESSAGES/wordpress-plugin-add-to-any-subscribe.mo
wordpress-plugin-add-to-any-subscribe.noarch: W: dangling-symlink
/usr/share/wordpress/wp-content/plugins/add-to-any-subscribe/i18n/add-to-any-subscribe-da_DK.mo
/usr/share/locale/da_DK/LC_MESSAGES/wordpress-plugin-add-to-any-subscribe.mo
wordpress-plugin-add-to-any-subscribe.noarch: W: dangling-symlink
/usr/share/wordpress/wp-content/plugins/add-to-any-subscribe/i18n/add-to-any-subscribe-zh_CN.mo
/usr/share/locale/zh_CN/LC_MESSAGES/wordpress-plugin-add-to-any-subscribe.mo
wordpress-plugin-add-to-any-subscribe.noarch: W: file-not-in-%lang
/usr/share/wordpress/wp-content/plugins/add-to-any-subscribe/i18n/add-to-any-subscribe-da_DK.mo
wordpress-plugin-add-to-any-subscribe.noarch: W: file-not-in-%lang
/usr/share/wordpress/wp-content/plugins/add-to-any-subscribe/i18n/add-to-any-subscribe-zh_CN.mo
wordpress-plugin-add-to-any-subscribe.noarch: W: file-not-in-%lang
/usr/share/wordpress/wp-content/plugins/add-to-any-subscribe/i18n/add-to-any-subscribe.mo
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
The errors are expected and documented in the spec file.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
Appears to be GPLv3 See more information below.
FIX: The License field in the package spec file must match the actual license.
The website you reference in the spec does indeed say that the files and
content are licensed under the GPL and then links to a copy of GPLv3. However
the license linked is not GPLv3+.
I trust this is something that you can fix before it hits CVS.
NA: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
02049bf88fa2b594dce643e1842b5aea add-to-any-subscribe.0.9.6.4.1.zip
02049bf88fa2b594dce643e1842b5aea add-to-any-subscribe.0.9.6.4.1.zip.1
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
At least works on x86_64, though since it's a noarch package should work
anywhere.
NA: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 David Nalley da...@gnsa.us changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498363] Review Request: wordpress-plugin-add-to-any-subscribe - Add to Any Subscribe Button plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498363 Ian Weller i...@ianweller.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|da...@gnsa.us -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
