[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||2.26.1-2.fc11 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-05-25 17:16:07 EDT --- mingw32-libsoup-2.26.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-05-24 08:56:34 EDT --- mingw32-libsoup-2.26.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-libsoup-2.26.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 Thomas Sailer t.sai...@alumni.ethz.ch changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t.sai...@alumni.ethz.ch Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499983
Thomas Sailer t.sai...@alumni.ethz.ch changed:
What|Removed |Added
CC||t.sai...@alumni.ethz.ch
--- Comment #1 from Thomas Sailer t.sai...@alumni.ethz.ch 2009-05-22
06:54:53 EDT ---
Fedora review
http://www.ftd4linux.nl/contrib/mingw32-libsoup-2.26.1-1.fc11.src.rpm
2009-05-22
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1370211
rpmlint output:
$ rpmlint mingw32-libsoup*
mingw32-libsoup.src: W: invalid-license LPLv2
mingw32-libsoup.src: W: mixed-use-of-spaces-and-tabs (spaces: line 43, tab:
line 7)
mingw32-libsoup.noarch: W: invalid-license LPLv2
mingw32-libsoup.src: W: invalid-license LPLv2
mingw32-libsoup.src: W: mixed-use-of-spaces-and-tabs (spaces: line 43, tab:
line 7)
mingw32-libsoup.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 43, tab:
line 7)
mingw32-libsoup-static.noarch: W: invalid-license LPLv2
mingw32-libsoup-static.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libsoup-2.4.a
mingw32-libsoup-static.noarch: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 8 warnings.
As per Packaging/MinGW, these errors can be ignored, except for the
mixed-use-of-spaces-and-tabs.
+ OK
! needs attention
+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
version seems to be slightly ahead of native (1.1 vs. 1.0) please try to
stick to the native version
+ License meets guidelines and is acceptable to Fedora
LGPLv2
! License matches the actual package license
Presumably LPLv2 is a typo, should be LGPLv2
It is also the same as in the corresponding Fedora libsoup package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
! Please fix the tabs-vs-spaces issue
+ Upstream sources match sources in the srpm
94c0495dc8bf213709bdb175ab224c7e libsoup-2.26.1.tar.bz2
94c0495dc8bf213709bdb175ab224c7e x/libsoup-2.26.1.tar.bz2
n/a Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
+ Static libraries should be in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! use %global instead of %define
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 --- Comment #2 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2009-05-22 09:11:45 EDT --- Spec URL: http://www.ftd4linux.nl/contrib/mingw32-libsoup.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-libsoup-2.26.1-2.fc11.src.rpm * Fri May 22 2009 Erik van Pienbroek epien...@fedoraproject.org - 2.26.1-2 - Fixed license typo - Use %%global instead of %%define - Fixed mixed-use-of-spaces-and-tabs rpmlint warning -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 --- Comment #3 from Thomas Sailer t.sai...@alumni.ethz.ch 2009-05-22 09:57:02 EDT --- APPROVED by sailer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 Thomas Sailer t.sai...@alumni.ethz.ch changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2009-05-22 11:13:14 EDT --- New Package CVS Request === Package Name: mingw32-libsoup Short Description: MinGW library for HTTP and XML-RPC functionality Owners: epienbro rjones Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-05-23 01:38:05 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499983] Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499983 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Blocks||42 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
