[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 --- Comment #1 from Parag AN(पराग) 2009-05-29 00:00:45 EDT --- hmm. Build failed with error File not found by glob: /builddir/build/BUILDROOT/python-line_profiler-1.0-0.1.b2.fc12.i386/usr/bin/kernprof.py[co] see http://koji.fedoraproject.org/koji/taskinfo?taskID=1382215 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502978
--- Comment #2 from Silas Sewell 2009-05-30 15:21:41 EDT ---
I'm not sure the correct way to fix this, Koji doesn't create the pyc and pyo
files in bindir, but mock still does.
The documentation (
https://fedoraproject.org/wiki/Packaging/Python#Unnecessary_Byte_compilation )
recommends using the exclude, but as you've seen this breaks Koji builds.
I removed the exclude from the package above, but it will have the unnecessary
glob in the files' bindir (ex: %{_bindir}/kernprof.py*) and if you build with
mock the .pyc and .pyo files will be in the bindir along with the following
warnings.
rpmlint
[si...@silas rpmbuild]$ rpmlint /var/lib/mock/fedora-10-i386/result/*.rpm
python-line_profiler.i386: W: non-executable-in-bin /usr/bin/kernprof.pyc 0644
python-line_profiler.i386: W: non-executable-in-bin /usr/bin/kernprof.pyo 0644
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
SPEC Diff:
http://code.google.com/p/silassewell/source/diff?spec=svn280&r=280&format=side&path=/trunk/projects/packages/rpms/python-line_profiler/python-line_profiler.spec
SRPM URL:
http://silassewell.googlecode.com/files/python-line_profiler-1.0-0.2.b2.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502978
--- Comment #3 from Parag AN(पराग) 2009-06-01 00:53:46
EDT ---
I think you can even follow suggestion given on that guidelines page
1. Rename scripts in %{_bindir} to not have a .py extension: For instance, from
/usr/bin/orient.py to /usr/bin/orient.
This will clean rpmlint output.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 --- Comment #4 from Silas Sewell 2009-06-01 23:25:15 EDT --- Generally I don't like to rename stuff like this because it can break tutorials and such, but this is probably fine. SRPM Url: http://silassewell.googlecode.com/files/python-line_profiler-1.0-0.3.b2.fc10.src.rpm SPEC Diff: http://code.google.com/p/silassewell/source/diff?spec=svn281&r=281&format=side&path=/trunk/projects/packages/rpms/python-line_profiler/python-line_profiler.spec rpmlint [si...@silas rpmbuild]$ rpmlint /var/lib/mock/fedora-10-i386/result/*.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 Parag AN(पराग) changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) 2009-06-02 23:53:09 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1389114 + rpmlint is silent for SRPM and for RPM. + source files match upstream url c509b763c0d2fe8df1c1b654bc4892c11bb7e83e line_profiler-1.0b2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application + Package python-line_profiler-1.0-0.3.b2.fc12.i586 => Provides: _line_profiler.so Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libpthread.so.0 libpython2.6.so.1.0 python(abi) = 2.6 rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 Silas Sewell changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Silas Sewell 2009-06-03 00:41:55 EDT --- Thanks for the review! New Package CVS Request === Package Name: python-line_profiler Short Description: A Python line-by-line profiler Owners: silas Branches: F11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Jason Tibbitts 2009-06-03 13:07:10 EDT --- Please note that the proper branch name is "F-11". CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 --- Comment #8 from Fedora Update System 2009-06-07 16:52:05 EDT --- python-line_profiler-1.0-0.3.b2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-line_profiler-1.0-0.3.b2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 Silas Sewell changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #9 from Silas Sewell 2009-06-07 16:55:20 EDT --- Built. Thanks Parag and Jason. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502978 --- Comment #10 from Fedora Update System 2009-06-15 22:42:03 EDT --- python-line_profiler-1.0-0.3.b2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
