[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||st...@lonetwin.net --- Comment #16 from Jussi Lehtola jussi.leht...@iki.fi 2009-07-04 19:54:26 EDT --- *** Bug 509673 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-06-15 22:00:34 EDT --- bastet-0.43-5.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:19:49 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-06-08 15:29:55 EDT --- bastet-0.43-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/bastet-0.43-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Stefan Posdzich cheekybo...@foresightlinux.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Tom spot Callaway tcall...@redhat.com 2009-06-06 09:46:54 EDT --- Good: - rpmlint checks return nothing. - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (1d7d42f93831b903e1fccee106a71c0bd4822c3d) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file okay, handled properly APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Stefan Posdzich cheekybo...@foresightlinux.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Stefan Posdzich cheekybo...@foresightlinux.org 2009-06-06 10:55:55 EDT --- New Package CVS Request === Package Name: bastet Short Description: An evil falling bricks game Owners: cheekyboinc Branches: F-10 F-11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #6 from Stefan Posdzich cheekybo...@foresightlinux.org 2009-06-05 10:11:56 EDT --- Spec URL: http://cheekyboinc.fedorapeople.org/bastet.spec SRPM URL: http://cheekyboinc.fedorapeople.org/bastet-0.43-4.fc11.src.rpm - Added new icon cache scriptlets - Added optflags - Changed license to GPLv3+ - Removed manually gzip of manpage Hope its all fixed now =) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2009-06-05 10:44:42 EDT --- Look closely at how you're passing optflags, and how I suggested you do it. Do a build and see if you can see the optflags being used. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503519
--- Comment #8 from Stefan Posdzich cheekybo...@foresightlinux.org
2009-06-05 13:18:52 EDT ---
CFLAGS=%{optflags}
+ make -j3 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic
-fasynchronous-unwind-tables'
vs.
CXXFLAGS=%{optflags}
+ make -j3 'CXXFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic
-fasynchronous-unwind-tables'
So whats the difference? :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #9 from Tom spot Callaway tcall...@redhat.com 2009-06-05 15:01:48 EDT --- Look at the gcc invocations. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #4 from Stefan Posdzich cheekybo...@foresightlinux.org 2009-06-04 06:29:43 EDT --- Spec URL: http://cheekyboinc.fedorapeople.org/bastet.spec SRPM URL: http://cheekyboinc.fedorapeople.org/bastet-0.43-3.fc11.src.rpm - Add manpage - Removed reference to Tetris in the bastet manpage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503519
Tom spot Callaway tcall...@redhat.com changed:
What|Removed |Added
Blocks|182235(FE-Legal)|
AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
Flag||fedora-review?
--- Comment #5 from Tom spot Callaway tcall...@redhat.com 2009-06-04
09:10:26 EDT ---
Trademark stuff looks good now, thanks.
A few other issues that need to be resolved:
* The License: should be GPLv3+ (look at the code headers).
* You're also not building it with %{optflags}. (passing CXXFLAGS=%{optflags}
to make should do the trick)
* You're also using the old icon cache scriptlets, see:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
* You do not need to manually gzip the manpage, just install it uncompressed
into the proper mandir and rpm will gzip it properly for you.
I think that fixing those items should be enough for me to finish the review.
Lifting FE-Legal.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 --- Comment #3 from Tom spot Callaway tcall...@redhat.com 2009-06-03 14:55:48 EDT --- You missed the manpage... but that looks like the only item that you missed. Clean it up and I'll lift FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Stefan Posdzich cheekybo...@foresightlinux.org changed: What|Removed |Added Summary|Review Request: bastet - An |Review Request: bastet - An |evil Tetris like game |evil falling bricks game --- Comment #2 from Stefan Posdzich cheekybo...@foresightlinux.org 2009-06-01 17:35:08 EDT --- Spec URL: http://cheekyboinc.fedorapeople.org/bastet.spec SRPM URL: http://cheekyboinc.fedorapeople.org/bastet-0.43-2.fc11.src.rpm - Removed reference to Tetris to match our guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
