[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||3.52.6-4.fc11 Resolution|RAWHIDE |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-06-15 21:48:56 EDT --- libiodbc-3.52.6-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-06-15 22:10:19 EDT --- libiodbc-3.52.6-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|3.52.6-4.fc11 |3.52.6-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-06-11 13:43:29 EDT --- libiodbc-3.52.6-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libiodbc-3.52.6-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Alias||libiodbc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-06-11 13:42:51 EDT --- libiodbc-3.52.6-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libiodbc-3.52.6-4.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Lorenzo Villani lvill...@binaryhelix.net changed: What|Removed |Added Blocks||502227 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE --- Comment #11 from Rex Dieter rdie...@math.unl.edu 2009-06-07 17:34:24 EDT --- imported, built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Lorenzo Villani lvill...@binaryhelix.net changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|lvill...@binaryhelix.net Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Lorenzo Villani lvill...@binaryhelix.net changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Lorenzo Villani lvill...@binaryhelix.net 2009-06-05 13:56:05 EDT --- - Capitalize tags: OK - rpmlint: spurious-executable-perm fixed. OK - Upstream sources: OK - .desktop file: the admin interface is busted.. no need to ship the .desktop file for now - OK I installed the package on F11 i586 with no problems. Ship it :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Rex Dieter rdie...@math.unl.edu 2009-06-05 15:44:41 EDT --- New Package CVS Request === Package Name: libiodbc Short Description: iODBC Driver Manager Owners: rdieter Branches: F-9 F-10 F-11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2009-06-05 17:29:38 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #2 from Kevin Kofler ke...@tigcc.ticalc.org 2009-06-04 11:46:09 EDT --- -L/usr/lib64 resp. -L/usr/lib can just be patched out, it's the default anyway. --static-libs and --libtool-libs should just be removed entirely. If software is trying to use them, then we can hack the script to just do the same as for --libs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #3 from Kevin Kofler ke...@tigcc.ticalc.org 2009-06-04 11:50:28 EDT --- Created an attachment (id=346558) -- (https://bugzilla.redhat.com/attachment.cgi?id=346558) libiodbc-3.52.6-multilib.patch This patch should work (apply with -p0). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2009-06-04 12:12:43 EDT --- cool, worksforme. Spec URL: http://rdieter.fedorapeople.org/rpms/libiodbc/libiodbc.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/libiodbc/libiodbc-3.52.6-2.fc11.src.rpm %changelog * Thu Jun 04 2009 Rex Dieter rdie...@fedoraproject.org 3.52.6-2 - iodbc-config multilib patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504076
Lorenzo Villani lvill...@binaryhelix.net changed:
What|Removed |Added
CC||lvill...@binaryhelix.net
--- Comment #5 from Lorenzo Villani lvill...@binaryhelix.net 2009-06-04
17:36:31 EDT ---
#
# MUST ITEMS
#
-- rpmlint must be run on every package. The output should be posted in the
review.
Status: *** FAIL ***
Additional comments: [lvill...@localhost Download]$ rpmlint
libiodbc-3.52.6-2.fc12.i586.rpm libiodbc-debuginfo-3.52.6-2.fc12.i586.rpm
libiodbc-devel-3.52.6-2.fc12.i586.rpm
libiodbc.i586: W: summary-not-capitalized iODBC Driver Manager
libiodbc-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/libiodbc-3.52.6/include/iodbcunix.h
libiodbc-devel.i586: W: summary-not-capitalized header files and libraries for
iODBC development
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
The first and the last line can be ignored, the package is called that way
I'm not sure about spurious-executable-perm in debuginfo package...
-- The package must be named according to the Package Naming Guidelines
Status: PASS
-- The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
Status: PASS
-- The package must meet the Packaging Guidelines
Status: PASS
-- The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
Status: PASS
-- The License field in the package spec file must match the actual license.
Status: PASS
-- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
Status: PASS
-- The spec file must be written in American English.
Status: PASS
-- The spec file for the package MUST be legible.
Status: PASS
-- The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Status: *** FAIL ***
Additional comments: [lvill...@localhost SPECS]$ md5sum
libiodbc-3.52.6.tar.gz ../SOURCES/libiodbc-3.52.6.tar.gz
761ad547467bd63ac0b2b4f3ee4b5afb libiodbc-3.52.6.tar.gz
e218721832e28fff0259bffa137626c1 ../SOURCES/libiodbc-3.52.6.tar.gz
-- The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Status: PASS
-- If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Status: PASS
-- All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
Status: PASS
-- The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
Status: PASS
-- Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker default paths, must call
ldconfig in %post and %postun.
Status: PASS
-- If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker.
Status: PASS
-- A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
Status: PASS
-- A Fedora package must not list a file more than once in the spec file's
%files listings.
Status: PASS
-- Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
Status: *** FAIL ***
Additional comments: See MUST item #1
-- Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
Status: PASS
-- Each package must consistently use macros.
Status: PASS
-- The package must contain code, or permissable content.
Status:
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #6 from Lorenzo Villani lvill...@binaryhelix.net 2009-06-04 17:38:02 EDT --- Can you also capitalize name, version and release tags please? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #7 from Rex Dieter rdie...@math.unl.edu 2009-06-04 19:15:49 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/libiodbc/libiodbc.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/libiodbc/libiodbc-3.52.6-3.fc11.src.rpm %changelog * Thu Jun 04 2009 Rex Dieter rdie...@fedoraproject.org 3.52.6-3 - capitalize Name,Summary,Version tags - -devel: capitalize Summary - fix spurious permissions on header files - refresh upstream source - -admin,-devel: add %%defattr(...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504076] Review Request: libiodbc - iODBC Driver Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504076 --- Comment #1 from Rex Dieter rdie...@math.unl.edu 2009-06-03 23:58:36 EDT --- NOTE: iodbc-config has issues, multilib conflicts, hard-coded references to unpackaged static libs, libtool archives. Not sure how best to address that... maybe rewrite to use pkg-config(?). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
