[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 --- Comment #13 from Fedora Update System 2009-07-11 13:33:55 EDT --- php-hkit-0.5-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 --- Comment #12 from Fedora Update System 2009-07-11 13:25:22 EDT --- php-hkit-0.5-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 --- Comment #10 from Fedora Update System 2009-07-07 08:46:29 EDT --- php-hkit-0.5-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-hkit-0.5-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 --- Comment #11 from Fedora Update System 2009-07-07 08:46:35 EDT --- php-hkit-0.5-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-hkit-0.5-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 --- Comment #9 from Patrick Monnerat 2009-07-02 12:49:03 EDT --- No php-hkit component in BZ yet. Thus I comment changes here: New version in rawhide: * Thu Jul 2 2009 Patrick Monnerat 0.5-3. - Move class files from /usr/share/php to /usr/share/php/hkit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 Patrick Monnerat changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Patrick Monnerat 2009-06-22 13:36:35 EDT --- Imported and built in rawhide. Will handle the subdirectory on a separate bug report. Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 Remi Collet changed: What|Removed |Added CC||fed...@famillecollet.com --- Comment #7 from Remi Collet 2009-06-19 01:39:13 EDT --- I really regret the use of /usr/share/php php-smpphp install in /usr/share/php/xmpphp php-oauth install in /usr/share/php/oauth ... I think we need a Guidelines about /usr/share/php usage. + -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Jason Tibbitts 2009-06-18 16:16:55 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 Patrick Monnerat changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Patrick Monnerat 2009-06-18 05:37:25 EDT --- Many thanks for the review, David. New Package CVS Request === Package Name: php-hkit Short Description: Simple PHP5 API for extracting common microformats from a page Owners: monnerat Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505358
David Nalley changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from David Nalley 2009-06-17 12:09:46 EDT ---
OK MUST: rpmlint must be run on every package. The output should be posted in
the review.
[ke4...@localhost SPECS]$ rpmlint ./php-hkit.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4...@localhost SPECS]$ rpmlint ../SRPMS/php-hkit-0.5-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4...@localhost SPECS]$ rpmlint ../RPMS/noarch/php-hkit-0.5-1.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK MUST: The package must be named according to the Package Naming Guidelines
.
OK MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. .
OK MUST: The package must meet the Packaging Guidelines .
OK MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
LGPLv2+
[] MUST: The License field in the package spec file must match the actual
license.
LGPLv2+ is cited in the class file, which maches what is in the spec
NA MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Not included.
OK MUST: The spec file must be written in American English.
OK MUST: The spec file for the package MUST be legible.
OK MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[ke4...@localhost SOURCES]$ md5sum hkit-v0.5.tgz*
37f3c192a94a86cd96770d53b3f22095 hkit-v0.5.tgz
37f3c192a94a86cd96770d53b3f22095 hkit-v0.5.tgz.1
OK MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
NA MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
NA MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
OK MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
OK MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
OK MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
OK MUST: Each package must consistently use macros.
OK MUST: The package must contain code, or permissable content.
OK MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
OK MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
NA MUST: Header files must be in a -devel package.
NA MUST: Static libraries must be in a -static package.
NA MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
NA MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 Ian Weller changed: What|Removed |Added CC||i...@ianweller.org --- Comment #3 from Ian Weller 2009-06-17 11:21:16 EDT --- David, Patrick is correct. Since the only installed files in /usr/share/php are: /usr/share/php/hcard.profile.php /usr/share/php/hkit.class.php those are the only files owned by this package. The key thing is that it does not own /usr/share/php, which is good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 --- Comment #2 from Patrick Monnerat 2009-06-17 11:03:17 EDT --- Yes ! That is: everything that is installed by this package. This notation does not concern components outside the current package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505358
--- Comment #1 from David Nalley 2009-06-17 10:56:45 EDT ---
%{_datadir}/php/*
You really want to own EVERYTHING in /usr/share/php/?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505358] Review Request: php-hkit - Simple PHP5 API for extracting common microformats from a page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505358 David Nalley changed: What|Removed |Added Status|NEW |ASSIGNED CC||da...@gnsa.us AssignedTo|nob...@fedoraproject.org|da...@gnsa.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
