[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Jussi Lehtola changed: What|Removed |Added Blocks|505154(FE-SCITECH) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Fedora Update System changed: What|Removed |Added Fixed In Version|0.4-4.fc10 |0.4-4.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #30 from Fedora Update System 2009-08-08 15:31:12 EDT --- xylib-0.4-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Fedora Update System changed: What|Removed |Added Fixed In Version||0.4-4.fc10 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #29 from Fedora Update System 2009-08-08 15:23:02 EDT --- xylib-0.4-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Mamoru Tasaka changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE --- Comment #28 from Mamoru Tasaka 2009-07-23 12:03:36 EDT --- Now closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #27 from Fedora Update System 2009-07-22 18:04:22 EDT --- xylib-0.4-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xylib'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7903 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #26 from Fedora Update System 2009-07-22 18:02:32 EDT --- xylib-0.4-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xylib'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7894 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #24 from Fedora Update System 2009-07-20 13:31:47 EDT --- xylib-0.4-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xylib-0.4-4.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #25 from Fedora Update System 2009-07-20 13:31:53 EDT --- xylib-0.4-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xylib-0.4-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #23 from Kevin Fenzi 2009-07-19 16:56:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Marcin Wojdyr changed: What|Removed |Added Flag||fedora-cvs? --- Comment #22 from Marcin Wojdyr 2009-07-18 14:20:56 EDT --- New Package CVS Request === Package Name: xylib Short Description: Library for reading x-y data from several file formats Owners: wojdyr Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #21 from Mamoru Tasaka 2009-07-18 10:24:17 EDT --- Okay, now I am sponsoring you. Please follow "Join" wiki again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #20 from Marcin Wojdyr 2009-07-17 18:39:09 EDT --- Thanks. I requested sponsorship. FAS name: wojdyr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Mamoru Tasaka changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #19 from Mamoru Tasaka 2009-07-16 09:21:23 EDT --- (In reply to comment #18) > I didn't do exactly what you asked yet, but today FTBFS bug was submitted for > fityk package, which I'm an upstream author. I made several changes to the > fityk spec and submitted a patch as an attachment 353890 [details] to bug > 511758. Ah, okay. -- This package (xylib) is APPROVED by mtasaka -- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". After you request for sponsorship a mail will be sent to sponsor members automatically (which is invisible for you) which notifies that you need a sponsor. After that, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 10/11, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #18 from Marcin Wojdyr 2009-07-15 16:07:54 EDT --- I didn't do exactly what you asked yet, but today FTBFS bug was submitted for fityk package, which I'm an upstream author. I made several changes to the fityk spec and submitted a patch as an attachment 353890 to bug 511758. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Matt Domsch changed: What|Removed |Added Blocks||511758 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #17 from Mamoru Tasaka 2009-07-15 12:41:04 EDT --- Okay. Then I will wait for your another review request or your pre-review of other person's review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #16 from Marcin Wojdyr 2009-07-15 07:08:17 EDT --- I added the missing Require: Spec URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib.spec SRPM URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib-0.4-4.fc11.src.rpm and will try to make another work soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #15 from Mamoru Tasaka 2009-07-09 13:13:34 EDT --- For -3: * Requires - -devel subpackage should have "Requires: boost-devel" because xylib/cache.h contains: 23 #if 0 24 #include 25 using std::tr1::shared_ptr; 26 #else 27 #include 28 using boost::shared_ptr; 29 #endif Then: - NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on my wiki page: http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets (Check "No one is reviewing") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Mamoru Tasaka changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #14 from Jussi Lehtola 2009-07-06 17:07:16 EDT --- btw on fedora-devel there has been a discussion raging on whether autotools files are OK to patch and rerun autotools vs hacking the preprocessed files manually, which is analogous to this matter. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #13 from Marcin Wojdyr 2009-07-06 14:58:05 EDT --- I changed the spec to avoid using automake. Spec URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib.spec SRPM URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib-0.4-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #12 from Marcin Wojdyr 2009-07-04 10:44:28 EDT --- (In reply to comment #11) > It's because it isn't supposed to be used that way. It defeats the whole > purpose of autotools: a simple(ish) way of configuring and building software > on > many platforms. Sorry, but do you really mean that using well-documented, portable libtool script "defeats the whole purpose of autotools"? It's much more elegant way than hacking Makefile.am and running autotools. If for some reasons using libtool is not recommended in fedora project (but I haven't seen such a statement in docs and there is a number of specs in fedora CVS that _are_ using libtool in this way), the second most portable way is to just call install. Marcin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507660
--- Comment #9 from Jussi Lehtola 2009-07-03 15:31:34
EDT ---
(In reply to comment #8)
> Thanks for looking at this rpm.
>
> The problem is with version mismatch of automake. Should I call libtool
> manually, like in the first version, i.e.
> ./libtool --mode=install install -m 755 xyconv $RPM_BUILD_ROOT%{_bindir}
>
> or rather run more autotools after changing Makefile.am?
The first option is of course to get upstream to change the makefile to install
the binary by default.
The second one is to run more autotools.
(The third one is requiring the necessary version of automake to build the
package. Automake 1.10 doesn't seem to be available on F12, though...)
Funny, I tried the build with F11 which has the same version of automake as
F12, so there shouldn't be any problem with that...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #11 from Jussi Lehtola 2009-07-03 16:09:39 EDT --- It's because it isn't supposed to be used that way. It defeats the whole purpose of autotools: a simple(ish) way of configuring and building software on many platforms. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #10 from Marcin Wojdyr 2009-07-03 16:04:01 EDT --- Jussi, I'm just wondering why changing Makefile.am is preferred to calling ./libtool --mode=install install ... The latter seems more portable to me. I couldn't find anything about it in Fedora guides. Marcin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507660
--- Comment #8 from Marcin Wojdyr 2009-07-03 15:06:44 EDT
---
Thanks for looking at this rpm.
The problem is with version mismatch of automake. Should I call libtool
manually, like in the first version, i.e.
./libtool --mode=install install -m 755 xyconv $RPM_BUILD_ROOT%{_bindir}
or rather run more autotools after changing Makefile.am?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Mamoru Tasaka changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #7 from Mamoru Tasaka 2009-07-03 13:54:41 EDT --- Your srpm does not build on dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1453152 By the way please make it sure that you change the release number of your spec file every time you modify your spec file (and post the URLs of new spec/srpm files) to avoid confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #6 from Marcin Wojdyr 2009-06-26 14:41:48 EDT --- Yes, I know about rpmlint, but the last time I checked only RPMs, not the spec. Updated spec and SRPM are in the same place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #5 from Jussi Lehtola 2009-06-26 14:19:10 EDT --- As you're a new packager you should learn to run rpmlint on your packages: https://fedoraproject.org/wiki/Packaging/Guidelines#Use_rpmlint You've written %defattr in the changelog, which may be expanded. rpmlint complains from this among other things. In the changelog you should use %% to prevent the macro from being expanded. rpmlint does sometimes generate noise, for instance it will comlain about the -devel package having no documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #4 from Marcin Wojdyr 2009-06-26 14:05:47 EDT --- I made all the changes you suggested above, with one exception: I kept gcc-g++ in BuildRequires, I hope it's not a problem. Thank you both. Spec URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib.spec SRPM URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib-0.4-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507660
--- Comment #3 from Jussi Lehtola 2009-06-26 06:07:14
EDT ---
- Don't call libtool manually. Remove the last three lines in %install, add
instead BuildRequires: automake and
sed -i "s|noinst_|bin_|g" Makefile.am
automake
to %setup, this will make the build process install xyconv to %{_bindir}.
- Use SMP make flags. Change
make
to
make %{?_smp_mflags}
- Change
%{_bindir}/*
to
%{_bindir}/xyconv
and
%{_includedir}/*
to
%{_includedir}/xylib/
(no sense in using wildcards in these cases)
- The attributes
%defattr(-,root,root)
should be
%defattr(-,root,root,-)
SHOULD: Use a more recommended version of the BuildRoot tag
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Jussi Lehtola changed: What|Removed |Added CC||jussi.leht...@iki.fi Blocks||505154 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #2 from Marcin Wojdyr 2009-06-23 15:48:49 EDT --- Hi Andrew, thanks for your comments. I added gcc-c++ to build the same RPM on OpenSuse Build Service. I know that it's not necessary (on Fedora), although it's not clear to me if having it is allowed or not. When I prepared this RPM I looked at a few other RPMS in Fedora. Some of them have "install -p" and some don't. I have no idea when it should be used, but I'll add it to the SPEC. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Andrew Colin Kissa changed: What|Removed |Added CC||and...@topdog.za.net --- Comment #1 from Andrew Colin Kissa 2009-06-23 15:24:26 EDT --- Hi Marcin, I am not able to sponsor your package but I can hopefully offer some useful help. * BuildRequires: gcc-c++ Is does not have to be declared - http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 * Timestamps You should consider using use of INSTALL="install -p" when you make install -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 Peter Lemenkov changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
