[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Fedora Update System changed: What|Removed |Added Fixed In Version|1.25-1.fc11 |1.25-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #14 from Fedora Update System 2009-07-22 17:55:27 EDT --- perl-Proc-Simple-1.25-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #13 from Fedora Update System 2009-07-22 17:54:55 EDT --- perl-Proc-Simple-1.25-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.25-1.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #11 from Fedora Update System 2009-07-17 16:35:53 EDT --- perl-Proc-Simple-1.25-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Proc-Simple-1.25-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #12 from Fedora Update System 2009-07-17 16:35:58 EDT --- perl-Proc-Simple-1.25-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Proc-Simple-1.25-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #10 from Liang Suilong 2009-07-14 23:22:26 EDT --- Please rebuild this package on koji and submit push requests on bodhi for F-10/11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Jason Tibbitts 2009-07-08 12:26:29 EDT --- We cannot create F-12 branches yet. It is way too early for that. Otherwise, CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Jan Klepek changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Jan Klepek 2009-07-07 07:48:43 EDT --- New Package CVS Request === Package Name: perl-Proc-Simple Short Description: Launch and control background processes Owners: hpejakle Branches: F-10 F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Lubomir Rintel changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Lubomir Rintel 2009-07-07 05:44:31 EDT --- Thank you Jan, seems fine now. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #6 from Liang Suilong 2009-07-04 02:27:19 EDT --- Ping? Does anyone continue to do package review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #5 from Jan Klepek 2009-06-28 11:47:03 EDT --- (In reply to comment #2) > 1.) Please remove Require: perl(Test::More) dependency, the runtime does not > depend on the testing framework. > - Fixed > 2.) Licensing > > Proc/Simple.pm contains this: > # This program is free software, you can redistribute it and/or > # modify it under the same terms as Perl itself. > > Neither README nor POD documentation contains it -- please ask upstream to > include the licensing conditions there. - fixed, upstream provided new version Spec URL: http://hpejakle.fedorapeople.org/packages/perl-Proc-Simple.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/perl-Proc-Simple-1.25-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507703
--- Comment #4 from Lubomir Rintel 2009-06-26 10:31:16 EDT ---
(In reply to comment #3)
> Jan Klepek
>
> 1) In my opinion, you maybe need to correct %file section. Because
> %{perl_vendorlib}/Proc would be owned by another packages like perl-Proc-*.
>
> I think these are better.
>
> %files
> %defattr(-,root,root,-)
> %doc Changes README
> %{perl_vendorlib}/Proc/*
> %{_mandir}/man3/*
This is not right -- that would leave an unowned %{perl_vendorlib}/Proc upon
removal of the package, which violates the guidelines. Sharing directories is
completely fine. Jan, please don't change that.
> 2) That BuildArch is noarch seems not to be suitable for it. As I see,
> building
> package for various architectures may be better than noarch. So I advise that
> BuildArch should be removed.
Wrong. There's nothing arch-specific in the package; it's definitely noarch.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507703
--- Comment #3 from Liang Suilong 2009-06-26 10:08:04
EDT ---
Jan Klepek
1) In my opinion, you maybe need to correct %file section. Because
%{perl_vendorlib}/Proc would be owned by another packages like perl-Proc-*.
I think these are better.
%files
%defattr(-,root,root,-)
%doc Changes README
%{perl_vendorlib}/Proc/*
%{_mandir}/man3/*
2) That BuildArch is noarch seems not to be suitable for it. As I see, building
package for various architectures may be better than noarch. So I advise that
BuildArch should be removed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #2 from Lubomir Rintel 2009-06-26 09:34:20 EDT --- 1.) Please remove Require: perl(Test::More) dependency, the runtime does not depend on the testing framework. 2.) Licensing Proc/Simple.pm contains this: # This program is free software, you can redistribute it and/or # modify it under the same terms as Perl itself. Neither README nor POD documentation contains it -- please ask upstream to include the licensing conditions there. * rpmlint is quiet * name is well according to the guidelines * source matches upstream * clean and legible SPEC file, American English * runs testsuite * builds file in mock * filelists, documentation ok Needs work: - sane provides/requires - license -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 --- Comment #1 from Jan Klepek 2009-06-23 16:18:23 EDT --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1432455 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507703 Jan Klepek changed: What|Removed |Added Blocks||493246 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
