[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #22 from Peter Robinson pbrobin...@gmail.com 2009-07-25 05:25:02 EDT --- And now in rawhide. Thanks for the review :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #20 from Jason Tibbitts ti...@math.uh.edu 2009-07-23 12:36:53 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #21 from Peter Robinson pbrobin...@gmail.com 2009-07-23 13:03:58 EDT --- Build in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1495451 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||513452 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Owen Taylor otay...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #18 from Owen Taylor otay...@redhat.com 2009-07-22 15:01:19 EDT --- The new spec file looks good to me. I tracked down the problem with the default plugin to: http://bugzilla.gnome.org/show_bug.cgi?id=589419 It just affects the default plugin (mutter --replace). gnome-shell and Moblin should work fine, so I'm not sure that it's necessary to put a patch into the package. It will be fixed next time we do a release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Peter Robinson pbrobin...@gmail.com 2009-07-22 16:55:58 EDT --- New Package CVS Request === Package Name: mutter Short Description: Window and compositing manager based on Clutter Owners: pbrobinson otaylor Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #16 from Peter Robinson pbrobin...@gmail.com 2009-07-18 09:48:17 EDT --- I think the following is the last bits that needed to be addressed Should be using desktop-file-install (the metacity package has desktop-file-install usage commented out, with a comment that the .desktop file is invalid, but mutter.desktop seems fine) As there's already a .desktop file for mutter we just need to run desktop-file-validate on it - FIXED. - Although it makes the specfile more complex, I think the check in metacity.spec: SHOULD_HAVE_DEFINED=HAVE_SM HAVE_XINERAMA HAVE_XFREE_XINERAMA HAVE_SHAPE HAVE_RANDR HAVE_STARTUP_NOTIFICATION for I in $SHOULD_HAVE_DEFINED; do if ! grep -q define $I config.h; then echo $I was not defined in config.h grep $I config.h exit 1 else echo $I was defined as it should have been grep $I config.h fi done Is probably worthwhile moving over. (And add HAVE_COMPOSITE_EXTENSION) FIXED. SPEC: http://pbrobinson.fedorapeople.org/mutter.spec SRPM: http://pbrobinson.fedorapeople.org/mutter-2.27.1-2.fc11.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1483821 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #17 from Peter Robinson pbrobin...@gmail.com 2009-07-18 10:02:33 EDT --- [??]* SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. Got a white screen in a quick test of 'mutter --replace', but it's a slightly old version of Mutter, so didn't investigate further. When testing this on my eeePC 901 I get a grey box in the top right of a white box which is in the top left of the screen. I'm not sure if this isn't just rawhide as it stands on my eeePC though as it has other rendering issues with the standard gnome desktop. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #13 from Peter Robinson pbrobin...@gmail.com 2009-07-17 10:18:03 EDT --- I've fixed most of these up. Having issues with this one: inclusion of those as BuildRequires is optional. Apply common sense. From reading the configure.in, missing BuildRequires I can find: gir-repository-devel It seems the gir-repository 0.6.3 clutter support is for clutter 0.8 [1] and hence the mutter build barfs on it [2]. A quick look through the git logs I don't see a g-i or gir commit for the support of the new clutter. [1] http://koji.fedoraproject.org/koji/getfile?taskID=1482119name=build.log [2] http://koji.fedoraproject.org/koji/getfile?taskID=1481571name=build.log Will update the rest with an updated spec shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #14 from Owen Taylor otay...@redhat.com 2009-07-17 11:30:46 EDT --- gir-repository-devel is needed for Gtk and (In reply to comment #13) I've fixed most of these up. Having issues with this one: inclusion of those as BuildRequires is optional. Apply common sense. From reading the configure.in, missing BuildRequires I can find: gir-repository-devel It seems the gir-repository 0.6.3 clutter support is for clutter 0.8 [1] and hence the mutter build barfs on it [2]. A quick look through the git logs I don't see a g-i or gir commit for the support of the new clutter. gir-repository-devel is needed for Gtk and Pango. The Clutter-0.9 support is part of Clutter itself. The clutter in Rawhide needs a small patch to the spec and a rebuild - see bug 512260 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Bug 508318 depends on bug 512260, which changed state. Bug 512260 Summary: Build with introspection support https://bugzilla.redhat.com/show_bug.cgi?id=512260 What|Old Value |New Value Status|NEW |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508318
--- Comment #15 from Peter Robinson pbrobin...@gmail.com 2009-07-17 17:59:52
EDT ---
SPEC: http://pbrobinson.fedorapeople.org/mutter.spec
SRPM: http://pbrobinson.fedorapeople.org/mutter-2.27.1-1.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1483173
I think everything is fixed except the desktop file bit and the
SHOULD_HAVE_DEFINED section which I'll update in the morning but the rest is
now updated and it builds :-)
(In reply to comment #12)
[OK]* MUST: rpmlint must be run on every package. The output should be
posted in the review.[1]
ON SRPM:
rpmlint /tmp/mutter-2.27.0-0.2.20090626gita13dec3.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
On RPM:
mutter.i586: W: incoherent-version-in-changelog 2.27.0-0.2
['2.27.0-0.2.20090626gita13dec3.fc11', '2.27.0-0.2.20090626gita13dec3']
Doesn't matter, we'll have real tarballs soon anyways.
mutter.i586: W: shared-lib-calls-exit /usr/lib/libmutter-private.so.0.0.0
e...@glibc_2.0
None of rpmlint's damn business (libmutter-private has meta_exit, meta_fatal
utility functions in it.)
mutter.i586: W: non-conffile-in-etc /etc/gconf/schemas/mutter.schemas
OK.
[OK]* MUST: The package must be named according to the Package Naming
Guidelines .
[OK]* MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
[OK]* MUST: The package must be licensed with a Fedora approved license
and
meet the Licensing Guidelines .
[OK]* MUST: The License field in the package spec file must match the
actual license. [3]
[OK]* MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
[OK]* MUST: The spec file must be written in American English. [5]
[OK]* MUST: The spec file for the package MUST be legible. [6]
[XX]* MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this
task.
If no upstream URL can be specified for this package, please see the Source
URL
Guidelines for how to deal with this.
Source: should be
http://download.gnome.org/sources/mutter/2.27/%{name}-%{version}.tar.bz2
Fixed.
[XX]* MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture. [7]
Looks like the file list is out of sync with recent mutter changes; removing
files that are no longer in Mutter and adding .po file handling, it seems to
build OK.
Fixed.
[NA]* MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec in
ExcludeArch.
[XX]* MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines
;
inclusion of those as BuildRequires is optional. Apply common sense.
From reading the configure.in, missing BuildRequires I can find:
gir-repository-devel
libXcomposite-devel
libSM-devel
Added. Fixed.
[XX]* MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.[9]
Not OK, no handling of .po files.
Added in. Fixed.
[OK]* MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default
paths,
must call ldconfig in %post and %postun. [10]
[OK]* MUST: If the package is designed to be relocatable, the packager
must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
[XX]* MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. [12]
File list has: %{_libdir}/mutter/plugins/clutter/*.so and doesn't own any of
the parent directories. (Current mutter removes the clutter/ part of this).
Probably should just have %{_datadir}/mutter in the file list.
Needs to Requires: control-center-filesystem for
/usr/share/gnome/wm-properties/
Fixed.
[OK]* MUST: A Fedora package must not list a file more than once in the
spec file's %files listings. [13]
[OK]* MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files section must
include a %defattr(...) line. [14]
[OK]* MUST: Each package must have a %clean section
[OK]* MUST: Each package must consistently use macros. [16]
[OK]* MUST: The package
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Owen Taylor otay...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|otay...@redhat.com Flag||fedora-review? --- Comment #11 from Owen Taylor otay...@redhat.com 2009-07-16 15:25:33 EDT --- Taking for review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508318
Owen Taylor otay...@redhat.com changed:
What|Removed |Added
Depends on|508525 |512260
--- Comment #12 from Owen Taylor otay...@redhat.com 2009-07-16 18:12:06 EDT
---
[OK]* MUST: rpmlint must be run on every package. The output should be
posted in the review.[1]
ON SRPM:
rpmlint /tmp/mutter-2.27.0-0.2.20090626gita13dec3.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
On RPM:
mutter.i586: W: incoherent-version-in-changelog 2.27.0-0.2
['2.27.0-0.2.20090626gita13dec3.fc11', '2.27.0-0.2.20090626gita13dec3']
Doesn't matter, we'll have real tarballs soon anyways.
mutter.i586: W: shared-lib-calls-exit /usr/lib/libmutter-private.so.0.0.0
e...@glibc_2.0
None of rpmlint's damn business (libmutter-private has meta_exit, meta_fatal
utility functions in it.)
mutter.i586: W: non-conffile-in-etc /etc/gconf/schemas/mutter.schemas
OK.
[OK]* MUST: The package must be named according to the Package Naming
Guidelines .
[OK]* MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
[OK]* MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[OK]* MUST: The License field in the package spec file must match the
actual license. [3]
[OK]* MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
[OK]* MUST: The spec file must be written in American English. [5]
[OK]* MUST: The spec file for the package MUST be legible. [6]
[XX]* MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Source: should be
http://download.gnome.org/sources/mutter/2.27/%{name}-%{version}.tar.bz2
[XX]* MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture. [7]
Looks like the file list is out of sync with recent mutter changes; removing
files that are no longer in Mutter and adding .po file handling, it seems to
build OK.
[NA]* MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec in
ExcludeArch.
[XX]* MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
From reading the configure.in, missing BuildRequires I can find:
gir-repository-devel
libXcomposite-devel
libSM-devel
[XX]* MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.[9]
Not OK, no handling of .po files.
[OK]* MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. [10]
[OK]* MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
[XX]* MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. [12]
File list has: %{_libdir}/mutter/plugins/clutter/*.so and doesn't own any of
the parent directories. (Current mutter removes the clutter/ part of this).
Probably should just have %{_datadir}/mutter in the file list.
Needs to Requires: control-center-filesystem for
/usr/share/gnome/wm-properties/
[OK]* MUST: A Fedora package must not list a file more than once in the
spec file's %files listings. [13]
[OK]* MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files section must
include a %defattr(...) line. [14]
[OK]* MUST: Each package must have a %clean section
[OK]* MUST: Each package must consistently use macros. [16]
[OK]* MUST: The package must contain code, or permissable content. [17]
[OK]* MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). [18]
[OK]* MUST: If a package includes something as
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Bug 508318 depends on bug 469460, which changed state. Bug 469460 Summary: review request: gir-repository - GObject Introspection Repository https://bugzilla.redhat.com/show_bug.cgi?id=469460 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Depends on||508525 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #9 from Peter Robinson pbrobin...@gmail.com 2009-06-27 04:01:51 EDT --- (In reply to comment #5) src rpm is broken (check size). probably half upload. Bad wifi at Fudcon probably. I'll update the spec and re-upload later today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #8 from Peter Robinson pbrobin...@gmail.com 2009-06-27 04:01:02 EDT --- For the URL, I'd suggest just using the cgit URL for now: http://git.gnome.org/cgit/mutter (I don't think the moblin URL is appropriate.) Is there a site for it then, I couldn't even find anything basic in live.gnome.org Some more drive-by comments: BuildRequires: gobject-introspection-devel [...] --without-introspection I took the config options from the moblin srpm. Not doubt there's more tweaking to do. Those two conflict. We'll definitely need an introspection-enabled package of Mutter for F12, so we can package gnome-shell. That will mean making sure that the Clutter package is introspection enabled as well, and that we have up-to-date versions of gobject-introspection and gir-repository packaged. The gobject-introspection is missing at least gtk/gdk ones. BuildRequires: fontconfig-devel BuildRequires: libglade2-devel BuildRequires: mesa-libGL-devel BuildRequires: xorg-x11-proto-devel These seem extraneous. I figured they were but I'm still having issues with the build anyway so haven't had a chance to fully optimise it. BuildRequires: zenity This should be a Requires: along with a BuildRequires. --disable-xinerama Why? Option from moblin again. At a high level, getting to packaging the gnome-shell stack for Fedora: gobject-introspection [already old version packaged, I think] gir-repository [there's a review request] clutter-0.9 gjs mutter gnome-shell The gobject-introspection is 0.6.2 so one release out. I'll look at the repo package to get that in, clutter is there. Not sure about gjs but will look as well. Is something that I want the gnome-shell team to get to soon (though probably not until after GUADEC); and to do that, we'll definitely push out tarball releases rather than packaging git snapshots. We're happy to have co-maintainers and people helping out with that. Brilliant! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Depends on||469460 --- Comment #10 from Peter Robinson pbrobin...@gmail.com 2009-06-27 07:34:30 EDT --- OK. New updated spec here. http://pbrobinson.fedorapeople.org/mutter-2.27.0-0.2.20090626gita13dec3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #1 from Bill Nottingham nott...@redhat.com 2009-06-26 10:53:48 EDT --- Just as a drive-by, that URL in the spec isn't right. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Bastien Nocera bnoc...@redhat.com changed: What|Removed |Added CC||otay...@redhat.com --- Comment #2 from Bastien Nocera bnoc...@redhat.com 2009-06-26 11:32:50 EDT --- Owen, what do you reckon with that? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #3 from Peter Robinson pbrobin...@gmail.com 2009-06-26 11:36:24 EDT --- (In reply to comment #1) Just as a drive-by, that URL in the spec isn't right. How right you are. I've set it to moblin.org at the moment as I can't find a page on gnome.org or in google. Other suggestions welcome. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #4 from Owen Taylor otay...@redhat.com 2009-06-26 12:53:50 EDT --- For the URL, I'd suggest just using the cgit URL for now: http://git.gnome.org/cgit/mutter (I don't think the moblin URL is appropriate.) Some more drive-by comments: BuildRequires: gobject-introspection-devel [...] --without-introspection Those two conflict. We'll definitely need an introspection-enabled package of Mutter for F12, so we can package gnome-shell. That will mean making sure that the Clutter package is introspection enabled as well, and that we have up-to-date versions of gobject-introspection and gir-repository packaged. BuildRequires: fontconfig-devel BuildRequires: libglade2-devel BuildRequires: mesa-libGL-devel BuildRequires: xorg-x11-proto-devel These seem extraneous. BuildRequires: zenity This should be a Requires: along with a BuildRequires. --disable-xinerama Why? At a high level, getting to packaging the gnome-shell stack for Fedora: gobject-introspection [already old version packaged, I think] gir-repository [there's a review request] clutter-0.9 gjs mutter gnome-shell Is something that I want the gnome-shell team to get to soon (though probably not until after GUADEC); and to do that, we'll definitely push out tarball releases rather than packaging git snapshots. We're happy to have co-maintainers and people helping out with that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 Rudolf Kastl che...@gmail.com changed: What|Removed |Added CC||che...@gmail.com --- Comment #5 from Rudolf Kastl che...@gmail.com 2009-06-26 12:56:50 EDT --- src rpm is broken (check size). probably half upload. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #6 from Owen Taylor otay...@redhat.com 2009-06-26 13:12:03 EDT --- One more comment - the Summary should be : Window and compositing manager based on Clutter (That's what I used in mutter.doap and GNOME bugzilla) I don't have a %description handy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508318] Review Request: mutter - A window manager based on metacity and clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508318 --- Comment #7 from Bastien Nocera bnoc...@redhat.com 2009-06-26 19:31:45 EDT --- FYI, I already pushed clutter 0.9 packages for F12. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
