[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 --- Comment #5 from Miroslav Lichvar mlich...@redhat.com 2009-07-13 07:05:40 EDT --- New Package CVS Request === Package Name: compat-readline5 Short Description: A library for editing typed command lines Owners: mlichvar Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 Michal Nowak mno...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Michal Nowak mno...@redhat.com 2009-07-13 07:08:18 EDT --- Requesting CVS per mlichvar. See Comment #5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-07-14 00:39:27 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 Michal Nowak mno...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Michal Nowak mno...@redhat.com 2009-07-11 03:16:34 EDT --- APPROVED by me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 --- Comment #3 from Michal Nowak mno...@redhat.com 2009-07-09 05:22:58 EDT --- The warning was caused by file(1)'s fault, filed bug 510429. - patches have comments - directory ownership is now OK - builds in Koji (scratch) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=510022
--- Comment #1 from Michal Nowak mno...@redhat.com 2009-07-08 11:10:25 EDT
---
[ INVESTIGATE ]
# MUST: rpmlint must be run on every package. The output should be posted in
the review.[1]
compat-readline5.x86_64: W: shared-lib-calls-exit /usr/lib64/libhistory.so.5.2
e...@glibc_2.2.5
compat-readline5.x86_64: W: shared-lib-calls-exit /lib64/libreadline.so.5.2
e...@glibc_2.2.5
Miroslav checked code, it's exit on -ENOMEM.
compat-readline5-devel.x86_64: W: only-non-binary-in-usr-lib
Dunno what's the problem here.
new...@dhcp-lab-124 ~ $ rpmls
/home/newman/rpmbuild/RPMS/x86_64/readline-devel-5.2-14.fc11.x86_64.rpm | grep
so
lrwxrwxrwx /usr/lib64/libhistory.so
lrwxrwxrwx /usr/lib64/libreadline.so
new...@dhcp-lab-124 ~ $ rpmls
/home/newman/rpmbuild/RPMS/x86_64/compat-readline5-devel-5.2-15.fc11.x86_64.rpm
| grep so
lrwxrwxrwx /usr/lib64/readline5/libhistory.so
lrwxrwxrwx /usr/lib64/readline5/libreadline.so
compat-readline5-devel.x86_64: W: no-documentation
compat-readline5-static.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 5 warnings.
Doc bit are intentionally removed.
[ OK ] # MUST: The package must be named according to the Package Naming
Guidelines .
We don't have general compat naming policy, the name looks like any other
compat package.
[ OK ] # MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
Filename is compat-readline5.spec.
[ OK ] # MUST: The package must meet the Packaging Guidelines .
[ OK ] # MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
License: GPLv2+
[ OK ] # MUST: The License field in the package spec file must match the actual
license. [3]
COPYING says GPLv2, sources: ...as published by the Free Software Foundation;
either version 2, or (at your option) any later version...
[ OK ] # MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
-rw-r--r-- /usr/share/doc/compat-readline5-5.2/COPYING
%doc CHANGES COPYING NEWS README USAGE
[ WAIVED ] # MUST: The spec file must be written in American English. [5]
It is (to my best knowledge).
[ OK ] # MUST: The spec file for the package MUST be legible. [6]
[ OK ] # MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
e39331f32ad14009b9ff49cc10c5e751 readline-5.2.tar.gz
e39331f32ad14009b9ff49cc10c5e751
/home/newman/rpmbuild/SOURCES/readline-5.2.tar.gz
[ OK ] # MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture. [7]
Local test performed.
[ N/A ] # MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[ OK ] # MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ N/A ] # MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.[9]
[ OK ] # MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. [10]
[ OK ] # MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [11]
[ FAIL ] # MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. [12]
compat-readline5-static:
new...@dhcp-lab-124 x86_64 $ rpmquery -f /usr/lib64/readline5/
file /usr/lib64/readline5 is not owned by any package
Looks like the dir /usr/lib64/readline5/ is not owned by anyone. The archives
inside are.
[ OK ] # MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. [13]
[ OK ] # MUST: Permissions on files must be set properly. Executables should
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 --- Comment #2 from Miroslav Lichvar mlich...@redhat.com 2009-07-08 11:36:47 EDT --- The description for the rpmlint warning says: There are only non binary files in /usr/lib so they should be in /usr/share. I don't think it applies here. Everything else should be fixed in http://fedorapeople.org/~mlichvar/tmp/compat-readline5-5.2-16.fc12.src.rpm Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510022] Review Request: compat-readline5 - A library for editing typed command lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510022 Michal Nowak mno...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mno...@redhat.com AssignedTo|nob...@fedoraproject.org|mno...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
