[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #26 from Daniel Roesen d...@cluenet.de 2009-08-20 05:19:03 EDT --- I do not have the details yet, but the update to 2.3.2-3 wiped out my CVSROOT completely. Just as a warning to other users... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2009-08-15 04:13:24 EDT --- rancid-2.3.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||2.3.2-3.fc10 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2009-08-15 04:19:53 EDT --- rancid-2.3.2-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|2.3.2-3.fc10|2.3.2-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2009-07-28 14:24:30 EDT --- rancid-2.3.2-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rancid'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8062 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2009-07-28 14:23:34 EDT --- rancid-2.3.2-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rancid'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8057 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2009-07-27 20:27:37 EDT --- rancid-2.3.2-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rancid-2.3.2-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2009-07-27 20:52:57 EDT --- rancid-2.3.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rancid-2.3.2-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #19 from Jason Tibbitts ti...@math.uh.edu 2009-07-23 12:37:28 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #13 from Gary T. Giesen gie...@snickers.org 2009-07-22 04:10:00 EDT --- New version: Spec URL: http://giesen.fedorapeople.org/rancid/rancid.spec SRPM URL: http://giesen.fedorapeople.org/rancid/rancid-2.3.2-2.fc11.src.rpm Quite a few changes: * Wed Jul 22 2009 Gary T. Giesen gie...@snickers.org 2.3.2-2 - Added logrotate (and updated crontab to let logrotate handle log file cleanup - Removed Requires: for rsh, telnet, and openssh-clients - Removed Requires: for cvs - Cleaned up file permissions - Added shell for rancid user for CVS tree creation and troubleshooting - Patch cron file for installation path - Removed installation of CVS root to permit SVN use - Moved from libdir to libexecdir rpmlint is still being whiny (but I don't believe it needs fixing): $ rpmlint rancid-2.3.2-2.fc11.i586.rpm rancid.i586: W: non-standard-uid /etc/rancid/lg.conf rancid rancid.i586: W: non-standard-gid /etc/rancid/lg.conf rancid rancid.i586: E: non-readable /etc/rancid/lg.conf 0640 rancid.i586: W: non-standard-uid /etc/rancid/rancid.conf rancid rancid.i586: W: non-standard-gid /etc/rancid/rancid.conf rancid rancid.i586: E: non-readable /etc/rancid/rancid.conf 0640 rancid.i586: W: non-standard-uid /var/rancid rancid rancid.i586: W: non-standard-gid /var/rancid rancid rancid.i586: E: non-standard-dir-perm /var/rancid 0750 rancid.i586: W: non-standard-uid /etc/rancid rancid rancid.i586: W: non-standard-gid /etc/rancid rancid rancid.i586: E: non-standard-dir-perm /etc/rancid 0750 rancid.i586: W: non-standard-uid /var/log/rancid/old rancid rancid.i586: W: non-standard-gid /var/log/rancid/old rancid rancid.i586: E: non-standard-dir-perm /var/log/rancid/old 0750 rancid.i586: W: non-standard-uid /var/log/rancid rancid rancid.i586: W: non-standard-gid /var/log/rancid rancid rancid.i586: E: non-standard-dir-perm /var/log/rancid 0750 1 packages and 0 specfiles checked; 6 errors, 12 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #14 from Gary T. Giesen gie...@snickers.org 2009-07-22 04:12:28 EDT --- As a note for posterity, the non-standard directory permissions are required because both the logs and configs contain sensitive information (such as usernames, passwords, configuration logs) and thus eliminating read access by world. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #15 from Daniel Roesen d...@cluenet.de 2009-07-22 04:21:43 EDT --- Excellent, you have made some changes I was about to suggest (libexecdir, shell for rancid user). :) One left is to rename the GECOS field of the rancid user from Account to run RANCID to just RANCID, given it will be used as full name in the email From field. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #16 from Gary T. Giesen gie...@snickers.org 2009-07-22 21:55:16 EDT --- New version: Spec URL: http://giesen.fedorapeople.org/rancid/rancid.spec SRPM URL: http://giesen.fedorapeople.org/rancid/rancid-2.3.2-3.fc11.src.rpm One minor change, changed the GECOS per Daniel Roesen. This one should be good to go assuming there are no other issues that crop up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 David Nalley da...@gnsa.us changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #17 from David Nalley da...@gnsa.us 2009-07-22 23:27:47 EDT --- I tend to agree with lack of telnet and rsh, but I don't think that blocks the package, more of a preference than anything, so not within scope of the package review. provides and requires looks sane: [ke4...@nalleyt61 i586]$ rpm -qp --provides ./rancid-2.3.2-3.fc11.i586.rpm config(rancid) = 2.3.2-3.fc11 rancid = 2.3.2-3.fc11 rancid(x86-32) = 2.3.2-3.fc11 [ke4...@nalleyt61 i586]$ rpm -qp --requires ./rancid-2.3.2-3.fc11.i586.rpm /bin/sh /bin/sh /usr/bin/expect /usr/bin/perl config(rancid) = 2.3.2-3.fc11 expect findutils iputils libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libutil.so.1 libutil.so.1(GLIBC_2.0) logrotate perl perl = 1:5 perl(CGI) perl(Getopt::Std) perl(LockFile::Simple) perl(Mail::Mailer) perl(POSIX) perl(Sys::Syslog) perl(newgetopt.pl) rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 rtld(GNU_HASH) shadow-utils As you noted rpmlint still complaining about permissions - but doesn't appear to be a blocker. [ke4...@nalleyt61 i586]$ rpmlint ../../SPECS/rancid.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 i586]$ rpmlint ../../SRPMS/rancid-2.3.2-3.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 i586]$ rpmlint ./rancid-2.3.2-3.fc11.i586.rpm rancid.i586: W: non-standard-uid /etc/rancid/lg.conf rancid rancid.i586: W: non-standard-gid /etc/rancid/lg.conf rancid rancid.i586: E: non-readable /etc/rancid/lg.conf 0640 rancid.i586: W: non-standard-uid /etc/rancid/rancid.conf rancid rancid.i586: W: non-standard-gid /etc/rancid/rancid.conf rancid rancid.i586: E: non-readable /etc/rancid/rancid.conf 0640 rancid.i586: W: non-standard-uid /var/rancid rancid rancid.i586: W: non-standard-gid /var/rancid rancid rancid.i586: E: non-standard-dir-perm /var/rancid 0750 rancid.i586: W: non-standard-uid /etc/rancid rancid rancid.i586: W: non-standard-gid /etc/rancid rancid rancid.i586: E: non-standard-dir-perm /etc/rancid 0750 rancid.i586: W: non-standard-uid /var/log/rancid/old rancid rancid.i586: W: non-standard-gid /var/log/rancid/old rancid rancid.i586: E: non-standard-dir-perm /var/log/rancid/old 0750 rancid.i586: W: non-standard-uid /var/log/rancid rancid rancid.i586: W: non-standard-gid /var/log/rancid rancid rancid.i586: E: non-standard-dir-perm /var/log/rancid 0750 1 packages and 0 specfiles checked; 6 errors, 12 warnings. [ke4...@nalleyt61 i586]$ rpmlint ./rancid-debuginfo-2.3.2-3.fc11.i586.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks for doing the work on this. I don't see any blockers for approving the package thus: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Gary T. Giesen gie...@snickers.org changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #18 from Gary T. Giesen gie...@snickers.org 2009-07-22 23:44:15 EDT --- New Package CVS Request === Package Name: rancid Short Description: Really Awesome New Cisco confIg Differ Owners: giesen Branches: F-10 F-11 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Christopher McCrory chris...@pricegrabber.com changed: What|Removed |Added CC||chris...@pricegrabber.com --- Comment #10 from Christopher McCrory chris...@pricegrabber.com 2009-07-18 13:58:53 EDT --- FWIW a couple notes: recommend not requiring telnet, rsh, ( and maybe openssh). One or more are needed, but not necessarily all. e.g. I don't even want rsh installed. If an admin knows enough to want this package, they know what clients are needed also. using /var/lib/rancid instead of /var/rancid might resolve some rpmlint warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #11 from Gary T. Giesen gie...@snickers.org 2009-07-18 14:30:51 EDT --- I'm also considering not actually requiring CVS, since rancid can work with svn, and possibly git in the future. There really needs to be an RPM Suggests flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512068
--- Comment #12 from Christopher McCrory chris...@pricegrabber.com
2009-07-18 16:55:15 EDT ---
also crontab hardcodes /usr/lib/rancid/rancid-run which breaks on 64bit arch
/usr/lib64/rancid/rancid-run . recommend symlink in /usr/bin or generate at
buildtime from within spec file.
in crontab: find .. exec rm {}
recommend exec rm '{}' in case a space shows up somewhere. or use --delete (
maybe with --print)
maybe also add MAILTO=root in crontab so errors have a better chance of being
read.
rancid.conf file has a . in PATH something:.:more . recommend no '.' in
PATH.
I could live with not requiring cvs as I use svn.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Daniel Roesen d...@cluenet.de changed: What|Removed |Added CC||d...@cluenet.de --- Comment #7 from Daniel Roesen d...@cluenet.de 2009-07-17 04:07:59 EDT --- Excellent news that someone finally packages up RANCID... As I'm about to install RANCID here for a somewhat larger deployment (order of several hundred devices being monitored), I'm looking forward to use your package and provide feedback on problems if I find some. I'm not really fond of RANCID yet from the software admin side, but I had to hack up original sources several times to make it behave in the past. I do hear that there are many patches and patchsets floating around, I hope the Fedora RPM will pick up the usual canonical patchset(s) to make life easier on users. I see a reference to jcollie's git patch e.g. I'm not holding my breath either on the namespace discussion. Gary, and ETA for the logrotate/perms-fixed version? I ponder holding off installation for that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #8 from Gary T. Giesen gie...@snickers.org 2009-07-17 11:59:00 EDT --- I should have a new version tonight, I'm still doing testing on it to make sure everything works as planned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #9 from Gary T. Giesen gie...@snickers.org 2009-07-17 12:00:51 EDT --- As another note, if there's any particular patch you want applied, let me know and I'll definitely consider adding it. I'm looking to add the usercmd patch as well, since I believe it's been rejected several times by upstream but it's infinitely valuable to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #1 from Gary T. Giesen gie...@snickers.org 2009-07-16 03:15:32 EDT --- rpmlint output: rpmlint -i rancid-2.3.2-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 Gary T. Giesen gie...@snickers.org changed: What|Removed |Added CC||a...@thaumaturge.org --- Comment #2 from Gary T. Giesen gie...@snickers.org 2009-07-16 03:16:56 EDT --- *** Bug 451189 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512068
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
CC||mtas...@ioa.s.u-tokyo.ac.jp
--- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-16
11:10:09 EDT ---
Well, I still think that the names of man pages like {a,b,c..}login.1.gz
par.1.gz or so will easily cause name space conflict.
Would you discuss the naming of binaries and man packages with the
upstream first?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 David Nalley da...@gnsa.us changed: What|Removed |Added Status|NEW |ASSIGNED CC||da...@gnsa.us AssignedTo|nob...@fedoraproject.org|da...@gnsa.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #4 from Gary T. Giesen gie...@snickers.org 2009-07-16 12:53:19 EDT --- I will see what I can do, but rancid is a long-established and widely-used utility in the ISP community, so I doubt I'll get much traction there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512068
--- Comment #5 from David Nalley da...@gnsa.us 2009-07-16 14:54:30 EDT ---
I am thrilled to see this in Fedora (it was actually on my todo list - though I
wish upstream would accept jcollie's git patch. )
I'd like to hear back what upstream says about the naming issue as I think
that's a potentially significant conflict.
MUST: rpmlint must be run on every package. The output should be posted in the
review.
[ke4...@nalleyt61 SPECS]$ rpmlint ./rancid.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4...@nalleyt61 SPECS]$ rpmlint ../SRPMS/rancid-2.3.2-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4...@nalleyt61 SPECS]$ rpmlint ../RPMS/i586/rancid-*
rancid.i586: W: non-standard-uid /etc/rancid/rancid.conf rancid
rancid.i586: W: non-standard-gid /etc/rancid/rancid.conf rancid
rancid.i586: E: non-readable /etc/rancid/rancid.conf 0640
rancid.i586: W: non-standard-uid /var/rancid/CVS rancid
rancid.i586: W: non-standard-gid /var/rancid/CVS rancid
rancid.i586: E: non-standard-dir-perm /var/rancid/CVS 0700
rancid.i586: W: non-standard-uid /etc/rancid/lg.conf rancid
rancid.i586: W: non-standard-gid /etc/rancid/lg.conf rancid
rancid.i586: E: non-readable /etc/rancid/lg.conf 0640
rancid.i586: W: non-standard-uid /var/rancid rancid
rancid.i586: W: non-standard-gid /var/rancid rancid
rancid.i586: E: non-standard-dir-perm /var/rancid 0700
rancid.i586: W: non-standard-uid /var/rancid/CVS/CVSROOT rancid
rancid.i586: W: non-standard-gid /var/rancid/CVS/CVSROOT rancid
rancid.i586: E: version-control-internal-file /var/rancid/CVS/CVSROOT
rancid.i586: E: non-standard-dir-perm /var/rancid/CVS/CVSROOT 0700
rancid.i586: W: non-standard-uid /etc/rancid rancid
rancid.i586: W: non-standard-gid /etc/rancid rancid
rancid.i586: E: non-standard-dir-perm /etc/rancid 0750
rancid.i586: W: non-standard-uid /var/log/rancid rancid
rancid.i586: W: non-standard-gid /var/log/rancid rancid
rancid.i586: E: non-standard-dir-perm /var/log/rancid 0700
rancid.i586: W: log-files-without-logrotate /var/log/rancid
rancid.i586: W: non-standard-dir-in-var rancid
2 packages and 0 specfiles checked; 8 errors, 16 warnings.
I'd personally like to see log rotate fixed, but don't think it's a blocker.
The rest looks like rpmlint just complaining, though I don't think there is
anything that's a blocker.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines
[ke4...@nalleyt61 SOURCES]$ md5sum rancid-2.3.2.tar.gz*
4e2de3ff6850b311c0e2a442f7ae5d82 rancid-2.3.2.tar.gz
4e2de3ff6850b311c0e2a442f7ae5d82 rancid-2.3.2.tar.gz.1
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
NA: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
NA: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
NA: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker.
OK: A package must own all directories
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #6 from Gary T. Giesen gie...@snickers.org 2009-07-16 16:36:51 EDT --- I'll fix up the logrotate, and double check all the permissions to make sure they're appropriate. I'm not holding my breath on getting positive results re: namespace collision. Is anyone actually aware of any packages that collide? Rancid 1.0 was released in June of 1999, so the package is 10 years old and is pretty established. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
