[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Depends on||506848 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||506446(FedoraMoblin) Depends on||506804, 506825, 507377, ||508318, 511895, 506486, ||506721 Summary|Review Request: |Review Request: |mutter-moblin - |mutter-moblin - Moblin ||Netbook plugin for Mutter --- Comment #1 from Peter Robinson 2009-07-23 13:40:58 EDT --- SPEC: http://pbrobinson.fedorapeople.org/mutter-moblin.spec SRPM: http://pbrobinson.fedorapeople.org/mutter-moblin-0.30.3-1.fc11.src.rpm Description: Moblin Netbook plugin for Mutter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Bug 513452 depends on bug 508318, which changed state. Bug 508318 Summary: Review Request: mutter - A window manager based on metacity and clutter https://bugzilla.redhat.com/show_bug.cgi?id=508318 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Bug 513452 depends on bug 511895, which changed state. Bug 511895 Summary: Review Request: clutter-imcontext - IMContext Framework Library for Clutter https://bugzilla.redhat.com/show_bug.cgi?id=511895 What|Old Value |New Value Status|ASSIGNED|ON_QA Resolution||RAWHIDE Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Bug 513452 depends on bug 507377, which changed state. Bug 507377 Summary: Review Request: jana - An interface library for time-related PIM https://bugzilla.redhat.com/show_bug.cgi?id=507377 What|Old Value |New Value Status|ASSIGNED|ON_QA Resolution||RAWHIDE Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 --- Comment #2 from Peter Robinson 2009-08-06 10:50:49 EDT --- SPEC: as before SRPM: http://pbrobinson.fedorapeople.org/mutter-moblin-0.32.2-1.fc11.src.rpm New upstream release with some various cleanups to the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 --- Comment #3 from Peter Robinson 2009-08-07 10:53:09 EDT --- SPEC: as before SRPM: http://pbrobinson.fedorapeople.org/mutter-moblin-0.32.3-1.fc11.src.rpm New upstream release with some various cleanups to the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Bug 513452 depends on bug 506804, which changed state. Bug 506804 Summary: Review Request: anerley - Moblin widgets for people information https://bugzilla.redhat.com/show_bug.cgi?id=506804 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513452
D. Marlin changed:
What|Removed |Added
CC||dmar...@redhat.com
--- Comment #4 from D. Marlin 2009-08-11 18:36:33 EDT ---
This package will not currently build due to a missing dependency:
from root.log
DEBUG util.py:256: No Package Found for bickley-devel
so a full review will have to wait for bickley.
configure will be run twice, once in the prep stage (through autogen.sh) and
once in the build stage.
# run autogen.sh until we have a proper release, but don't run configure
twice.
sed -i 's|echo|exit 0|g' autogen.sh
./autogen.sh
The 'sed' change does not appear to work for this autogen.sh script. I think
the following command line change will:
# run autogen.sh until we have a proper release, but don't run configure
twice.
NOCONFIGURE=yes ./autogen.sh
It appears that the libraries are being included in the files lists twice
(duplicate):
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc COPYING README
%{_libdir}/lib*.so.0*
%{_libdir}/mutter/plugins/moblin-netbook.so.*
%{_libdir}/lib*.so.0*# duplicate
%{_libexecdir}/moblin-panel*
:
%files devel
%defattr(-,root,root,-)
%{_libdir}/lib*.so
%{_libdir}/mutter/plugins/moblin-netbook.so
%{_libdir}/pkgconfig/*.pc
%{_libdir}/lib*.so# duplicate
%{_includedir}/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Depends on|506825 | --- Comment #5 from Peter Robinson 2009-08-18 18:21:52 EDT --- New upstream release that has split out bickley and a lot of other bits. Both good and bad! SPEC: As before SRPM: http://pbrobinson.fedorapeople.org/mutter-moblin-0.34.0-1.fc12.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1613225 The above points are fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Tom "spot" Callaway changed: What|Removed |Added Status|NEW |ASSIGNED CC||tcall...@redhat.com AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com Flag||fedora-review+ --- Comment #6 from Tom "spot" Callaway 2009-08-19 13:44:20 EDT --- Two items of note: 1. Instead of using sed to try to stop configure from running twice (it doesn't work), do this: # run autogen.sh until we have a proper release, but don't run configure twice. NOCONFIGURE=true ./autogen.sh That works because the provided autogen.sh just calls out to gnome-autogen.sh, which has some intelligence. 2. Do you want to pass --enable-scaled-background to configure? == Review == Good: - rpmlint checks return: mutter-moblin.x86_64: W: shared-lib-calls-exit /usr/lib64/libmoblin-panel.so.0.0.0 e...@glibc_2.2.5 mutter-moblin-devel.x86_64: W: no-documentation mutter-moblin-devel.x86_64: W: dangling-relative-symlink /usr/lib64/mutter/plugins/moblin-netbook.so moblin-netbook.so.3400.0.0 All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (c781f9a6558167658fc7891d1ba8c041db1a75113ef220441c05f11a877436ed) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Address the first two issues before commit, but this is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Peter Robinson 2009-08-19 14:58:07 EDT --- New Package CVS Request === Package Name: mutter-moblin Short Description: Moblin Netbook plugin for Mutter Owners: pbrobinson Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 --- Comment #7 from Peter Robinson 2009-08-19 14:55:02 EDT --- > Two items of note: > > 1. Instead of using sed to try to stop configure from running twice (it > doesn't > work), do this: > > # run autogen.sh until we have a proper release, but don't run configure > twice. > NOCONFIGURE=true ./autogen.sh > > That works because the provided autogen.sh just calls out to gnome-autogen.sh, > which has some intelligence. Thanks. That is very good to know, I've seen so many different work arounds its hard to know which is best. > 2. Do you want to pass --enable-scaled-background to configure? I was discussing that one last night with someone, I agree I think its the best option. I will update them both before commit. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Jason Tibbitts 2009-08-19 17:41:21 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 --- Comment #10 from Peter Robinson 2009-08-19 19:29:41 EDT --- imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||518446 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||518445 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||518449 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||518448 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #11 from Peter Robinson 2009-08-20 09:06:45 EDT --- Closed as its now in rawhide. Thanks spot! Will be adding very shortly the packages for the moblin panel that were split out of this package in the 0.34.0 release. They add functionality but the core UI is testable without them. I'll add them with a dep on this as a tracker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||518450 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson changed: What|Removed |Added Blocks||518447 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
