[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-08-27 03:00:07 EDT --- If you want this package on F-11 and tokyotyrant really needs tokyocabinet = 1.4.30 please file a RFE bug ticket against tokyocabinet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 Silas Sewell si...@sewell.ch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #13 from Silas Sewell si...@sewell.ch 2009-08-27 23:38:34 EDT --- Built for rawhide and a bug request made for F-11 push. Thanks Mamoru and Kevin. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #14 from Silas Sewell si...@sewell.ch 2009-08-27 23:38:52 EDT --- https://bugzilla.redhat.com/show_bug.cgi?id=520024 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-08-24 15:53:17 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #9 from Silas Sewell si...@sewell.ch 2009-08-22 10:27:00 EDT --- Thanks Mamoru Tasaka. I've fixed the URL. diff: http://code.google.com/p/silassewell/source/detail?r=316 srpm: http://code.google.com/p/silassewell/downloads/detail?name=tokyotyrant-1.1.33-5.fc12.src.rpm [si...@fox rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm tokyotyrant.i586: W: non-standard-uid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/log/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/log/tokyotyrant tokyotyrant 5 packages and 0 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 Silas Sewell si...@sewell.ch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Silas Sewell si...@sewell.ch 2009-08-22 10:27:48 EDT --- New Package CVS Request === Package Name: tokyotyrant Short Description: A network interface to Tokyo Cabinet Owners: silas Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-08-21 12:03:17 EDT --- Okay, except for one thing: - Perhaps http://lxc.sourceforge.net/ (written as URL) has no relation with tokyocabinet/tokyotyrant and http://tokyocabinet.sourceforge.net/ should be used for URL. - This package (tokyotyrant) is APPROVED by mtasaka - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516971
--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-08-20
11:18:29 EDT ---
Well,
- -3.fc12.src.rpm you posted does not seem to contain pkgconfig/Requires
changes you posted on comment 5?
- As I said in comment 2, adding Requires: tokyocabinet in
tokyotyrant.pc{,in}
is more correct than to add -ltokyocabinet to Libs: in case the directory
where tokyocabinet header files are moved, like:
Name: Tokyo Tyrant
Description: network interface of Tokyo Cabinet
Version: 1.1.33
Requires: tokyocabinet
Libs: -L${libdir} -ltokyotyrant
Cflags: -I${includedir}
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #7 from Silas Sewell si...@sewell.ch 2009-08-20 22:36:56 EDT --- OK, think I finally got it. diff: http://code.google.com/p/silassewell/source/detail?r=315 srpm: http://silassewell.googlecode.com/files/tokyotyrant-1.1.33-4.fc12.src.rpm rpmlint [si...@fox rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm tokyotyrant.i586: W: non-standard-uid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/log/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/log/tokyotyrant tokyotyrant 5 packages and 0 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #5 from Silas Sewell si...@sewell.ch 2009-08-18 23:54:34 EDT --- The above mentioned issues should be fixed. spec diff: http://code.google.com/p/silassewell/source/diff?spec=svn313r=313format=sidepath=/trunk/projects/packages/rpms/tokyotyrant/tokyotyrant.spec tokyotyrant.pc diff: http://code.google.com/p/silassewell/source/diff?spec=svn313r=313format=sidepath=/trunk/projects/packages/rpms/tokyotyrant/tokyotyrant-1.1.33.build.patch srpm: http://silassewell.googlecode.com/files/tokyotyrant-1.1.33-3.fc12.src.rpm rpmlint [si...@fox rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm tokyotyrant.i586: W: non-standard-uid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/log/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/log/tokyotyrant tokyotyrant 5 packages and 0 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-08-17 12:29:17 EDT --- For -2: * Timestamps - Forgot to mention, however when using install or cp commands, add -p option to keep timestamps on installed files: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Dependency/pkgconfig file - And please address the below: (In reply to comment #2) - For example installed /usr/include/tcrdb.h contains: --- 30 #include tcutil.h 31 #include tcadb.h --- so at least tokyotyrant-devel should have Requires: tokyocabinet-devel. And tokyotyrant.pc should have Requires: tokyocabinet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 --- Comment #3 from Silas Sewell si...@sewell.ch 2009-08-16 17:35:35 EDT --- I've addressed the issues listed above. Would you explain how these binaries are used? - I really couldn't figure it out, but I did move them to their own sub-directory. diff: http://code.google.com/p/silassewell/source/diff?spec=svn312r=312format=sidepath=/trunk/projects/packages/rpms/tokyotyrant/tokyotyrant.spec srpm: http://silassewell.googlecode.com/files/tokyotyrant-1.1.33-2.fc12.src.rpm rpmlint [si...@fox rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm tokyotyrant.i586: W: non-standard-uid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/lib/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/run/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-uid /var/log/tokyotyrant tokyotyrant tokyotyrant.i586: W: non-standard-gid /var/log/tokyotyrant tokyotyrant 5 packages and 0 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516971
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-08-14
14:39:45 EDT ---
Some notes:
! About tokyocabinet dependency
- Note that current latest package of tokyocabinet on koji
is tokyocabinet-1.4.30-1.fc12
( This already exists in koji dist-f12 buildroot, but has not
pushed to rawhide tree yet because of F12alpha freeze )
* Package name
- Usually development related package should be named as
tokyotyrant-devel, not tokyotyrant-libs-devel (even if
you create tokyotyrant-libs package)
* About removing rpath
- Please avoid to use chrpath binary as much as possible
for removing rpath but use more standard method
( Using chrpath --delete should be thought as the last
resort, which is usually not needed ).
For this package replacing LD_RUN_PATH with LD_LIBRARY_PATH
should remove rpath without using chrpath
* Macros
- Use %_initddir for %_sysconfdir/rc.d/init.d
https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_on_the_filesystem
* About %_libdir/ttskel*.so
- Would you explain how these binaries are used?
* Actually these binaries don't have sonames, don't have the names
libfoo.so,
so these don't seem to be system-wide libraries.
I suggest at least these libraries should be moved to package-specific
directory (like %_libdir/%name)
* Also I tried to find out how these binaries are used by using grep,
however
it seems these binaries are used nowhere...
* %files
- You don't have to add COPYING to all binary packages (only including
to -libs package is enough because -libs package is needed by all
packages)
By the way README, THANKS or so should also be moved to -libs subpackage
because tokyotyrant (binary rpm) depends on -libs subpackage and not
opposite.
* Dependency
- Main package must have strict dependency
Requires: %{name}-libs = %{version}-%{release}
- For example installed /usr/include/tcrdb.h contains:
---
30 #include tcutil.h
31 #include tcadb.h
---
so at least tokyotyrant-devel should have Requires: tokyocabinet-devel.
And tokyotyrant.pc should have Requires: tokyocabinet.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516971 Caio 'kaio' Chance k...@kaio.me changed: What|Removed |Added CC||k...@kaio.me --- Comment #1 from Caio 'kaio' Chance k...@kaio.me 2009-08-13 22:09:53 EDT --- tokyocabinet is still 1.4.23 at the moment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
