[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Christof Damian chris...@damian.net changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #15 from Christof Damian chris...@damian.net  2009-11-15 06:19:01 
EDT ---
Package Change Request
==
Package Name: php-doctrine-Doctrine 
New Branches: F-12
Owners: cdamian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org




--- Comment #16 from Thomas Spura toms...@fedoraproject.org  2009-11-15 
07:13:43 EDT ---
Hmm, what do you want?

The F-12 branch should be created automatically.
At http://cvs.fedora.redhat.com/viewvc/F-12/php-doctrine-Doctrine/
there is already one.

Maybe you forgot a 'cvs update'?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #17 from Christof Damian chris...@damian.net  2009-11-15 07:45:16 
EDT ---
I did, but I am an idiot anyway. I should have done cvs update -dP

cheers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Christof Damian chris...@damian.net changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 CC||cwick...@fedoraproject.org




--- Comment #18 from Christoph Wickert cwick...@fedoraproject.org  2009-11-15 
11:41:08 EDT ---
(In reply to comment #16)

 The F-12 branch should be created automatically.

No, now we are already past mass branching and it's F-13 that is created
automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-11-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #19 from Thomas Spura toms...@fedoraproject.org  2009-11-15 
12:05:19 EDT ---
(In reply to comment #18)
 (In reply to comment #16)
 
  The F-12 branch should be created automatically.
 
 No, now we are already past mass branching and it's F-13 that is created
 automatically.

Ok, adding 'have been'.

- The F-12 branch should 'have been' created automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-10-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||1.1.3-4.fc11
 Resolution||ERRATA




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-10-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #14 from Fedora Update System upda...@fedoraproject.org  
2009-10-03 14:57:09 EDT ---
php-doctrine-Doctrine-1.1.3-4.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-09-29 10:29:16 EDT ---
php-doctrine-Doctrine-1.1.3-4.fc11 has been pushed to the Fedora 11 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-doctrine-Doctrine'.  You
can provide feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10014

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #11 from Kevin Fenzi ke...@tummy.com  2009-09-25 12:30:44 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-09-25 15:34:25 EDT ---
php-doctrine-Doctrine-1.1.3-4.fc11 has been submitted as an update for Fedora
11.
http://admin.fedoraproject.org/updates/php-doctrine-Doctrine-1.1.3-4.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #8 from Christof Damian chris...@damian.net  2009-09-24 04:33:55 
EDT ---
(In reply to comment #7)
 Provides: php-pear(doctrine/%{pear_name}) = %{version}
 
 Shouldn't that be:
 
 Provides:   php-pear(pear.doctrine-project.com/%{pear_name}) = %{version}

That is fixed now: 

Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec
SRPM URL:
http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-4.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
   Flag||fedora-review+




--- Comment #9 from Tom spot Callaway tcall...@redhat.com  2009-09-24 
11:09:27 EDT ---
Review 
===
Good:

- rpmlint checks return nothing
- package meets naming guidelines (PHP)
- package meets packaging guidelines (PHP)
- license (LGPLv2+ and MIT and BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(53d644dd56fbe58056ba33ff42a58482c86f330e92c9aceefdd86788171a1da2)
- package compiles on devel (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Christof Damian chris...@damian.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #10 from Christof Damian chris...@damian.net  2009-09-24 12:57:25 
EDT ---
New Package CVS Request
===
Package Name: php-doctrine-Doctrine 
Short Description: PHP Object Relational Mapper
Owners: cdamian
Branches: F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-09-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com

Bug 517643 depends on bug 517641, which changed state.

Bug 517641 Summary: Review Request: php-channel-doctrine - Adds doctrine 
project channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=517641

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Status|ASSIGNED|ON_QA
 Resolution||ERRATA
 Status|ON_QA   |CLOSED



--- Comment #7 from Tom spot Callaway tcall...@redhat.com  2009-09-22 
13:12:46 EDT ---
Provides: php-pear(doctrine/%{pear_name}) = %{version}

Shouldn't that be:

Provides:   php-pear(pear.doctrine-project.com/%{pear_name}) = %{version}

Looking at:
https://fedoraproject.org/wiki/Packaging:PHP#PEAR_Packages_from_a_non_standard_channel.2Frepository

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 CC||and...@topdog.za.net




--- Comment #1 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:25:05 EDT ---

This is covered by multiple licenses (LGPLv2+,BSD,MIT) your spec should reflect
that

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #2 from Christof Damian chris...@damian.net  2009-08-17 06:51:38 
EDT ---
(In reply to comment #1)
 This is covered by multiple licenses (LGPLv2+,BSD,MIT) your spec should 
 reflect
 that  

You are right, I didn't see that. I uploaded new versions:

Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec
SRPM URL:
http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-2.fc11.src.rpm

I set it to: LGPLv2 and MIT and BSD. I couldn't find any reference to
LGPLv2+, but maybe I missed it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #3 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:56:31 EDT ---

A GPL or LGPL licensed package that lacks any statement of what version that
it's licensed under in the source code/program output/accompanying docs is
technically licensed under *any* version of the GPL or LGPL, not just the
version in whatever COPYING file they include. Note that this is LGPLv2+, not
LGPL+, because version 2 was the first version of LGPL. 

https://fedoraproject.org/wiki/Licensing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #4 from Christof Damian chris...@damian.net  2009-08-17 07:22:55 
EDT ---
The LICENSE file contains: GNU LESSER GENERAL PUBLIC LICENSE Version 2.1,
February 1999 

It doesn't state or higher as far as I can see.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #5 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
07:25:50 EDT ---
Just read comment #3

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #6 from Christof Damian chris...@damian.net  2009-08-17 07:39:52 
EDT ---
(In reply to comment #5)
 Just read comment #3  

OK, changed to LGPLv2+ :

Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec
SRPM URL:
http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Christof Damian chris...@damian.net changed:

   What|Removed |Added

 Blocks||517191
 Depends on||517641




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review