[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 Thomas Spura changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #20 from Thomas Spura 2009-12-29 10:03:43 EDT --- (In reply to comment #19) > i.e. ALL FIXED Close to finish ;) You make the pype.py executable and after CRLF -> LF it's *not* executable again. Make it executable at the end of %prep and then, it'll work as expected. Unfortunately pype does *not* start anyway... Don't know why atm.. When executing, there is a File not found. This could be a dos newline, but this is shot down at CRLF -> LF... Anything else fine now. (.desktop file is ok this way.) Josiah, thanks for the quick release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #19 from Sandro Mathys 2009-12-29 03:01:51 EDT --- Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.9.1-1.fc12.src.rpm Guests are late, thus I had the time to pkg the new sources. Changes: - new src zip - changed License to GPLv2 only - no longer try to remove non-existant *.dll - defined %global majorminor (only used in Version and Source0) - worked around sed -i problem for the .desktop file (is that a good way?) i.e. ALL FIXED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #18 from Sandro Mathys 2009-12-29 02:01:36 EDT --- That's great Josiah, thanks! I try to get this into a new pkg ASAP, but I'll get a guest until new year which might result in some inactivity until afterwards. I'll try to it sooner tho. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #17 from Josiah Carlson 2009-12-29 01:33:52 EDT --- I've updated the license for exparse.py . It is now GPL v2 licensed. Originally I included lgpl.txt because it is referenced as part of wxwindows.txt (in addition for exparse.py), and is required by the wxWindows license. I have relicensed the wxWindows and LGPL v2 stuff as GPL v2 as is allowed by both the wxWindows and LGPL v2 licenses. I also added a line to get rid of the MS dll for the source distribution. Because of the non-code changes, I bumped the version number to 2.9.1, and uploaded a source-only release. sf.net is being painfully slow, so I've not been able to remove the old file quite yet, but the new one is available as of now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
--- Comment #16 from Thomas Spura 2009-12-27
12:16:39 EDT ---
You use 'sed -i'. Everytime you change the .desktop to contain PYTHONPATH, you
destroy it, when you run rpmbuild again.
(And the included .desktop does not contain PYTHONPATH again ;) )
If you upload the corrected one manually (with cvs add... and not with
./common/cvs-import.sh) this will be ok in cvs...
###
LICENSE
I'm still not sure, if the license is correct.
Josiah copied the LGPLv2 file and made some changes under GPLv2.
("[...] which
describes which parts of itself are lgpl v2 licensed. [...]") and in the file
is "adapted from", which means there where changes...
LGPLv2 allows relicensing under GPLv2 (see
https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix ).
-> Anything GPLv2
But I'm no layer.
If Josiah would agree to this, it'll be ok. If not, I'd like the legal team to
take a look.
###y
Anything else fine in the spec.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
--- Comment #15 from Sandro Mathys 2009-12-27 09:33:56
EDT ---
Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.9-1.fc12.src.rpm
(In reply to comment #13)
> This is a MUST. ;)
> If you have multiple licenses, you have to e.g. refer to in this case
> readme.txt or say in a comment, which files have which license.
Oh, I thought that only applies for the old version where licensing was not
clear. But now that I actually read the link it's clear :) Wonder why I never
saw this before, I pretty sure have other multi-license packages :/
FIXED (comment above License)
> anything under wxWidgets can be relicensed under GPL. BUT in fact, Josiah has
> already done that
> But the whole file itself is GPL -> no wxWidgets everywhere.
Right, after reading through the license comments again, seems to be sane.
> What is copyrighted under LGPL?
> There is a lgpl.txt, but that's it. Or am I wrong?
Josiah already answered that :) And so did you in comment #5 btw :)
> So, it stays for me: GPLv2.
So it's GPLv2 and LGPLv2. FIXED
>
>
> Some other issues:
> - $RPM_BUILD_ROOT%{_datadir}/%{name} is created, but empty (rest of old icon
> path) -> not needed anymore.
Hm...right. FIXED
> - sed -i -e "s;PYTHONPATH;%{python_sitelib};g" %{SOURCE1}
> has no effect. There is no pythonpath in the .desktop ( yet? ;) )
Uh, good catch! Grabbed the wrong desktop file in the end :/ FIXED
> - Don't copy *.pyc and *pyw.
> They are created later in the /usr/lib/rpm/brp-python-bytecompile part
> anyway.
> See
> https://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
> MUST: don't install them, and Josiah please don't include them (same for
> *.dll);)
FIXED. Not upstream tho.
> - changelog format:
> There is '* new version' -> '- new version'
Awww, right. FIXED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #14 from Josiah Carlson 2009-12-26 23:26:56 EDT --- The portion that is lgpl licensed is parts of plugins/exparse.py , which describes which parts of itself are lgpl v2 licensed, and includes a link to the original version of the files w/the original license. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
--- Comment #13 from Thomas Spura 2009-12-26
21:18:28 EDT ---
(In reply to comment #9)
> You can choose, between
> - adding a comment above the License: field
> - refer to a file upstream, where anything is explained
> - breack down in the %files section.
>
>
> See [1] for further information.
>
> [1]
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
>
This is a MUST. ;)
If you have multiple licenses, you have to e.g. refer to in this case
readme.txt or say in a comment, which files have which license.
wxWidgets is GPL compatible (see https://fedoraproject.org/wiki/Licensing ), so
anything under wxWidgets can be relicensed under GPL. BUT in fact, Josiah has
already done that:
from readme.txt:
'''
The portions of STCStyleEditor.py included in StyleSetter.py, which is used to
support styles, was released under the wxWindows license [...]
'''
But the whole file itself is GPL -> no wxWidgets everywhere.
What is copyrighted under LGPL?
There is a lgpl.txt, but that's it. Or am I wrong?
So, it stays for me: GPLv2.
@ Josiah: Correct me, if I'm wrong ;)
Some other issues:
- $RPM_BUILD_ROOT%{_datadir}/%{name} is created, but empty (rest of old icon
path) -> not needed anymore.
- sed -i -e "s;PYTHONPATH;%{python_sitelib};g" %{SOURCE1}
has no effect. There is no pythonpath in the .desktop ( yet? ;) )
- Don't copy *.pyc and *pyw.
They are created later in the /usr/lib/rpm/brp-python-bytecompile part
anyway.
See
https://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
MUST: don't install them, and Josiah please don't include them (same for
*.dll);)
- changelog format:
There is '* new version' -> '- new version'
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #12 from Sandro Mathys 2009-12-26 11:40:27 EDT --- Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.9-1.fc12.src.rpm Only small changes to the spec file: - new version - msvcp90.dll is now removed in %prep - pype.py needs CRLF -> LF treatment with the new release Everything else is still the same as in my last version above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #11 from Sandro Mathys 2009-12-23 11:44:28 EDT --- Just wanted to post the same thing as Josiah - there's a new release with the fixes and I'm going to create a new srpm with it. Might very well get 2010 until I'm able to do so, tho. But maybe I'll find some time to do it earlier... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #10 from Josiah Carlson 2009-12-23 11:39:14 EDT --- FYI, I released a new version with all of the license and code updates yesterday. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #9 from Thomas Spura 2009-12-23 10:08:54 EDT --- Sandro, I don't mind accepting this now with the old version, if it's clear, which file has which license. You can choose, between - adding a comment above the License: field - refer to a file upstream, where anything is explained - breack down in the %files section. See [1] for further information. [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 Josiah Carlson changed: What|Removed |Added CC||josiah.carl...@gmail.com --- Comment #8 from Josiah Carlson 2009-12-09 18:28:48 EDT --- I've updated the license for all files currently in the subversion repository at http://pype.svn.sourceforge.net/viewvc/pype/ . If you would prefer to pull from subversion, it wouldn't bother me. Otherwise, you can wait a little longer for me to cut a release. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #7 from Sandro Mathys 2009-12-09 08:57:03 EDT --- Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.8.8-3.fc12.src.rpm Thanks for the comments so far guys. The new package/spec fixes all that except for the licensing issue. Will contact upstream about it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
Christoph Wickert changed:
What|Removed |Added
CC||cwick...@fedoraproject.org
--- Comment #6 from Christoph Wickert 2009-11-15
14:47:39 EDT ---
(In reply to comment #5)
> Issues:
> - .desktop file needs Encoding=UTF-8 if you want to ship this into RHEL.
> (at least desktop-file-validate fails without this, desktop-file-install
> probably too) Just for fedora, this is not needed.
And should not be there in fact. An easy way to achieve this is to have the
Encoding in the desktop file and remove it if it's installed in Fedora:
desktop-file-install --dir=$RPM_BUILD_ROOT%{_datadir}/applications \
%if 0%{?fedora} >= 10
--remove-key=Encoding \
%endif
%{SOURCE1}
BTW: /usr/share/ is hardcoded in the desktop file, you should at least use sed
to make sure it is always correct. And please preserve timestamps during cp.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 Thomas Spura changed: What|Removed |Added Status|NEW |ASSIGNED CC||toms...@fedoraproject.org AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org Flag||fedora-review? --- Comment #5 from Thomas Spura 2009-11-15 12:45:59 EDT --- Review: OK - rpmlint is clean - .desktop file ok for fedora, for RHEL see issues - no missing BR - no locales - owns all dirctories, it should - no duplicate files - permissions ok - %clean ok - constantly macros - nothing in %doc for runtime - no subpackages needed - latest version packaged - sources match upstream both f286464ad703c3cceec2331a01d88971 Issues: - .desktop file needs Encoding=UTF-8 if you want to ship this into RHEL. (at least desktop-file-validate fails without this, desktop-file-install probably too) Just for fedora, this is not needed. - install: the icons are in the wrong place. When starting pype searchs in the python_site_packages_dir. Please install them into: /usr/lib/python2.6/site-packages/PyPE/icons/ and adjust the desktop file or place a link into the other icons directory. - License GPLv2 and LGPLv2 and wxWidgets is partly wrong, partly unknown: At least plugins/exparse.py is LGPLv2+. The other files (I checked for now) contained no license header so you don't know, if it should be (L)GPLv2 ONLY or v2+. Please query upstream to add license headers and ask them, if v2 only of v2+. - %doc: changelog is missing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #4 from Sandro Mathys 2009-09-22 03:24:15 EDT --- Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.8.8-2.fc11.src.rpm This took longer than I hoped, sorry. All of the above mentioned fixed (except for the setup.py install thingy as I commented before). Looking for the formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net --- Comment #3 from Fabian Affolter 2009-08-18 09:24:31 EDT --- Don't forget the .desktop file since PyPE is a GUI application. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
--- Comment #2 from Sandro Mathys 2009-08-17 06:05:03
EDT ---
Hi Jussi, thanks for the initial review!
(In reply to comment #1)
> Remove the shebang, Python libraries don't need it.
Okay :)
> A few things to correct:
>
> - Use the safer, time stamp keeping versions of the conversion tricks from
> http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8
> and
> http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings
Hmm...what I'm using is actually what I was told to use in another review, but
I'll look into this tricks :)
> - Don't install manually - use setup.py to do the install. Have a look at the
> sample python spec
> $ rpmdev-newspec python
Well, I did use the python spec-template. The thing is: there is no `setup.py
install` that does this thing for you and if you try to do it like that, you
only get the information that you should just copy the directory to wherever
you want to execute it from.
> - You need to own
> %{python_sitelib}/%{name}/
> not
> %{python_sitelib}/%{name}/*
Good catch!
I'll implement those changes ASAP, whenever I've got some minutes :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
Jussi Lehtola changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
--- Comment #1 from Jussi Lehtola 2009-08-17 05:54:38
EDT ---
(In reply to comment #0)
> Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec
> SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.8.8-1.fc11.src.rpm
> Description:
> PyPE (Python Programmers' Editor) was written in order to offer a
> lightweight but powerful editor for those of you who think emacs is too
> much and idle is too little. Syntax highlighting is included out of the
> box, as is multiple open documents via tabs.
>
> $ rpmlint SPECS/PyPE* SRPMS/PyPE* RPMS/noarch/PyPE*
> PyPE.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/PyPE/plugins/parsers.py 0644 /usr/bin/python
> 2 packages and 1 specfiles checked; 1 errors, 0 warnings
>
> Not sure what to do about this error - should I make the script executable or
> remove the shebang line? I'm pretty sure that script is not executed
> stand-alone.
Remove the shebang, Python libraries don't need it.
> By the way, this is my first python-package and I hope I did everything right
> :)
A few things to correct:
- Use the safer, time stamp keeping versions of the conversion tricks from
http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8
and
http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings
- Don't install manually - use setup.py to do the install. Have a look at the
sample python spec
$ rpmdev-newspec python
- You need to own
%{python_sitelib}/%{name}/
not
%{python_sitelib}/%{name}/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
