[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Alexander Kurtakov changed: What|Removed |Added Summary|Review Request: Pre-Review |Review Request: |Request: directory-naming - |directory-naming - |Directory Naming|Directory Naming --- Comment #2 from Alexander Kurtakov 2009-08-19 10:01:05 EDT --- Fix summary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #3 from Alexander Kurtakov 2009-08-19 10:12:16 EDT --- New sources: Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-4.fc12.src.rpm Changes: - Remove gcj support. - Build with build.sysclasspath=only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #4 from Alexander Kurtakov 2009-08-19 10:21:29 EDT --- New sources: Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-5.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt changed: What|Removed |Added CC||overh...@redhat.com --- Comment #5 from Andrew Overholt 2009-08-19 10:41:54 EDT --- A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM - I'd like to see a comment for the patch to the project files - I removed the remaining sed lines for "setproxy" and the build was fine. I think they can be removed. Otherwise, things look good. It's nice that all of the test suites run and have no failures/errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Peter Lemenkov changed: What|Removed |Added CC||lemen...@gmail.com Flag||needinfo?(akurt...@redhat.c ||om) --- Comment #6 from Peter Lemenkov 2009-08-19 15:19:11 EDT --- I don't understand - what's happening here? I saw that this package was already reviewed and even imported into CVS tree (as well as these two - #518219 and #518233 ). Why you created another Review Request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt changed: What|Removed |Added Flag|needinfo?(akurt...@redhat.c | |om) | --- Comment #8 from Andrew Overholt 2009-08-19 15:25:19 EDT --- Unsetting flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #7 from Andrew Overholt 2009-08-19 15:24:59 EDT --- See comment #1: "This is a full review request. The pre-review request was bug #500253." In an attempt to get maven updated, it was deemed necessary to "pre-review" some packages for bootstrapping purposes. We've decided to speed up the actual process by doing full reviews on packages that don't need this initial step. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #9 from Alexander Kurtakov 2009-08-20 07:41:49 EDT --- A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming FIXED except non-conffile-in-etc - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator FIXED. I don't see this warnings. - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM I think this is acceptable. - I'd like to see a comment for the patch to the project files FIXED. Removed. It was for maven1 build which we do not support. - I removed the remaining sed lines for "setproxy" and the build was fine. I think they can be removed. FIXED. Removed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-6.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #10 from Andrew Overholt 2009-08-20 10:20:43 EDT --- In the near future, I'd like to see us move away from this package as it appears to be dead upstream. The summary and description could also use some work. Let's do something more like: Summary: Apache Directory Naming Component Description: Naming is a lightweight, in-memory JNDI service provider. To enable flexible deployment with limited dependencies, Naming is divided in 6 packages, each producing a separate jar artifact. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #11 from Alexander Kurtakov 2009-08-20 13:09:03 EDT --- (In reply to comment #10) > In the near future, I'd like to see us move away from this package as it > appears to be dead upstream. The summary and description could also use some > work. Let's do something more like: Apache Directory project is pretty live project but this is just too old version. Latest release is from yesterday :). > > Summary: Apache Directory Naming Component > Description: Naming is a lightweight, in-memory JNDI service provider. To > enable flexible deployment with limited dependencies, Naming is divided in 6 > packages, each producing a separate jar artifact. Fixed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-7.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Andrew Overholt 2009-08-20 13:14:09 EDT --- (In reply to comment #11) > (In reply to comment #10) > > In the near future, I'd like to see us move away from this package as it > > appears to be dead upstream. The summary and description could also use > > some > > work. Let's do something more like: > Apache Directory project is pretty live project but this is just too old > version. > Latest release is from yesterday :). You're correct. I did mean the old component. > New sources: > Spec: http://akurtakov.fedorapeople.org/directory-naming.spec > Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-7.fc12.src.rpm Thanks. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Alexander Kurtakov changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #13 from Alexander Kurtakov 2009-08-20 13:43:42 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128106 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
