[Bug 518219] Review Request: dumbster - Fake SMTP Server

2009-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518219





--- Comment #3 from Alexander Kurtakov akurt...@redhat.com  2009-08-20 
08:01:37 EDT ---
(In reply to comment #2)
 - change the groups to make rpmlint quiet
Fixed.
 - md5sum of source doesn't match but contents do
I can't do anything about this.
 - you can remove the post{,un} requirements for javadoc
Fixed.
 - there are two sections to SimpleSmtpServer.java; I'd like to see the first
 one go upstream or at least be discussed with upstream.  I won't block on 
 this.
 
I'll consider sending a patch. But project looks pretty much dead.


Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec
SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-9.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518219] Review Request: dumbster - Fake SMTP Server

2009-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518219


Andrew Overholt overh...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Andrew Overholt overh...@redhat.com  2009-08-20 10:24:35 
EDT ---
I no longer get the javadoc issue.  Everything else looks good.  Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518219] Review Request: dumbster - Fake SMTP Server

2009-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518219


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #5 from Alexander Kurtakov akurt...@redhat.com  2009-08-20 
13:22:25 EDT ---
Build in rawhide.
http://koji.fedoraproject.org/koji/buildinfo?buildID=128103

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518219] Review Request: dumbster - Fake SMTP Server

2009-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518219


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Blocks||429551




--- Comment #1 from Alexander Kurtakov akurt...@redhat.com  2009-08-19 
10:44:34 EDT ---
This is a full review request.  The pre-review request was bug #500251.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518219] Review Request: dumbster - Fake SMTP Server

2009-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518219


Andrew Overholt overh...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||overh...@redhat.com
 AssignedTo|nob...@fedoraproject.org|overh...@redhat.com
   Flag||fedora-review?




--- Comment #2 from Andrew Overholt overh...@redhat.com  2009-08-19 11:43:26 
EDT ---
- change the groups to make rpmlint quiet
- md5sum of source doesn't match but contents do
- you can remove the post{,un} requirements for javadoc
- there are two sections to SimpleSmtpServer.java; I'd like to see the first
one go upstream or at least be discussed with upstream.  I won't block on this.

Otherwise, things are good to go

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review