[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2009-08-21 08:20:26 EDT --- (In reply to comment #1) OK naming, licensing OK files OK macros OK clean, sections ? can we get a better URL I can't find any better URL ? should it depend upon eclipse = 3.5? Yes, fixed. ? do we need to symlink to the JUnit bundles in the installation? They will be resolved from the eclipse-jdt (added as requires). X please version the tarball and its contents Done X we need an R3_5 tag passed to the fetch script. otherwise, ... Done OK source (md5sum doesn't match, but contents do) X rpmlint is not clean: $ rpmlint eclipse-testframework-3.5.0-1.fc11.noarch.rpm eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test.performance_3.5.0.200908201130 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/license.html eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/META-INF 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0/META-INF 0775 eclipse-testframework.noarch: W: dangling-relative-symlink /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.easymock_2.4.0.v20090202-0900.jar ../../../../../java/easymock2.jar eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/features/org.eclipse.test_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/epl-v10.html 1 packages and 0 specfiles checked; 8 errors, 3 warnings. Done. I wasn't seeing all the errors you listed. But the only rpmlint warning i see is dangling-relative-symlink which is normal. New sources: Spec URL: http://akurtakov.fedorapeople.org/eclipse-testframework.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-testframework-3.5.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Andrew Overholt overh...@redhat.com 2009-08-21 08:29:24 EDT --- Thanks for the fixes. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2009-08-21 08:40:28 EDT --- New Package CVS Request === Package Name: eclipse-testframework Short Description: Eclipse Test Framework Owners: akurtakov overholt Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Dennis Gilmore den...@ausil.us 2009-08-21 14:25:03 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #6 from Andrew Overholt overh...@redhat.com 2009-08-21 14:51:50 EDT --- Built: http://koji.fedoraproject.org/koji/buildinfo?buildID=128643 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||overh...@redhat.com AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 --- Comment #1 from Andrew Overholt overh...@redhat.com 2009-08-20 11:38:22 EDT --- OK naming, licensing OK files OK macros OK clean, sections ? can we get a better URL ? should it depend upon eclipse = 3.5? ? do we need to symlink to the JUnit bundles in the installation? X please version the tarball and its contents X we need an R3_5 tag passed to the fetch script. otherwise, ... OK source (md5sum doesn't match, but contents do) X rpmlint is not clean: $ rpmlint eclipse-testframework-3.5.0-1.fc11.noarch.rpm eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test.performance_3.5.0.200908201130 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/license.html eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/META-INF 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0/META-INF 0775 eclipse-testframework.noarch: W: dangling-relative-symlink /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.easymock_2.4.0.v20090202-0900.jar ../../../../../java/easymock2.jar eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/features/org.eclipse.test_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/epl-v10.html 1 packages and 0 specfiles checked; 8 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
