[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #11 from Rex Dieter rdie...@math.unl.edu 2009-09-24 12:36:18 EDT --- This is built and in the repos, I think we can close this now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522747
--- Comment #5 from Thomas Janssen thom...@fedoraproject.org 2009-09-17
11:08:56 EDT ---
Spec file changes:
sed trickery removed.
desktop-file-validate less verbose.
Version corrected.
Changed to %{_kde4_iconsdir} and %{_kde4_appsdir}
New spec and SRPM uploaded:
Spec Url: http://thomasj.fedorapeople.org/skrooge.spec
SRPM Url: http://thomasj.fedorapeople.org/skrooge-0.5.1-0.3.beta.fc10.src.rpm
[tho...@tusdell SPECS]$ rpmlint ../SRPMS/skrooge-0.5.1-0.3.beta.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[tho...@tusdell SPECS]$ rpmlint skrooge.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[tho...@tusdell SPECS]$ rpmlint
../RPMS/x86_64/skrooge*-0.5.1-0.3.beta.fc10.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1686251
--
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Ben Boeckel maths...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Ben Boeckel maths...@gmail.com 2009-09-17 11:20:10 EDT --- Looks good. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks|177841(FE-NEEDSPONSOR) | --- Comment #7 from Rex Dieter rdie...@math.unl.edu 2009-09-17 13:12:57 EDT --- I'll sponsor Thomas. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Thomas Janssen thom...@fedoraproject.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Thomas Janssen thom...@fedoraproject.org 2009-09-17 13:50:58 EDT --- New Package CVS Request === Package Name: skrooge Short Description: Skrooge is a personal finances manager, aiming at being simple and intuitive. Owners: thomasj Branches: F-10, F-11, F-12 InitialCC: -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #9 from Kevin Fenzi ke...@tummy.com 2009-09-17 15:10:11 EDT --- Email address tho...@fedoraproject.org is not a valid bugzilla email address. Either make a bugzilla account with that email address or change your email address in the Fedora Account System https://admin.fedoraproject.org/accounts/ to a valid bugzilla email address and try again. Please correct and reset the fedora-cvs flag. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag||fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-09-17 16:00:19 EDT --- we got this fixed up on IRC. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 --- Comment #4 from Thomas Janssen thom...@fedoraproject.org 2009-09-16 07:11:55 EDT --- Cleaned up desktop files. Got rid of Encoding= entrys. New spec and SRPM uploaded. Spec Url: http://thomasj.fedorapeople.org/skrooge.spec SRPM Url: http://thomasj.fedorapeople.org/skrooge-0.5.1-beta2.fc10.src.rpm [tho...@tusdell SPECS]$ rpmlint skrooge.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [tho...@tusdell SPECS]$ rpmlint ../SRPMS/skrooge-0.5.1-beta2.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [tho...@tusdell SPECS]$ rpmlint ../RPMS/x86_64/skrooge*-0.5.1-beta2.fc10.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. [tho...@tusdell SPECS]$ koji build --scratch dist-f12 ../SRPMS/skrooge-0.5.1-beta2.fc10.src.rpm Uploading srpm: ../SRPMS/skrooge-0.5.1-beta2.fc10.src.rpm [] 100% 00:03:31 5.40 MiB 26.21 KiB/sec Created task: 1682511 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1682511 Watching tasks (this may be safely interrupted)... 1682511 build (dist-f12, skrooge-0.5.1-beta2.fc10.src.rpm): open (x86-3.fedora.phx.redhat.com) 1682515 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, i686): open (x86-4.fedora.phx.redhat.com) 1682512 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, ppc): open (ppc5.fedora.phx.redhat.com) 1682514 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, ppc64): free 1682513 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, x86_64): open (x86-6.fedora.phx.redhat.com) 1682514 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, ppc64): free - open (ppc2.fedora.redhat.com) 1682515 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, i686): open (x86-4.fedora.phx.redhat.com) - closed 0 free 4 open 1 done 0 failed 1682513 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, x86_64): open (x86-6.fedora.phx.redhat.com) - closed 0 free 3 open 2 done 0 failed 1682512 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, ppc): open (ppc5.fedora.phx.redhat.com) - closed 0 free 2 open 3 done 0 failed 1682514 buildArch (skrooge-0.5.1-beta2.fc10.src.rpm, ppc64): open (ppc2.fedora.redhat.com) - closed 0 free 1 open 4 done 0 failed 1682511 build (dist-f12, skrooge-0.5.1-beta2.fc10.src.rpm): open (x86-3.fedora.phx.redhat.com) - closed 0 free 0 open 5 done 0 failed 1682511 build (dist-f12, skrooge-0.5.1-beta2.fc10.src.rpm) completed successfully -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 --- Comment #3 from Thomas Janssen thom...@fedoraproject.org 2009-09-15 13:25:48 EDT --- Changed the version to 0.5.1beta from a svn checkout. New spec and SRPM uploaded. Spec Url: http://thomasj.fedorapeople.org/skrooge.spec SRPM Url: http://thomasj.fedorapeople.org/skrooge-0.5.1-beta1.fc10.src.rpm [tho...@tusdell SPECS]$ rpmlint skrooge.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [tho...@tusdell SPECS]$ rpmlint ../RPMS/x86_64/skrooge*-0.5.1-beta1.fc10.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. [tho...@tusdell SPECS]$ rpmlint ../SRPMS/skrooge-0.5.1-beta1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [tho...@tusdell SPECS]$ koji build --scratch dist-f12 ../SRPMS/skrooge-0.5.1-beta1.fc10.src.rpm Uploading srpm: ../SRPMS/skrooge-0.5.1-beta1.fc10.src.rpm [] 100% 00:02:48 5.40 MiB 32.93 KiB/sec Created task: 1680960 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1680960 Watching tasks (this may be safely interrupted)... 1680960 build (dist-f12, skrooge-0.5.1-beta1.fc10.src.rpm): open (x86-7.fedora.phx.redhat.com) 1680961 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, ppc): free 1680964 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, i686): free 1680963 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, ppc64): free 1680962 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, x86_64): free 1680962 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, x86_64): free - open (x86-7.fedora.phx.redhat.com) 1680964 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, i686): free - open (x86-6.fedora.phx.redhat.com) 1680961 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, ppc): free - open (ppc9.fedora.phx.redhat.com) 1680963 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, ppc64): free - open (ppc5.fedora.phx.redhat.com) 1680962 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, x86_64): open (x86-7.fedora.phx.redhat.com) - closed 0 free 4 open 1 done 0 failed 1680964 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, i686): open (x86-6.fedora.phx.redhat.com) - closed 0 free 3 open 2 done 0 failed 1680963 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, ppc64): open (ppc5.fedora.phx.redhat.com) - closed 0 free 2 open 3 done 0 failed 1680961 buildArch (skrooge-0.5.1-beta1.fc10.src.rpm, ppc): open (ppc9.fedora.phx.redhat.com) - closed 0 free 1 open 4 done 0 failed 1680960 build (dist-f12, skrooge-0.5.1-beta1.fc10.src.rpm): open (x86-7.fedora.phx.redhat.com) - closed 0 free 0 open 5 done 0 failed 1680960 build (dist-f12, skrooge-0.5.1-beta1.fc10.src.rpm) completed successfully -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522747
--- Comment #2 from Thomas Janssen thom...@fedoraproject.org 2009-09-13
08:35:00 EDT ---
First of all, thank you!
New spec and srpm uploaded:
Spec Url: http://thomasj.fedorapeople.org/skrooge.spec
SRPM Url: http://thomasj.fedorapeople.org/skrooge-0.5.0-2.fc10.src.rpm
[tho...@tusdell SPECS]$ rpmlint ../RPMS/x86_64/skrooge*-0.5.0-1.fc10.x86_64.rpm
skrooge-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libskgbasemodeler.so.0.5.0 e...@glibc_2.2.5
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Bug is filed: https://bugs.kde.org/show_bug.cgi?id=207246
The debuginfo-without-sources is right now workaround'd with:
sed -i 's,SET(CMAKE_CXX_FLAGS -Wall ),SET(CMAKE_CXX_FLAGS -Wall
${CMAKE_CXX_FLAGS}),g' CMakeLists.txt
Bug is filed: https://bugs.kde.org/show_bug.cgi?id=207249
[tho...@tusdell SRPMS]$ koji build --scratch dist-f12
skrooge-0.5.0-2.fc10.src.rpm
Uploading srpm: skrooge-0.5.0-2.fc10.src.rpm
[] 100% 00:03:40 4.27 MiB 19.85 KiB/sec
Created task: 1674792
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1674792
Watching tasks (this may be safely interrupted)...
1674792 build (dist-f12, skrooge-0.5.0-2.fc10.src.rpm): open
(x86-4.fedora.phx.redhat.com)
1674796 buildArch (skrooge-0.5.0-2.fc10.src.rpm, i686): free
1674793 buildArch (skrooge-0.5.0-2.fc10.src.rpm, ppc): open
(ppc4.fedora.phx.redhat.com)
1674795 buildArch (skrooge-0.5.0-2.fc10.src.rpm, ppc64): open
(ppc5.fedora.phx.redhat.com)
1674794 buildArch (skrooge-0.5.0-2.fc10.src.rpm, x86_64): open
(x86-2.fedora.phx.redhat.com)
1674796 buildArch (skrooge-0.5.0-2.fc10.src.rpm, i686): free - open
(xenbuilder4.fedora.phx.redhat.com)
1674794 buildArch (skrooge-0.5.0-2.fc10.src.rpm, x86_64): open
(x86-2.fedora.phx.redhat.com) - closed
0 free 4 open 1 done 0 failed
1674796 buildArch (skrooge-0.5.0-2.fc10.src.rpm, i686): open
(xenbuilder4.fedora.phx.redhat.com) - closed
0 free 3 open 2 done 0 failed
1674793 buildArch (skrooge-0.5.0-2.fc10.src.rpm, ppc): open
(ppc4.fedora.phx.redhat.com) - closed
0 free 2 open 3 done 0 failed
1674795 buildArch (skrooge-0.5.0-2.fc10.src.rpm, ppc64): open
(ppc5.fedora.phx.redhat.com) - closed
0 free 1 open 4 done 0 failed
1674792 build (dist-f12, skrooge-0.5.0-2.fc10.src.rpm): open
(x86-4.fedora.phx.redhat.com) - closed
0 free 0 open 5 done 0 failed
1674792 build (dist-f12, skrooge-0.5.0-2.fc10.src.rpm) completed successfully
--
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Thomas Janssen thom...@fedoraproject.org changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522747
Ben Boeckel maths...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||maths...@gmail.com
AssignedTo|nob...@fedoraproject.org|maths...@gmail.com
Flag||fedora-review?
--- Comment #1 from Ben Boeckel maths...@gmail.com 2009-09-11 09:50:16 EDT
---
[OK] MUST: rpmlint must be run on every package. The output should be posted in
the review.
% rpmlint skrooge-*.rpm
skrooge-debuginfo.x86_64: E: debuginfo-without-sources
skrooge-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libskgbasemodeler.so.0.5.0 e...@glibc_2.2.5
4 packages and 0 specfiles checked; 1 errors, 1 warnings.
From IRC, the exit was discussed with upstream. Link to bug report or something
else so the issue can be tracked?
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[XX] MUST: The License field in the package spec file must match the actual
license.
License is GPLv2+ from the headers of the source files.
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The package bMUST/b successfully compile and build into binary
rpms on at least one primary architecture.
NOTE: When you update the spec file, please rebuild the SRPM and bump the
release. This helps reviewers know when the file was updated.
[OK] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[OK] MUST: The spec file MUST handle locales properly. This is done by using
the code%find_lang/code macro. Using code%{_datadir}/locale/*/code is
strictly forbidden.
[OK] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in code%post/code and code%postun/code.
[OK] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file'snbsp;%files listings.
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every code%files/code section
must include a code%defattr(...)/code line.
[XX] MUST: Each package must have anbsp;%clean section, which contains
coderm -rfnbsp;%{buildroot}/code (a
href=/wiki/Packaging/Guidelines#UsingBuildRootOptFlags
title=Packaging/Guidelines class=mw-redirector $RPM_BUILD_ROOT/a).
This is missing.
[XX] MUST: Each package must consistently use macros.
$RPM_BUILD_ROOT in %install, macro when removing extra .so files. Please use
one or the other. Also change the one %{_libdir} to %{_kde4_libdir} and
%{_kde4_docdir} instead of %{_kde4_sharedir}/doc.
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[OK] MUST: If a package includes something asnbsp;%doc, it must not affect the
runtime of the application. To summarize: If it is innbsp;%doc, the program
must run properly if it is not present.
[OK] MUST: Header files must be in a -devel package.
[OK] MUST: Static libraries must be in a -static package.
[OK] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[OK] MUST: If a package contains
